From: Jim Fehlig <jfehlig@suse.com>
To: Martin Kletzander <mkletzan@redhat.com>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
Subject: Re: [libvirt] [PATCH] libxl: use LIBXL_API_VERSION 0x040200
Date: Thu, 14 Apr 2016 16:37:35 -0600 [thread overview]
Message-ID: <57101BAF.1030705__1565.28365700996$1460673681$gmane$org@suse.com> (raw)
In-Reply-To: <20160414081108.GH5325@wheatley>
Martin Kletzander wrote:
> On Wed, Apr 13, 2016 at 05:37:05PM -0600, Jim Fehlig wrote:
>> To ensure the libvirt libxl driver will build with future versions
>> of Xen where the libxl API may change in incompatible ways,
>> explicitly use LIBXL_API_VERSION 0x040200. The libxl driver
>> does use new libxl APIs that have been added since Xen 4.2, but
>> currently it does not make use of any changes made to existing
>> APIs such as libxl_domain_create_restore or libxl_set_vcpuaffinity.
>> The version can be bumped if/when the libxl driver consumes the
>> changed APIs.
>>
>> Further details can be found in the following discussion thread
>>
>> https://www.redhat.com/archives/libvir-list/2016-April/msg00178.html
>> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>> ---
>> src/Makefile.am | 1 +
>> src/libxl/libxl_conf.h | 12 ------------
>> src/libxl/libxl_domain.c | 15 ---------------
>> 3 files changed, 1 insertion(+), 27 deletions(-)
>>
>> diff --git a/src/Makefile.am b/src/Makefile.am
>> index 08ff301..259a474 100644
>> --- a/src/Makefile.am
>> +++ b/src/Makefile.am
>> @@ -1311,6 +1311,7 @@ endif ! WITH_DRIVER_MODULES
>>
>> libvirt_driver_libxl_impl_la_CFLAGS = \
>> $(LIBXL_CFLAGS) \
>> + -DLIBXL_API_VERSION=0x040200 \
>
> Adding it to LIBXL_CFLAGS in configure.ac would make it show after
> configure, but that's something probably only I would find interesting
> =)
I think that is a good idea. I've sent a V2 that moves the define from
src/Makefile.am to configure.ac
https://www.redhat.com/archives/libvir-list/2016-April/msg00938.html
> I'm no libxl expert and I don't have it on my system, so I can't try
> building it, hence only weak ACK from me. If it build for you then it's
> fine as nobody objects as I see.
I've built libvirt with the V2 patch against Xen 4.2, 4.3, 4.4, and 4.7/master.
Regards,
Jim
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-14 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 23:37 [PATCH] libxl: use LIBXL_API_VERSION 0x040200 Jim Fehlig
2016-04-14 7:41 ` Dario Faggioli
2016-04-14 8:11 ` [libvirt] " Martin Kletzander
2016-04-14 22:37 ` Jim Fehlig [this message]
2016-04-14 8:33 ` George Dunlap
[not found] ` <CAFLBxZbNpBvmXZqSx6ib1ryAOQXscYLOM-gQqomhvNCKkLWOjg@mail.gmail.com>
2016-04-14 12:55 ` Dario Faggioli
2016-04-14 22:32 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='57101BAF.1030705__1565.28365700996$1460673681$gmane$org@suse.com' \
--to=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=mkletzan@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).