From: Martin Kletzander <mkletzan@redhat.com>
To: Jim Fehlig <jfehlig@suse.com>
Cc: libvir-list@redhat.com, xen-devel@lists.xen.org
Subject: Re: [libvirt] [PATCH] libxl: use LIBXL_API_VERSION 0x040200
Date: Thu, 14 Apr 2016 10:11:08 +0200 [thread overview]
Message-ID: <20160414081108.GH5325@wheatley> (raw)
In-Reply-To: <1460590625-3805-1-git-send-email-jfehlig@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1500 bytes --]
On Wed, Apr 13, 2016 at 05:37:05PM -0600, Jim Fehlig wrote:
>To ensure the libvirt libxl driver will build with future versions
>of Xen where the libxl API may change in incompatible ways,
>explicitly use LIBXL_API_VERSION 0x040200. The libxl driver
>does use new libxl APIs that have been added since Xen 4.2, but
>currently it does not make use of any changes made to existing
>APIs such as libxl_domain_create_restore or libxl_set_vcpuaffinity.
>The version can be bumped if/when the libxl driver consumes the
>changed APIs.
>
>Further details can be found in the following discussion thread
>
>https://www.redhat.com/archives/libvir-list/2016-April/msg00178.html
>Signed-off-by: Jim Fehlig <jfehlig@suse.com>
>---
> src/Makefile.am | 1 +
> src/libxl/libxl_conf.h | 12 ------------
> src/libxl/libxl_domain.c | 15 ---------------
> 3 files changed, 1 insertion(+), 27 deletions(-)
>
>diff --git a/src/Makefile.am b/src/Makefile.am
>index 08ff301..259a474 100644
>--- a/src/Makefile.am
>+++ b/src/Makefile.am
>@@ -1311,6 +1311,7 @@ endif ! WITH_DRIVER_MODULES
>
> libvirt_driver_libxl_impl_la_CFLAGS = \
> $(LIBXL_CFLAGS) \
>+ -DLIBXL_API_VERSION=0x040200 \
Adding it to LIBXL_CFLAGS in configure.ac would make it show after
configure, but that's something probably only I would find interesting
=) I'm no libxl expert and I don't have it on my system, so I can't try
building it, hence only weak ACK from me. If it build for you then it's
fine as nobody objects as I see.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-14 8:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 23:37 [PATCH] libxl: use LIBXL_API_VERSION 0x040200 Jim Fehlig
2016-04-14 7:41 ` Dario Faggioli
2016-04-14 8:11 ` Martin Kletzander [this message]
2016-04-14 22:37 ` [libvirt] " Jim Fehlig
2016-04-14 8:33 ` George Dunlap
[not found] ` <CAFLBxZbNpBvmXZqSx6ib1ryAOQXscYLOM-gQqomhvNCKkLWOjg@mail.gmail.com>
2016-04-14 12:55 ` Dario Faggioli
2016-04-14 22:32 ` Jim Fehlig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414081108.GH5325@wheatley \
--to=mkletzan@redhat.com \
--cc=jfehlig@suse.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).