From: "Jan Beulich" <JBeulich@suse.com>
To: Quan Xu <quan.xu@intel.com>
Cc: dario.faggioli@citrix.com, feng.wu@intel.com,
kevin.tian@intel.com, xen-devel@lists.xen.org
Subject: Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue
Date: Thu, 02 Jun 2016 05:07:21 -0600 [thread overview]
Message-ID: <57502F8902000078000F0E43@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1464771922-7794-4-git-send-email-quan.xu@intel.com>
>>> On 01.06.16 at 11:05, <quan.xu@intel.com> wrote:
> --- a/xen/drivers/passthrough/vtd/extern.h
> +++ b/xen/drivers/passthrough/vtd/extern.h
> @@ -21,6 +21,7 @@
> #define _VTD_EXTERN_H_
>
> #include "dmar.h"
> +#include "../ats.h"
Why? You don't de-reference struct pci_ats_dev * in this file, so
all you'd need is a forward declaration. But then this is not in line
with your v11 change description above, so I wonder whether
you actually sent a stale patch. After all I thought the v10
discussion (see
http://lists.xenproject.org/archives/html/xen-devel/2016-05/msg02208.html
) had made clear that this passing down, besides reducing the
number of arguments of some function, would also be meant to
eliminate ...
> +static void dev_invalidate_iotlb_timeout(struct iommu *iommu, u16 did,
> + struct pci_ats_dev *ats_dev)
> +{
> + struct domain *d = NULL;
> + struct pci_dev *pdev;
> +
> + if ( test_bit(did, iommu->domid_bitmap) )
> + d = rcu_lock_domain_by_id(iommu->domid_map[did]);
> +
> + /*
> + * In case the domain has been freed or the IOMMU domid bitmap is
> + * not valid, the device no longer belongs to this domain.
> + */
> + if ( d == NULL )
> + return;
> +
> + pcidevs_lock();
> +
> + for_each_pdev(d, pdev)
> + {
> + if ( (pdev->seg == ats_dev->seg) &&
> + (pdev->bus == ats_dev->bus) &&
> + (pdev->devfn == ats_dev->devfn) )
> + {
> + ASSERT(pdev->domain);
> + list_del(&pdev->domain_list);
> + pdev->domain = NULL;
> + pci_hide_existing_device(pdev);
> + break;
> + }
> + }
> +
> + pcidevs_unlock();
... this loop (and locking). (Of course such a change may better be
done in another preparatory patch.)
> + if ( !is_hardware_domain(d) )
> + domain_crash(d);
> + else
> + printk(XENLOG_WARNING VTDPREFIX
> + " dom%d: ATS device %04x:%02x:%02x.%u flush failed\n",
> + d->domain_id, ats_dev->seg, ats_dev->bus,
> + PCI_SLOT(ats_dev->devfn), PCI_FUNC(ats_dev->devfn));
Please use the same logic for logging and crashing as you do in
the other series, so that at least on average a resulting DomU
crash will be accompanied with some indication of the reason
beyond just the source file name and line number.
> +static int __must_check dev_invalidate_sync(struct iommu *iommu, u16 did,
> + struct pci_ats_dev *ats_dev)
> +{
> + struct qi_ctrl *qi_ctrl = iommu_qi_ctrl(iommu);
> + int rc = 0;
> +
> + if ( qi_ctrl->qinval_maddr )
> + {
> + rc = queue_invalidate_wait(iommu, 0, 1, 1, 1);
> +
> + if ( rc == -ETIMEDOUT )
> + dev_invalidate_iotlb_timeout(iommu, did, ats_dev);
> + }
> +
> + return rc;
> +}
I've never really understood why invalidate_sync() returns success
when it didn't do anything. Now that you copy this same behavior
here, I really need to ask you to explain that.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-02 11:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 9:05 [Patch v11 0/3] VT-d Device-TLB flush issue Xu, Quan
2016-06-01 9:05 ` [Patch v11 1/3] IOMMU: add a timeout parameter for device IOTLB invalidation Xu, Quan
2016-06-02 10:24 ` Jan Beulich
2016-06-15 2:55 ` Xu, Quan
2016-06-01 9:05 ` [Patch v11 2/3] vt-d: synchronize for Device-TLB flush one by one Xu, Quan
2016-06-02 10:49 ` Jan Beulich
2016-06-01 9:05 ` [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue Xu, Quan
2016-06-02 11:07 ` Jan Beulich [this message]
2016-06-16 8:42 ` Xu, Quan
2016-06-16 9:04 ` Jan Beulich
2016-06-17 6:08 ` Xu, Quan
2016-06-17 7:00 ` Jan Beulich
2016-06-17 8:15 ` Xu, Quan
2016-06-17 8:40 ` Jan Beulich
2016-06-22 15:54 ` Xu, Quan
2016-06-22 16:18 ` Jan Beulich
2016-06-23 2:08 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57502F8902000078000F0E43@prv-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).