Re: [PATCH RFC 15/20] acpi: Move ACPI code to xen/common/libacpi

From: "Jan Beulich" <JBeulich@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	xen-devel@lists.xen.org,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	roger.pau@citrix.com
Subject: Re: [PATCH RFC 15/20] acpi: Move ACPI code to xen/common/libacpi
Date: Tue, 07 Jun 2016 00:20:17 -0600	[thread overview]
Message-ID: <575683C102000078000F2673@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5755A031.4090800@oracle.com>

>>> On 06.06.16 at 18:09, <boris.ostrovsky@oracle.com> wrote:
> On 06/06/2016 09:05 AM, Jan Beulich wrote:
>>>>> On 06.04.16 at 03:25, <boris.ostrovsky@oracle.com> wrote:
>>>  .gitignore                                                        | 8 ++++----
>>>  tools/firmware/hvmloader/Makefile                                 | 3 +--
>>>  tools/firmware/hvmloader/smbios.c                                 | 1 +
>>>  tools/firmware/rombios/32bit/Makefile                             | 2 +-
>>>  tools/firmware/rombios/32bit/tcgbios/Makefile                     | 2 +-
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/Makefile    | 6 +++---
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/README      | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/acpi2_0.h   | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/build.c     | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/dsdt.asl    | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/mk_dsdt.c   | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/ssdt_pm.asl | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/ssdt_s3.asl | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/ssdt_s4.asl | 0
>>>  .../firmware/hvmloader/acpi => xen/common/libacpi}/ssdt_tpm.asl   | 0
>>>  .../hvmloader/acpi => xen/common/libacpi}/static_tables.c         | 0
>>>  {tools/firmware/hvmloader/acpi => xen/common/libacpi}/x86.h       | 0
>>>  17 files changed, 11 insertions(+), 11 deletions(-)
>> As mentioned before, new placement subject to determination
>> whether this is to eventually be used by the hypervisor.
> 
> 
> Roger, when do you think you'll be able to see whether dom0 builder will
> use this? I can start working on v1 with assumption that this will be
> used by hypervisor. We can drop the last patch (and modify this one to
> move acpi to somewhere in tools) if it becomes clear that hypervisor
> does not want it.

I guess if it doesn't become clear by then we could still allow for it
to be moved as you do, with the expectation of a follow-up patch
to move it under tools/ if it turns out Dom0 doesn't want/need it.

>>> --- a/tools/firmware/hvmloader/acpi/Makefile
>>> +++ b/xen/common/libacpi/Makefile
>>> @@ -14,13 +14,13 @@
>>>  # this program; If not, see <http://www.gnu.org/licenses/>.
>>>  #
>>>  
>>> -XEN_ROOT = $(CURDIR)/../../../..
>>> -include $(XEN_ROOT)/tools/firmware/Rules.mk
>>> +XEN_ROOT = $(CURDIR)/../../..
>>> +include $(XEN_ROOT)/Config.mk
>>>  
>>>  C_SRC = build.c dsdt_anycpu.c dsdt_15cpu.c static_tables.c dsdt_anycpu_qemu_xen.c
>>>  OBJS  = $(patsubst %.c,%.o,$(C_SRC))
>>>  
>>> -CFLAGS += $(CFLAGS_xeninclude)
>>> +CFLAGS_xeninclude = -I$(XEN_ROOT)/tools/include
>> Where would this now get consumed? This appears to be a tools/
>> only setting, which should thus no longer be needed here.
> 
> This is needed for building mk_dsdt.

Which you rename later on. This being a tools/ construct, I'd
appreciate the renaming to happen right away, both to cut the
connection to tools/ and to make the (sole) consumer obvious to
reviewers.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel