From: Julien Grall <julien.grall@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Wei Chen <wei.chen@linaro.org>
Subject: Re: [PATCH V6 3/3] arm/acpi: Add Server Base System Architecture UART support
Date: Tue, 7 Jun 2016 15:09:15 +0100 [thread overview]
Message-ID: <5756D58B.4050109@arm.com> (raw)
In-Reply-To: <1465253940-26236-3-git-send-email-shankerd@codeaurora.org>
Hello Shanker,
On 06/06/16 23:59, Shanker Donthineni wrote:
> The ARM Server Base System Architecture describes a generic UART
> interface. It doesn't support clock control registers, modem
> control, DMA and hardware flow control features. So, extend the
> driver probe() to handle SBSA interface and skip the accessing
> PL011 registers that are not described in SBSA document
> (ARM-DEN-0029 Version 3.0, 6 APPENDIX B: GENERIC UART).
I would mention that all the access should be 32-bit. Maybe on top of
pl011_{write,read} too.
Other than that:
Reviewed-by: Julien Grall <julien.grall@arm.com>
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 22:58 [PATCH V6 1/3] drivers/pl011: Don't configure baudrate Shanker Donthineni
2016-06-06 22:58 ` [PATCH V6 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS Shanker Donthineni
2016-06-07 13:58 ` Julien Grall
2016-06-07 14:03 ` Shanker Donthineni
2016-06-07 14:09 ` Julien Grall
2016-06-06 22:59 ` [PATCH V6 3/3] arm/acpi: Add Server Base System Architecture UART support Shanker Donthineni
2016-06-07 14:09 ` Julien Grall [this message]
2016-06-07 14:00 ` [PATCH V6 1/3] drivers/pl011: Don't configure baudrate Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5756D58B.4050109@arm.com \
--to=julien.grall@arm.com \
--cc=andre.przywara@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).