From: "Jan Beulich" <JBeulich@suse.com>
To: David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Juergen Gross <JGross@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing
Date: Tue, 07 Jun 2016 08:14:04 -0600 [thread overview]
Message-ID: <5756F2CC02000078000F2A64__33257.1763814942$1465308911$gmane$org@prv-mh.provo.novell.com> (raw)
In-Reply-To: <5756D4F4.7070802@oracle.com>
>>> On 07.06.16 at 16:06, <boris.ostrovsky@oracle.com> wrote:
> On 06/07/2016 02:30 AM, Jan Beulich wrote:
>> Reads following writes with all address bits set to 1 should return all
>> changeable address bits as one, not the BAR size (nor, as was the case
>> for the upper half of 64-bit BARs, the high half of the region's end
>> address). Presumably this didn't cause any problems so far because
>> consumers use the value to calculate the size (usually via val & -val),
>> and do nothing else with it.
>>
>> But also consider the exception here: Unimplemented BARs should always
>> return all zeroes.
>>
>> And finally, the check for whether to return the sizing address on read
>> for the ROM BAR should ignore all non-address bits, not just the ROM
>> Enable one.
>
>
> Should this go to stable trees as well?
Not sure - we had no active reports of problems. The context this
was found in did not really have an issue because it was broken.
I guess I'll leave this to you maintainers...
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5756857802000078000F268D@prv-mh.provo.novell.com>
2016-06-07 6:30 ` [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing Jan Beulich
2016-06-07 6:31 ` [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() Jan Beulich
[not found] ` <5756864102000078000F269A@prv-mh.provo.novell.com>
2016-06-07 14:06 ` [PATCH v2 1/2] xen-pciback: return proper values during BAR sizing Boris Ostrovsky
[not found] ` <5756D4F4.7070802@oracle.com>
2016-06-07 14:14 ` Jan Beulich [this message]
2016-06-24 9:13 ` [PATCH v3 " Jan Beulich
[not found] ` <576D15DE02000078000F8678@prv-mh.provo.novell.com>
2016-06-24 14:08 ` David Vrabel
[not found] ` <5756866F02000078000F269D@prv-mh.provo.novell.com>
2016-06-07 14:06 ` [PATCH v2 2/2] xen-pciback: clean up {bar, rom}_init() Boris Ostrovsky
2016-06-24 15:01 ` David Vrabel
[not found] ` <576D4B59.9070906@citrix.com>
2016-06-27 7:24 ` Jan Beulich
[not found] ` <5770F0CF02000078000F8DD3@prv-mh.provo.novell.com>
2016-06-29 12:42 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5756F2CC02000078000F2A64__33257.1763814942$1465308911$gmane$org@prv-mh.provo.novell.com' \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).