* xen/x86: efi: warning value truncated
@ 2016-06-13 17:13 Julien Grall
2016-06-14 9:24 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Julien Grall @ 2016-06-13 17:13 UTC (permalink / raw)
To: Xen Devel, Konrad Rzeszutek Wilk; +Cc: Andrew Cooper, Jan Beulich
Hi Konrad,
I noticed the warnings below when building Xen x86
with Livepatch enabled.
/local/home/julieng/works/xen/xen/.xen.efi.0s.S: Assembler messages:
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:21: Warning: value 0x7d2f80000591 truncated to 0x80000591
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:22: Warning: value 0x7d2f80000958 truncated to 0x80000958
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:23: Warning: value 0x7d2f8000095a truncated to 0x8000095a
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:24: Warning: value 0x7d2f80000960 truncated to 0x80000960
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:25: Warning: value 0x7d2f8000111e truncated to 0x8000111e
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:26: Warning: value 0x7d2f80001122 truncated to 0x80001122
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:27: Warning: value 0x7d2f80001126 truncated to 0x80001126
/local/home/julieng/works/xen/xen/.xen.efi.0s.S:6943: Warning: value 0x100650000 truncated to 0x650000
/local/home/julieng/works/xen/xen/.xen.efi.1s.S: Assembler messages:
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:21: Warning: value 0x7d2f80000591 truncated to 0x80000591
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:22: Warning: value 0x7d2f80000958 truncated to 0x80000958
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:23: Warning: value 0x7d2f8000095a truncated to 0x8000095a
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:24: Warning: value 0x7d2f80000960 truncated to 0x80000960
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:25: Warning: value 0x7d2f8000111e truncated to 0x8000111e
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:26: Warning: value 0x7d2f80001122 truncated to 0x80001122
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:27: Warning: value 0x7d2f80001126 truncated to 0x80001126
/local/home/julieng/works/xen/xen/.xen.efi.1s.S:6943: Warning: value 0x100650000 truncated to 0x650000
Note that I have tried to disable
CONFIG_FAST_SYMBOL_LOOKUP just in case and the warnings
were still present.
Any ideas?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xen/x86: efi: warning value truncated
2016-06-13 17:13 xen/x86: efi: warning value truncated Julien Grall
@ 2016-06-14 9:24 ` Jan Beulich
2016-06-14 10:15 ` Ross Lagerwall
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-06-14 9:24 UTC (permalink / raw)
To: Julien Grall, Konrad Rzeszutek Wilk; +Cc: Andrew Cooper, Xen Devel
>>> On 13.06.16 at 19:13, <julien.grall@arm.com> wrote:
> I noticed the warnings below when building Xen x86
> with Livepatch enabled.
I did notice some of these too (not as many though, iirc), but I
didn't get around yet to check what exactly is causing them. Since
they're in the symbol table files only, I didn't consider them too
concerning (at worst some odd symbol won't be found or be
associated with the wrong address).
Jan
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S: Assembler messages:
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:21: Warning: value 0x7d2f80000591 truncated to 0x80000591
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:22: Warning: value 0x7d2f80000958 truncated to 0x80000958
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:23: Warning: value 0x7d2f8000095a truncated to 0x8000095a
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:24: Warning: value 0x7d2f80000960 truncated to 0x80000960
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:25: Warning: value 0x7d2f8000111e truncated to 0x8000111e
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:26: Warning: value 0x7d2f80001122 truncated to 0x80001122
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:27: Warning: value 0x7d2f80001126 truncated to 0x80001126
> /local/home/julieng/works/xen/xen/.xen.efi.0s.S:6943: Warning: value 0x100650000 truncated to 0x650000
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S: Assembler messages:
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:21: Warning: value 0x7d2f80000591 truncated to 0x80000591
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:22: Warning: value 0x7d2f80000958 truncated to 0x80000958
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:23: Warning: value 0x7d2f8000095a truncated to 0x8000095a
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:24: Warning: value 0x7d2f80000960 truncated to 0x80000960
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:25: Warning: value 0x7d2f8000111e truncated to 0x8000111e
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:26: Warning: value 0x7d2f80001122 truncated to 0x80001122
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:27: Warning: value 0x7d2f80001126 truncated to 0x80001126
> /local/home/julieng/works/xen/xen/.xen.efi.1s.S:6943: Warning: value 0x100650000 truncated to 0x650000
>
> Note that I have tried to disable
> CONFIG_FAST_SYMBOL_LOOKUP just in case and the warnings
> were still present.
>
> Any ideas?
>
> Cheers,
>
> --
> Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xen/x86: efi: warning value truncated
2016-06-14 9:24 ` Jan Beulich
@ 2016-06-14 10:15 ` Ross Lagerwall
2016-06-14 10:50 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2016-06-14 10:15 UTC (permalink / raw)
To: Jan Beulich; +Cc: Andrew Cooper, Julien Grall, Xen Devel
On 06/14/2016 10:24 AM, Jan Beulich wrote:
>>>> On 13.06.16 at 19:13, <julien.grall@arm.com> wrote:
>> I noticed the warnings below when building Xen x86
>> with Livepatch enabled.
>
> I did notice some of these too (not as many though, iirc), but I
> didn't get around yet to check what exactly is causing them. Since
> they're in the symbol table files only, I didn't consider them too
> concerning (at worst some odd symbol won't be found or be
> associated with the wrong address).
>
On my build, they are:
multiboot1_header_start|000000000000051e| ? |
multiboot1_header_start|00000000000008a1| ? |
multiboot1_header_start|00000000000008a3| ? |
multiboot1_header_start|00000000000008a8| ? |
multiboot1_header_start|000000000000102f| ? |
multiboot1_header_start|0000000000001033| ? |
multiboot1_header_start|0000000000001037| ? |
__init_end |ffff82d180650000| D |
None of these look particularly important to me.
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xen/x86: efi: warning value truncated
2016-06-14 10:15 ` Ross Lagerwall
@ 2016-06-14 10:50 ` Jan Beulich
2016-06-14 11:19 ` Ross Lagerwall
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2016-06-14 10:50 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: Andrew Cooper, Julien Grall, XenDevel
>>> On 14.06.16 at 12:15, <ross.lagerwall@citrix.com> wrote:
> On 06/14/2016 10:24 AM, Jan Beulich wrote:
>>>>> On 13.06.16 at 19:13, <julien.grall@arm.com> wrote:
>>> I noticed the warnings below when building Xen x86
>>> with Livepatch enabled.
>>
>> I did notice some of these too (not as many though, iirc), but I
>> didn't get around yet to check what exactly is causing them. Since
>> they're in the symbol table files only, I didn't consider them too
>> concerning (at worst some odd symbol won't be found or be
>> associated with the wrong address).
>>
>
> On my build, they are:
>
> multiboot1_header_start|000000000000051e| ? |
> multiboot1_header_start|00000000000008a1| ? |
> multiboot1_header_start|00000000000008a3| ? |
> multiboot1_header_start|00000000000008a8| ? |
> multiboot1_header_start|000000000000102f| ? |
> multiboot1_header_start|0000000000001033| ? |
> multiboot1_header_start|0000000000001037| ? |
> __init_end |ffff82d180650000| D |
Aren't these symbols from the final binary (which get wrongly named
without fixed binutils)? Whereas Julien's issue was with warnings from
the assembler?
> None of these look particularly important to me.
Not very important I agree with. But we should still try to eliminate
such warnings, as they validly raise concerns to whoever gets to
see them (and likely doesn't know they're irrelevant).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xen/x86: efi: warning value truncated
2016-06-14 10:50 ` Jan Beulich
@ 2016-06-14 11:19 ` Ross Lagerwall
2016-06-14 12:36 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2016-06-14 11:19 UTC (permalink / raw)
To: Jan Beulich; +Cc: Andrew Cooper, Julien Grall, XenDevel
On 06/14/2016 11:50 AM, Jan Beulich wrote:
>>>> On 14.06.16 at 12:15, <ross.lagerwall@citrix.com> wrote:
>> On 06/14/2016 10:24 AM, Jan Beulich wrote:
>>>>>> On 13.06.16 at 19:13, <julien.grall@arm.com> wrote:
>>>> I noticed the warnings below when building Xen x86
>>>> with Livepatch enabled.
>>>
>>> I did notice some of these too (not as many though, iirc), but I
>>> didn't get around yet to check what exactly is causing them. Since
>>> they're in the symbol table files only, I didn't consider them too
>>> concerning (at worst some odd symbol won't be found or be
>>> associated with the wrong address).
>>>
>>
>> On my build, they are:
>>
>> multiboot1_header_start|000000000000051e| ? |
>> multiboot1_header_start|00000000000008a1| ? |
>> multiboot1_header_start|00000000000008a3| ? |
>> multiboot1_header_start|00000000000008a8| ? |
>> multiboot1_header_start|000000000000102f| ? |
>> multiboot1_header_start|0000000000001033| ? |
>> multiboot1_header_start|0000000000001037| ? |
>> __init_end |ffff82d180650000| D |
>
> Aren't these symbols from the final binary (which get wrongly named
> without fixed binutils)? Whereas Julien's issue was with warnings from
> the assembler?
It looks the same to me. Here are the warnings:
/home/ross/src/xen/xen/.xen.efi.0s.S: Assembler messages:
/home/ross/src/xen/xen/.xen.efi.0s.S:21: Warning: value 0x7d2f8000051e
truncated to 0x8000051e
/home/ross/src/xen/xen/.xen.efi.0s.S:22: Warning: value 0x7d2f800008a1
truncated to 0x800008a1
/home/ross/src/xen/xen/.xen.efi.0s.S:23: Warning: value 0x7d2f800008a3
truncated to 0x800008a3
/home/ross/src/xen/xen/.xen.efi.0s.S:24: Warning: value 0x7d2f800008a8
truncated to 0x800008a8
/home/ross/src/xen/xen/.xen.efi.0s.S:25: Warning: value 0x7d2f8000102f
truncated to 0x8000102f
/home/ross/src/xen/xen/.xen.efi.0s.S:26: Warning: value 0x7d2f80001033
truncated to 0x80001033
/home/ross/src/xen/xen/.xen.efi.0s.S:27: Warning: value 0x7d2f80001037
truncated to 0x80001037
/home/ross/src/xen/xen/.xen.efi.0s.S:6741: Warning: value 0x100650000
truncated to 0x650000
/home/ross/src/xen/xen/.xen.efi.1s.S: Assembler messages:
/home/ross/src/xen/xen/.xen.efi.1s.S:21: Warning: value 0x7d2f8000051e
truncated to 0x8000051e
/home/ross/src/xen/xen/.xen.efi.1s.S:22: Warning: value 0x7d2f800008a1
truncated to 0x800008a1
/home/ross/src/xen/xen/.xen.efi.1s.S:23: Warning: value 0x7d2f800008a3
truncated to 0x800008a3
/home/ross/src/xen/xen/.xen.efi.1s.S:24: Warning: value 0x7d2f800008a8
truncated to 0x800008a8
/home/ross/src/xen/xen/.xen.efi.1s.S:25: Warning: value 0x7d2f8000102f
truncated to 0x8000102f
/home/ross/src/xen/xen/.xen.efi.1s.S:26: Warning: value 0x7d2f80001033
truncated to 0x80001033
/home/ross/src/xen/xen/.xen.efi.1s.S:27: Warning: value 0x7d2f80001037
truncated to 0x80001037
/home/ross/src/xen/xen/.xen.efi.1s.S:6740: Warning: value 0x100650000
truncated to 0x650000
So, e.g. taking the last one, the assembly file contains a line:
PTR 0xffff82d180650000 - SYMBOLS_ORIGIN
In this case SYMBOLS_ORIGIN is 0xffff82d080000000 and so it resolves to:
.long 0x100650000
which overflows.
>
>> None of these look particularly important to me.
>
> Not very important I agree with. But we should still try to eliminate
> such warnings, as they validly raise concerns to whoever gets to
> see them (and likely doesn't know they're irrelevant).
>
Agreed.
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: xen/x86: efi: warning value truncated
2016-06-14 11:19 ` Ross Lagerwall
@ 2016-06-14 12:36 ` Jan Beulich
0 siblings, 0 replies; 6+ messages in thread
From: Jan Beulich @ 2016-06-14 12:36 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: Andrew Cooper, Julien Grall, XenDevel
>>> On 14.06.16 at 13:19, <ross.lagerwall@citrix.com> wrote:
> On 06/14/2016 11:50 AM, Jan Beulich wrote:
>>>>> On 14.06.16 at 12:15, <ross.lagerwall@citrix.com> wrote:
>>> On 06/14/2016 10:24 AM, Jan Beulich wrote:
>>>>>>> On 13.06.16 at 19:13, <julien.grall@arm.com> wrote:
>>>>> I noticed the warnings below when building Xen x86
>>>>> with Livepatch enabled.
>>>>
>>>> I did notice some of these too (not as many though, iirc), but I
>>>> didn't get around yet to check what exactly is causing them. Since
>>>> they're in the symbol table files only, I didn't consider them too
>>>> concerning (at worst some odd symbol won't be found or be
>>>> associated with the wrong address).
>>>>
>>>
>>> On my build, they are:
>>>
>>> multiboot1_header_start|000000000000051e| ? |
>>> multiboot1_header_start|00000000000008a1| ? |
>>> multiboot1_header_start|00000000000008a3| ? |
>>> multiboot1_header_start|00000000000008a8| ? |
>>> multiboot1_header_start|000000000000102f| ? |
>>> multiboot1_header_start|0000000000001033| ? |
>>> multiboot1_header_start|0000000000001037| ? |
>>> __init_end |ffff82d180650000| D |
>>
>> Aren't these symbols from the final binary (which get wrongly named
>> without fixed binutils)? Whereas Julien's issue was with warnings from
>> the assembler?
>
> It looks the same to me. Here are the warnings:
>
> /home/ross/src/xen/xen/.xen.efi.0s.S: Assembler messages:
> /home/ross/src/xen/xen/.xen.efi.0s.S:21: Warning: value 0x7d2f8000051e
> truncated to 0x8000051e
> /home/ross/src/xen/xen/.xen.efi.0s.S:22: Warning: value 0x7d2f800008a1
> truncated to 0x800008a1
> /home/ross/src/xen/xen/.xen.efi.0s.S:23: Warning: value 0x7d2f800008a3
> truncated to 0x800008a3
> /home/ross/src/xen/xen/.xen.efi.0s.S:24: Warning: value 0x7d2f800008a8
> truncated to 0x800008a8
> /home/ross/src/xen/xen/.xen.efi.0s.S:25: Warning: value 0x7d2f8000102f
> truncated to 0x8000102f
> /home/ross/src/xen/xen/.xen.efi.0s.S:26: Warning: value 0x7d2f80001033
> truncated to 0x80001033
> /home/ross/src/xen/xen/.xen.efi.0s.S:27: Warning: value 0x7d2f80001037
> truncated to 0x80001037
> /home/ross/src/xen/xen/.xen.efi.0s.S:6741: Warning: value 0x100650000
> truncated to 0x650000
> /home/ross/src/xen/xen/.xen.efi.1s.S: Assembler messages:
> /home/ross/src/xen/xen/.xen.efi.1s.S:21: Warning: value 0x7d2f8000051e
> truncated to 0x8000051e
> /home/ross/src/xen/xen/.xen.efi.1s.S:22: Warning: value 0x7d2f800008a1
> truncated to 0x800008a1
> /home/ross/src/xen/xen/.xen.efi.1s.S:23: Warning: value 0x7d2f800008a3
> truncated to 0x800008a3
> /home/ross/src/xen/xen/.xen.efi.1s.S:24: Warning: value 0x7d2f800008a8
> truncated to 0x800008a8
> /home/ross/src/xen/xen/.xen.efi.1s.S:25: Warning: value 0x7d2f8000102f
> truncated to 0x8000102f
> /home/ross/src/xen/xen/.xen.efi.1s.S:26: Warning: value 0x7d2f80001033
> truncated to 0x80001033
> /home/ross/src/xen/xen/.xen.efi.1s.S:27: Warning: value 0x7d2f80001037
> truncated to 0x80001037
> /home/ross/src/xen/xen/.xen.efi.1s.S:6740: Warning: value 0x100650000
> truncated to 0x650000
>
> So, e.g. taking the last one, the assembly file contains a line:
> PTR 0xffff82d180650000 - SYMBOLS_ORIGIN
>
> In this case SYMBOLS_ORIGIN is 0xffff82d080000000 and so it resolves to:
> .long 0x100650000
> which overflows.
Oh, right, I got confused. These are wrong because the intermediate
binary had bogus symbol table entries. So indeed these should be gone
with recent enough binutils. And I have to admit that I then have no
idea how to prevent those warnings.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-14 12:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-13 17:13 xen/x86: efi: warning value truncated Julien Grall
2016-06-14 9:24 ` Jan Beulich
2016-06-14 10:15 ` Ross Lagerwall
2016-06-14 10:50 ` Jan Beulich
2016-06-14 11:19 ` Ross Lagerwall
2016-06-14 12:36 ` Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).