From: Julien Grall <julien.grall@arm.com>
To: "Xu, Quan" <quan.xu@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"Tian, Kevin" <kevin.tian@intel.com>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>
Subject: Re: [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic )
Date: Fri, 17 Jun 2016 14:34:30 +0100 [thread overview]
Message-ID: <5763FC66.5030004@arm.com> (raw)
In-Reply-To: <945CA011AD5F084CBEA3E851C0AB28894B8E6F02@SHSMSX103.ccr.corp.intel.com>
Hi Quan,
On 17/06/16 09:51, Xu, Quan wrote:
> + arm/amd maintainers..
>
> On June 01, 2016 5:05 PM, Xu, Quan <quan.xu@intel.com> wrote:
>> If Device-TLB flush timed out, we hide the target ATS device immediately and
>> crash the domain owning this ATS device. If impacted domain is hardware
>> domain, just throw out a warning.
>>
>> By hiding the device, we make sure it can't be assigned to any domain any
>> longer (see device_assigned).
>
> DomU (other than Dom0) gets crashed when a device IOTLB flush times out. I suppose that's what you will want on ARM/AMD then too.
Correct it is what we want for ARM :).
> We need to move up the crash logic , as similar as iommu_map_page() / iommu_unmap_page().
>
> - add the crash logic to iommu_iotlb_flush() / iommu_iotlb_flush_all().
>
> - when IOMMU/MMU share page tables, we need to fix it one by one.
> -- on amd, we need to add the crash logic to amd_iommu_flush_pages().
> -- on intel, we need to add the crash logic to iommu_pte_flush().
> -- on arm, we benefit that we add the crash logic to iommu_iotlb_flush().
Right.
>
>
> Taken together, we need to add crash logic to
> iommu_iotlb_flush() / iommu_iotlb_flush_all() / iommu_pte_flush() / amd_iommu_flush_pages().
For iommu_iotlb_* yes as it is common code. I don't know for the others.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-17 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 8:51 [Patch v11 3/3] vt-d: fix vt-d Device-TLB flush timeout issue (+ crash logic ) Xu, Quan
2016-06-17 13:34 ` Julien Grall [this message]
2016-06-18 9:54 ` Xu, Quan
2016-06-20 6:53 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5763FC66.5030004@arm.com \
--to=julien.grall@arm.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=quan.xu@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).