Re: [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

[Shannon Zhao <zhaoshenglong@huawei.com>]

On 2016/6/24 0:42, Julien Grall wrote:
> 
> 
> On 23/06/16 15:50, Stefano Stabellini wrote:
>> On Thu, 23 Jun 2016, Shannon Zhao wrote:
>>> diff --git a/tools/libxl/libxl_empty_dsdt_arm.asl
>>> b/tools/libxl/libxl_empty_dsdt_arm.asl
>>> new file mode 100644
>>> index 0000000..005fa6a
>>> --- /dev/null
>>> +++ b/tools/libxl/libxl_empty_dsdt_arm.asl
>>> @@ -0,0 +1,22 @@
>>> +/******************************************************************************
>>>
>>> + * DSDT for Xen ARM DomU
>>> + *
>>> + * Copyright (c) 2004, Intel Corporation.
>>> + *
>>> + * This program is free software; you can redistribute it and/or
>>> modify it
>>> + * under the terms and conditions of the GNU General Public License,
>>> + * version 2, as published by the Free Software Foundation.
>>> + *
>>> + * This program is distributed in the hope it will be useful, but
>>> WITHOUT
>>> + * ANY WARRANTY; without even the implied warranty of
>>> MERCHANTABILITY or
>>> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
>>> License for
>>> + * more details.
>>> + *
>>> + * You should have received a copy of the GNU General Public License
>>> along with
>>> + * this program; If not, see <http://www.gnu.org/licenses/>.
>>> + */
>>> +
>>> +DefinitionBlock ("DSDT.aml", "DSDT", 3, "XenARM", "Xen DSDT", 1)
>>> +{
>>> +
>>> +}
>>
>> Why do we need C code to generate the "static" asl? Can't we just
>> manually writing the asl code here and get rid of libxl_mk_dsdt_arm.c?
> 
> Whilst I agree that manually writing the asl code sounds more appealing,
> we need to write one node per processor. So currently this would be 128
> nodes and this will likely increase in the future.
> 
> Generating the asl has the advantage to be able to add new property in
> the processor node easily without having to modify one by one all the
> nodes.
Yes, and maybe in the future it needs to add other information in DSDT.

Thanks,
-- 
Shannon


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel