* Re: [PATCH] xen-scsiback: correct return value checks on xenbus_scanf()
[not found] <577E286802000078000FBECF@suse.com>
@ 2016-07-07 12:34 ` Juergen Gross
0 siblings, 0 replies; 2+ messages in thread
From: Juergen Gross @ 2016-07-07 12:34 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, linux-scsi
On 07/07/16 10:01, Jan Beulich wrote:
> Only a positive return value indicates success.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/xen/xen-scsiback.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c
> +++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsiback.c
> @@ -1071,7 +1071,7 @@ static void scsiback_do_1lun_hotplug(str
> /* read status */
> snprintf(state, sizeof(state), "vscsi-devs/%s/state", ent);
> err = xenbus_scanf(XBT_NIL, dev->nodename, state, "%u", &device_state);
> - if (XENBUS_EXIST_ERR(err))
> + if (err <= 0)
> return;
>
> /* physical SCSI device */
> @@ -1089,7 +1089,7 @@ static void scsiback_do_1lun_hotplug(str
> snprintf(str, sizeof(str), "vscsi-devs/%s/v-dev", ent);
> err = xenbus_scanf(XBT_NIL, dev->nodename, str, "%u:%u:%u:%u",
> &vir.hst, &vir.chn, &vir.tgt, &vir.lun);
> - if (XENBUS_EXIST_ERR(err)) {
> + if (err != 4) {
> xenbus_printf(XBT_NIL, dev->nodename, state,
> "%d", XenbusStateClosed);
> return;
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] xen-scsiback: correct return value checks on xenbus_scanf()
@ 2016-07-07 8:01 Jan Beulich
0 siblings, 0 replies; 2+ messages in thread
From: Jan Beulich @ 2016-07-07 8:01 UTC (permalink / raw)
To: Juergen Gross; +Cc: xen-devel, linux-scsi
Only a positive return value indicates success.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
drivers/xen/xen-scsiback.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- 4.7-rc6-xenbus_scanf.orig/drivers/xen/xen-scsiback.c
+++ 4.7-rc6-xenbus_scanf/drivers/xen/xen-scsiback.c
@@ -1071,7 +1071,7 @@ static void scsiback_do_1lun_hotplug(str
/* read status */
snprintf(state, sizeof(state), "vscsi-devs/%s/state", ent);
err = xenbus_scanf(XBT_NIL, dev->nodename, state, "%u", &device_state);
- if (XENBUS_EXIST_ERR(err))
+ if (err <= 0)
return;
/* physical SCSI device */
@@ -1089,7 +1089,7 @@ static void scsiback_do_1lun_hotplug(str
snprintf(str, sizeof(str), "vscsi-devs/%s/v-dev", ent);
err = xenbus_scanf(XBT_NIL, dev->nodename, str, "%u:%u:%u:%u",
&vir.hst, &vir.chn, &vir.tgt, &vir.lun);
- if (XENBUS_EXIST_ERR(err)) {
+ if (err != 4) {
xenbus_printf(XBT_NIL, dev->nodename, state,
"%d", XenbusStateClosed);
return;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-07 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <577E286802000078000FBECF@suse.com>
2016-07-07 12:34 ` [PATCH] xen-scsiback: correct return value checks on xenbus_scanf() Juergen Gross
2016-07-07 8:01 Jan Beulich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).