Re: [PATCH 01/19] xen: Create a new file xen_pvdev.c

From: Eric Blake <eblake@redhat.com>
To: Quan Xu <quan.xu2@aliyun.com>, rea <emilcondrea@gmail.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"anthony.perard" <anthony.perard@citrix.com>
Cc: dgdegra <dgdegra@tycho.nsa.gov>,
	xen-devel <xen-devel@lists.xen.org>,
	"wei.liu2" <wei.liu2@citrix.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	stefanb <stefanb@linux.vnet.ibm.com>
Subject: Re: [PATCH 01/19] xen: Create a new file xen_pvdev.c
Date: Mon, 18 Jul 2016 08:57:38 -0600	[thread overview]
Message-ID: <578CEE62.7010700@redhat.com> (raw)
In-Reply-To: <b45e5a51-c310-47fc-b417-d4aa5faea338.quan.xu2@aliyun.com>

[-- Attachment #1.1.1: Type: text/plain, Size: 1571 bytes --]

On 07/17/2016 01:41 AM, Quan Xu wrote:
> 
> [Quan:]: comment starts with [Quan:]
> 

This line doesn't belong in a commit message; it's fine to put it after
the --- separator though, if it aids mailing list reviewers.

> 
> The purpose of the new file is to store generic functions shared by frontendand backends such as xenstore operations, xendevs.
> 

s/frontendand/front end and/

Please wrap your commit message lines.  Since 'git log' displays logs
with indentation, wrapping around 72 characters is ideal.

> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> Signed-off-by: Emil Condrea <emilcondrea@xxxxxxxxx>

These are not valid S-o-b, therefore this patch cannot be applied as-is.

> -int xenstore_read_int(const char *base, const char *node, int *ival)
> -{
> -    char *val;
> -    int rc = -1;
> -
> -    val = xenstore_read_str(base, node);
> [Quan:]:  IMO, it is better to initialize val when declares.  the same comment for the other 'val'
> -    if (val && 1 == sscanf(val, "%d", ival)) {

This is not a valid patch.  Are you replying to a patch that someone
else posted? If so, your quoting style is VERY difficult to read.
Please consider using a leading > before every line that you are quoting
(rather than pasting it verbatim as if you had written it), and include
a blank line both before and after every line that you insert, to call
visual attention to what is your reply vs. what you are quoting.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel