xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Juergen Gross <JGross@suse.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Jennifer Herbert <jennifer.herbert@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT
Date: Mon, 01 Aug 2016 05:15:50 -0600	[thread overview]
Message-ID: <579F4B86020000780010138D@prv-mh.provo.novell.com> (raw)
In-Reply-To: <1468249078-6949-1-git-send-email-david.vrabel@citrix.com>

>>> On 11.07.16 at 16:57, <david.vrabel@citrix.com> wrote:
> @@ -553,6 +570,27 @@ static long evtchn_ioctl(struct file *file,
>  		break;
>  	}
>  
> +	case IOCTL_EVTCHN_RESTRICT_DOMID: {
> +		struct ioctl_evtchn_restrict_domid ierd;
> +
> +		rc = -EACCES;
> +		if (u->restrict_domid != UNRESTRICTED_DOMID)
> +			break;
> +
> +		rc = -EFAULT;
> +		if (copy_from_user(&ierd, uarg, sizeof(ierd)))
> +		    break;
> +
> +		rc = -EINVAL;
> +		if (ierd.domid == 0 || ierd.domid >= DOMID_FIRST_RESERVED)
> +			break;

Any reason you special case Dom0 here, but not the conceptually
more general hardware and/or control domain?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-08-01 11:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 14:57 [PATCHv1] xen/evtchn: add IOCTL_EVTCHN_RESTRICT David Vrabel
2016-07-11 15:31 ` Boris Ostrovsky
2016-07-11 16:15   ` David Vrabel
2016-07-11 16:33     ` Andrew Cooper
2016-07-11 16:44       ` David Vrabel
2016-07-11 16:55         ` Boris Ostrovsky
2016-08-01 11:15 ` Jan Beulich [this message]
2016-08-01 12:58   ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=579F4B86020000780010138D@prv-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=JGross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jennifer.herbert@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).