xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Baodong Chen <chenbaodong@mxnavi.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	WeiLiu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen: make tracebuffer configurable
Date: Mon, 03 Jun 2019 04:54:11 -0600	[thread overview]
Message-ID: <5CF4FC53020000780023490D@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <058c6adb-0cba-0825-264a-f31d24ba21fe@mxnavi.com>

>>> On 03.06.19 at 12:41, <chenbaodong@mxnavi.com> wrote:

> On 6/3/19 16:31, Jan Beulich wrote:
>>>>> On 03.06.19 at 05:07, <chenbaodong@mxnavi.com> wrote:
>>> On 5/31/19 19:10, Jan Beulich wrote:
>>>>>>> On 30.05.19 at 12:17, <chenbaodong@mxnavi.com> wrote:
>>>>> Default: enabled.
>>>>> Can be disabled for smaller code footprint.
>>>> But you're aware that we're, for now at least, trying to limit the
>>>> number of independently selectable config options? Ones depending
>>>> on EXPERT are sort of an exception in certain cases.
>>> Limit the number of independently selectable config sounds good to me.
>>>
>>> Does the following looks good?
>>>
>>> +config HAS_TRACEBUFFER
>>> +       bool "Enable/Disable tracebuffer"  if EXPERT = "y"
>>> +       ---help---
>>> +         Enable or disable tracebuffer function.
>>> +         Xen internal running status(trace event) will be saved to
>>> trace memory
>>> +         when enabled.
>>> +
>> The EXPERT addition make introducing this fine by me. But its name
>> is still wrong, and the help text also needs further improvement imo.
> 
> Hi Jan, thanks for your kindly review and feedback.
> 
> For this, would you please give your suggestions about the name and help 
> text?

As far as the name is concerned, the HAS_ should be dropped.
I'm afraid I don't have a particular suggestion for the help text.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Baodong Chen" <chenbaodong@mxnavi.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	WeiLiu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen: make tracebuffer configurable
Date: Mon, 03 Jun 2019 04:54:11 -0600	[thread overview]
Message-ID: <5CF4FC53020000780023490D@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190603105411.HnFbwaWj1VblOTlP4my1EKsNEuLW833rueYBxZIYdXk@z> (raw)
In-Reply-To: <058c6adb-0cba-0825-264a-f31d24ba21fe@mxnavi.com>

>>> On 03.06.19 at 12:41, <chenbaodong@mxnavi.com> wrote:

> On 6/3/19 16:31, Jan Beulich wrote:
>>>>> On 03.06.19 at 05:07, <chenbaodong@mxnavi.com> wrote:
>>> On 5/31/19 19:10, Jan Beulich wrote:
>>>>>>> On 30.05.19 at 12:17, <chenbaodong@mxnavi.com> wrote:
>>>>> Default: enabled.
>>>>> Can be disabled for smaller code footprint.
>>>> But you're aware that we're, for now at least, trying to limit the
>>>> number of independently selectable config options? Ones depending
>>>> on EXPERT are sort of an exception in certain cases.
>>> Limit the number of independently selectable config sounds good to me.
>>>
>>> Does the following looks good?
>>>
>>> +config HAS_TRACEBUFFER
>>> +       bool "Enable/Disable tracebuffer"  if EXPERT = "y"
>>> +       ---help---
>>> +         Enable or disable tracebuffer function.
>>> +         Xen internal running status(trace event) will be saved to
>>> trace memory
>>> +         when enabled.
>>> +
>> The EXPERT addition make introducing this fine by me. But its name
>> is still wrong, and the help text also needs further improvement imo.
> 
> Hi Jan, thanks for your kindly review and feedback.
> 
> For this, would you please give your suggestions about the name and help 
> text?

As far as the name is concerned, the HAS_ should be dropped.
I'm afraid I don't have a particular suggestion for the help text.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-06-03 10:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-30 10:17 [PATCH] xen: make tracebuffer configurable Baodong Chen
2019-05-30 10:17 ` [Xen-devel] " Baodong Chen
2019-05-31 11:10 ` Jan Beulich
2019-05-31 11:10   ` [Xen-devel] " Jan Beulich
2019-05-31 12:58   ` George Dunlap
2019-05-31 12:58     ` [Xen-devel] " George Dunlap
2019-05-31 13:15     ` Jan Beulich
2019-05-31 13:15       ` [Xen-devel] " Jan Beulich
2019-06-03  3:18     ` chenbaodong
2019-06-03  3:18       ` [Xen-devel] " chenbaodong
2019-06-03  3:07   ` chenbaodong
2019-06-03  3:07     ` [Xen-devel] " chenbaodong
2019-06-03  8:31     ` Jan Beulich
2019-06-03  8:31       ` [Xen-devel] " Jan Beulich
2019-06-03 10:41       ` chenbaodong
2019-06-03 10:41         ` [Xen-devel] " chenbaodong
2019-06-03 10:54         ` Jan Beulich [this message]
2019-06-03 10:54           ` Jan Beulich
2019-06-03 14:08           ` George Dunlap
2019-06-03 14:08             ` [Xen-devel] " George Dunlap
2019-06-03 14:31             ` Jan Beulich
2019-06-03 14:31               ` [Xen-devel] " Jan Beulich
2019-06-04  0:49               ` chenbaodong
2019-06-04  0:49                 ` [Xen-devel] " chenbaodong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CF4FC53020000780023490D@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=chenbaodong@mxnavi.com \
    --cc=julien.grall@arm.com \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=tim@xen.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).