From: "Jan Beulich" <JBeulich@suse.com>
To: "George Dunlap" <George.Dunlap@eu.citrix.com>,
"Tamas K Lengyel" <tamas@tklengyel.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 1/4] x86/mem_sharing: reorder when pages are unlocked and released
Date: Mon, 17 Jun 2019 07:46:15 -0600 [thread overview]
Message-ID: <5D0799A70200007800238D1F@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <CABfawhkgpRyC95bVTKGhnN0+2GqoRJ7zentgKQud070YCxSb+A@mail.gmail.com>
>>> On 17.06.19 at 14:23, <tamas@tklengyel.com> wrote:
> On Thu, May 16, 2019 at 11:38 PM Tamas K Lengyel <tamas@tklengyel.com> wrote:
>>
>> Calling _put_page_type while also holding the page_lock
>> for that page can cause a deadlock.
>>
>> The comment being dropped is incorrect since it's now out-of-date.
>>
>> Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
>
> Patch ping. Unclear whose Ack is strictly needed as this is only
> touching mem_sharing code and nothing else.
In such cases I think it should be the next-level-up maintainer whose
ack should be chased; at least that's what I typically would do. This
would be George in this cases afaict. Otherwise, if George wouldn't
have the cycles to look at this closely enough to give an ack, I'd be
happy to provide mine as "replacement".
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-06-17 13:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 21:37 [PATCH v5 1/4] x86/mem_sharing: reorder when pages are unlocked and released Tamas K Lengyel
2019-05-16 21:37 ` [Xen-devel] " Tamas K Lengyel
2019-05-16 21:37 ` [PATCH v5 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr Tamas K Lengyel
2019-05-16 21:37 ` [Xen-devel] " Tamas K Lengyel
2019-05-17 7:21 ` Jan Beulich
2019-05-17 7:21 ` [Xen-devel] " Jan Beulich
2019-05-17 20:04 ` Tamas K Lengyel
2019-05-17 20:04 ` [Xen-devel] " Tamas K Lengyel
2019-06-17 12:21 ` Tamas K Lengyel
2019-05-16 21:37 ` [PATCH v5 3/4] x86/mem_sharing: enable mem_share audit mode only in debug builds Tamas K Lengyel
2019-05-16 21:37 ` [Xen-devel] " Tamas K Lengyel
2019-06-17 12:24 ` Tamas K Lengyel
2019-05-16 21:37 ` [PATCH v5 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled Tamas K Lengyel
2019-05-16 21:37 ` [Xen-devel] " Tamas K Lengyel
2019-05-17 7:23 ` Jan Beulich
2019-05-17 7:23 ` [Xen-devel] " Jan Beulich
2019-06-03 8:26 ` Jan Beulich
2019-06-03 8:26 ` [Xen-devel] " Jan Beulich
2019-06-03 16:38 ` Tamas K Lengyel
2019-06-03 16:38 ` [Xen-devel] " Tamas K Lengyel
2019-06-03 16:40 ` Julien Grall
2019-06-03 16:40 ` [Xen-devel] " Julien Grall
2019-06-03 16:55 ` Tamas K Lengyel
2019-06-03 16:55 ` [Xen-devel] " Tamas K Lengyel
2019-06-04 8:41 ` Razvan Cojocaru
2019-06-04 8:41 ` [Xen-devel] " Razvan Cojocaru
2019-06-04 14:36 ` Daniel De Graaf
2019-06-17 12:17 ` Tamas K Lengyel
2019-06-17 12:23 ` [Xen-devel] [PATCH v5 1/4] x86/mem_sharing: reorder when pages are unlocked and released Tamas K Lengyel
2019-06-17 13:46 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D0799A70200007800238D1F@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).