Re: [Xen-devel] [PATCH v5 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled

From: Tamas K Lengyel <tamas@tklengyel.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	Daniel de Graaf <dgdegra@tycho.nsa.gov>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v5 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled
Date: Mon, 3 Jun 2019 10:55:01 -0600	[thread overview]
Message-ID: <CABfawhkgLojGX9Bs=+ygGUzhdnToKt-mR5sgEDDmFqisWxKCtQ@mail.gmail.com> (raw)
Message-ID: <20190603165501.2kwMYdAhMAz7Tq2gsrlJrY0UEVOF2IaH2-yAwOTdhsg@z> (raw)
In-Reply-To: <e83a925b-9914-b648-4c6d-3bf6ae9f0769@arm.com>

On Mon, Jun 3, 2019 at 10:40 AM Julien Grall <julien.grall@arm.com> wrote:
>
> Hi,
>
> On 03/06/2019 17:38, Tamas K Lengyel wrote:
> > On Mon, Jun 3, 2019 at 2:26 AM Jan Beulich <JBeulich@suse.com> wrote:
> >>
> >>>>> On 16.05.19 at 23:37, <tamas@tklengyel.com> wrote:
> >>> Disable it by default as it is only an experimental subsystem.
> >>>
> >>> Signed-off-by: Tamas K Lengyel <tamas@tklengyel.com>
> >>> Cc: Jan Beulich <jbeulich@suse.com>
> >>> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> >>> Cc: Wei Liu <wei.liu2@citrix.com>
> >>> Cc: Roger Pau Monne <roger.pau@citrix.com>
> >>> Cc: George Dunlap <George.Dunlap@eu.citrix.com>
> >>> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> >>> Cc: Julien Grall <julien.grall@arm.com>
> >>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >>> Cc: Stefano Stabellini <sstabellini@kernel.org>
> >>> Cc: Tim Deegan <tim@xen.org>
> >>> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> >>> ----
> >>> v4: add ASSERT_UNREACHABLE to inlined functions where applicable & other
> >>> fixups
> >>> ---
> >>>   xen/arch/x86/Kconfig              |  6 +++++-
> >>>   xen/arch/x86/domain.c             |  2 ++
> >>>   xen/arch/x86/domctl.c             |  2 ++
> >>>   xen/arch/x86/mm/Makefile          |  2 +-
> >>>   xen/arch/x86/x86_64/compat/mm.c   |  2 ++
> >>>   xen/arch/x86/x86_64/mm.c          |  2 ++
> >>>   xen/common/Kconfig                |  3 ---
> >>>   xen/common/domain.c               |  2 +-
> >>>   xen/common/grant_table.c          |  2 +-
> >>>   xen/common/memory.c               |  2 +-
> >>>   xen/common/vm_event.c             |  6 +++---
> >>>   xen/include/asm-x86/mem_sharing.h | 28 ++++++++++++++++++++++++++++
> >>>   xen/include/asm-x86/mm.h          |  3 +++
> >>>   xen/include/xen/sched.h           |  2 +-
> >>>   xen/include/xsm/dummy.h           |  2 +-
> >>>   xen/include/xsm/xsm.h             |  4 ++--
> >>>   xen/xsm/dummy.c                   |  2 +-
> >>>   xen/xsm/flask/hooks.c             |  4 ++--
> >>>   18 files changed, 58 insertions(+), 18 deletions(-)
> >>
> >> Daniel, it looks like you weren't Cc-ed here, but your ack is needed.
> >
> > Indeed, I've also seem to have missed CC-ing Razvan (fixed now).
>
> Nowadays, add_maintainers.pl should do the right for you without having to
> modifying by hand each patch:
>
> 42sh> scripts/add_maintainers.pl -d .

Hi Julien,
ah good call! I've been using scripts/get_maintainers.pl which
evidently is more error-prone in case the patch goes through revisions
and I forget to re-check if more people need CC-ing now.

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel