From: "Jan Beulich" <JBeulich@suse.com>
To: "Paul Durrant" <paul.durrant@citrix.com>
Cc: aisaila@bitdefender.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>, WeiLiu <wl@xen.org>,
Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] viridian: unify time sources
Date: Fri, 21 Jun 2019 09:20:30 -0600 [thread overview]
Message-ID: <5D0CF5BE020000780023A3C7@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <e4ec7405ea9b4c9bb94f903a51561582@AMSPEX02CL03.citrite.net>
>>> On 21.06.19 at 15:58, <Paul.Durrant@citrix.com> wrote:
>> -----Original Message-----
>> From: Alexandru Stefan ISAILA <aisaila@bitdefender.com>
>> Sent: 21 June 2019 14:49
>> To: Paul Durrant <Paul.Durrant@citrix.com>; xen-devel@lists.xenproject.org
>> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu <wl@xen.org>; Jan Beulich
> <jbeulich@suse.com>;
>> Roger Pau Monne <roger.pau@citrix.com>
>> Subject: Re: [Xen-devel] [PATCH v2] viridian: unify time sources
>>
>> > /*
>> > @@ -136,7 +100,7 @@ static int64_t time_ref_count(const struct domain *d)
>> > * 128 bit number which is then shifted 64 times to the right to obtain
>> > * the high 64 bits."
>> > */
>>
>> Is there a good reason for using signed offset here? If so then maybe
>> you should change the return type or check for bounds.
>
> The offset is actually negative most of the time but the resulting reference
> time should be unsigned so the return type of time_ref_count() does need
> fixing.
Is switching it from int64_t to uint64_t all that's needed? I could
do this while committing (which I was about to).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-21 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 8:23 [Xen-devel] [PATCH v2] viridian: unify time sources Paul Durrant
2019-06-20 8:44 ` Paul Durrant
2019-06-21 13:49 ` Alexandru Stefan ISAILA
2019-06-21 13:58 ` Paul Durrant
2019-06-21 15:20 ` Jan Beulich [this message]
2019-06-21 15:21 ` Paul Durrant
2019-06-21 15:08 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D0CF5BE020000780023A3C7@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).