* [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through
@ 2019-04-15 21:11 Gustavo A. R. Silva
2019-04-16 7:17 ` Juergen Gross
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-15 21:11 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini, David S. Miller
Cc: xen-devel, Gustavo A. R. Silva, linux-kernel, Kees Cook, netdev
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/xen-netfront.c: In function ‘netback_changed’:
drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->state == XenbusStateClosed)
^
drivers/net/xen-netfront.c:2041:2: note: here
case XenbusStateClosing:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 80c30321de41..8d33970a2950 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2037,7 +2037,7 @@ static void netback_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* Fall through - Missed the backend's CLOSING state. */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
@ 2019-04-16 7:17 ` Juergen Gross
2019-04-16 7:17 ` [Xen-devel] " Juergen Gross
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Juergen Gross @ 2019-04-16 7:17 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky, Stefano Stabellini,
David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
2019-04-16 7:17 ` Juergen Gross
@ 2019-04-16 7:17 ` Juergen Gross
2019-04-16 14:52 ` Gustavo A. R. Silva
2019-04-16 14:52 ` Gustavo A. R. Silva
2019-04-17 4:03 ` David Miller
` (3 subsequent siblings)
5 siblings, 2 replies; 10+ messages in thread
From: Juergen Gross @ 2019-04-16 7:17 UTC (permalink / raw)
To: Gustavo A. R. Silva, Boris Ostrovsky, Stefano Stabellini,
David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-16 7:17 ` [Xen-devel] " Juergen Gross
2019-04-16 14:52 ` Gustavo A. R. Silva
@ 2019-04-16 14:52 ` Gustavo A. R. Silva
1 sibling, 0 replies; 10+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-16 14:52 UTC (permalink / raw)
To: Juergen Gross, Boris Ostrovsky, Stefano Stabellini, David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 4/16/19 2:17 AM, Juergen Gross wrote:
> On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/xen-netfront.c: In function ‘netback_changed’:
>> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/net/xen-netfront.c:2041:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Thanks, Juergen.
--
Gustavo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-16 7:17 ` [Xen-devel] " Juergen Gross
@ 2019-04-16 14:52 ` Gustavo A. R. Silva
2019-04-16 14:52 ` Gustavo A. R. Silva
1 sibling, 0 replies; 10+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-16 14:52 UTC (permalink / raw)
To: Juergen Gross, Boris Ostrovsky, Stefano Stabellini, David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 4/16/19 2:17 AM, Juergen Gross wrote:
> On 15/04/2019 23:11, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/xen-netfront.c: In function ‘netback_changed’:
>> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/net/xen-netfront.c:2041:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Thanks, Juergen.
--
Gustavo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
2019-04-16 7:17 ` Juergen Gross
2019-04-16 7:17 ` [Xen-devel] " Juergen Gross
@ 2019-04-17 4:03 ` David Miller
2019-04-17 4:03 ` [Xen-devel] " David Miller
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2019-04-17 4:03 UTC (permalink / raw)
To: gustavo
Cc: jgross, sstabellini, keescook, netdev, linux-kernel, xen-devel,
boris.ostrovsky
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 15 Apr 2019 16:11:41 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
` (2 preceding siblings ...)
2019-04-17 4:03 ` David Miller
@ 2019-04-17 4:03 ` David Miller
2019-04-24 18:49 ` Boris Ostrovsky
2019-04-24 18:49 ` Boris Ostrovsky
5 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2019-04-17 4:03 UTC (permalink / raw)
To: gustavo
Cc: jgross, sstabellini, keescook, netdev, linux-kernel, xen-devel,
boris.ostrovsky
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 15 Apr 2019 16:11:41 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
` (4 preceding siblings ...)
2019-04-24 18:49 ` Boris Ostrovsky
@ 2019-04-24 18:49 ` Boris Ostrovsky
5 siblings, 0 replies; 10+ messages in thread
From: Boris Ostrovsky @ 2019-04-24 18:49 UTC (permalink / raw)
To: Gustavo A. R. Silva, Juergen Gross, Stefano Stabellini, David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 4/15/19 5:11 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-linus-5.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
` (3 preceding siblings ...)
2019-04-17 4:03 ` [Xen-devel] " David Miller
@ 2019-04-24 18:49 ` Boris Ostrovsky
2019-04-24 18:49 ` Boris Ostrovsky
5 siblings, 0 replies; 10+ messages in thread
From: Boris Ostrovsky @ 2019-04-24 18:49 UTC (permalink / raw)
To: Gustavo A. R. Silva, Juergen Gross, Stefano Stabellini, David S. Miller
Cc: xen-devel, linux-kernel, Kees Cook, netdev
On 4/15/19 5:11 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/net/xen-netfront.c: In function ‘netback_changed’:
> drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/net/xen-netfront.c:2041:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied to for-linus-5.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH net-next] xen-netfront: mark expected switch fall-through
@ 2019-04-15 21:11 Gustavo A. R. Silva
0 siblings, 0 replies; 10+ messages in thread
From: Gustavo A. R. Silva @ 2019-04-15 21:11 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross, Stefano Stabellini, David S. Miller
Cc: xen-devel, Gustavo A. R. Silva, linux-kernel, Kees Cook, netdev
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/net/xen-netfront.c: In function ‘netback_changed’:
drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->state == XenbusStateClosed)
^
drivers/net/xen-netfront.c:2041:2: note: here
case XenbusStateClosing:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/xen-netfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 80c30321de41..8d33970a2950 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2037,7 +2037,7 @@ static void netback_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* Fall through - Missed the backend's CLOSING state. */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-04-24 18:50 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-15 21:11 [Xen-devel] [PATCH net-next] xen-netfront: mark expected switch fall-through Gustavo A. R. Silva
2019-04-16 7:17 ` Juergen Gross
2019-04-16 7:17 ` [Xen-devel] " Juergen Gross
2019-04-16 14:52 ` Gustavo A. R. Silva
2019-04-16 14:52 ` Gustavo A. R. Silva
2019-04-17 4:03 ` David Miller
2019-04-17 4:03 ` [Xen-devel] " David Miller
2019-04-24 18:49 ` Boris Ostrovsky
2019-04-24 18:49 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2019-04-15 21:11 Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).