From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "julien@xen.org" <julien@xen.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
Oleksandr Tyshchenko <Oleksandr_Tyshchenko@epam.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Artem Mygaiev <Artem_Mygaiev@epam.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>,
"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
"paul@xen.org" <paul@xen.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Rahul Singh <rahul.singh@arm.com>,
Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
Subject: Re: [PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain
Date: Tue, 9 Nov 2021 09:20:08 +0000 [thread overview]
Message-ID: <6a8febab-1bd7-7896-e1da-b021513293ac@epam.com> (raw)
In-Reply-To: <20211105063326.939843-4-andr2000@gmail.com>
On 05.11.21 08:33, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> [snip]
> +int pci_host_iterate_bridges(struct domain *d,
> + int (*cb)(struct domain *d,
> + struct pci_host_bridge *bridge))
> +{
> + struct pci_host_bridge *bridge;
> + int err;
> +
> + list_for_each_entry( bridge, &pci_host_bridges, node )
> + {
> + err = cb(d, bridge);
> + if ( err )
> + return err;
> + }
> + return 0;
> +}
> +
> +unsigned int pci_host_get_num_bridges(void)
> +{
> + struct pci_host_bridge *bridge;
> + unsigned int count = 0;
> +
> + list_for_each_entry( bridge, &pci_host_bridges, node )
> + count++;
> +
> + return count;
> +}
> +
>
This can be even simpler if pci_host_iterate_bridges returns the count:
-int pci_host_iterate_bridges(struct domain *d,
- int (*cb)(struct domain *d,
- struct pci_host_bridge *bridge))
+int pci_host_iterate_bridges_and_count(struct domain *d,
+ int (*cb)(struct domain *d,
+ struct pci_host_bridge *bridge))
{
struct pci_host_bridge *bridge;
- int err;
+ int err, count = 0;
list_for_each_entry( bridge, &pci_host_bridges, node )
{
err = cb(d, bridge);
if ( err )
return err;
+ count += err;
}
- return 0;
-}
Then pci_host_get_num_bridges goes away and we can count
different entities with the same iterator and a simple callback.
This becomes possible as there is a single user for pci_host_iterate_bridges
now which sets up MMIOs, so the change above seems to be reasonable
I will include this change in v7
Thank you,
Oleksandr
next prev parent reply other threads:[~2021-11-09 9:20 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 6:33 [PATCH v6 0/7] PCI devices passthrough on Arm, part 2 Oleksandr Andrushchenko
2021-11-05 6:33 ` [PATCH v6 1/7] xen/arm: rename DEVICE_PCI to DEVICE_PCI_HOSTBRIDGE Oleksandr Andrushchenko
2021-11-16 18:26 ` Julien Grall
2021-11-05 6:33 ` [PATCH v6 2/7] xen/arm: add pci-domain for disabled devices Oleksandr Andrushchenko
2021-11-16 18:48 ` Julien Grall
2021-11-17 6:56 ` Oleksandr Andrushchenko
2021-11-17 21:33 ` Julien Grall
2021-11-18 7:13 ` Oleksandr Andrushchenko
2021-11-22 15:29 ` Julien Grall
2021-11-22 16:23 ` Oleksandr Andrushchenko
2021-11-22 17:17 ` Julien Grall
2021-11-23 6:31 ` Oleksandr Andrushchenko
2021-11-23 16:05 ` Julien Grall
2021-11-23 16:44 ` Oleksandr Andrushchenko
2021-11-23 17:15 ` Julien Grall
2021-11-24 6:54 ` Oleksandr Andrushchenko
2021-11-05 6:33 ` [PATCH v6 3/7] xen/arm: setup MMIO range trap handlers for hardware domain Oleksandr Andrushchenko
2021-11-09 9:20 ` Oleksandr Andrushchenko [this message]
2021-11-16 19:12 ` Julien Grall
2021-11-18 7:27 ` Oleksandr Andrushchenko
2021-11-18 10:46 ` Oleksandr Andrushchenko
2021-11-22 17:36 ` Julien Grall
2021-11-23 6:58 ` Oleksandr Andrushchenko
2021-11-23 16:12 ` Julien Grall
2021-11-23 16:41 ` Oleksandr Andrushchenko
2021-11-23 16:58 ` Julien Grall
2021-11-24 7:22 ` Oleksandr Andrushchenko
2021-11-05 6:33 ` [PATCH v6 4/7] xen/arm: do not map PCI ECAM and MMIO space to Domain-0's p2m Oleksandr Andrushchenko
2021-11-23 16:42 ` Julien Grall
2021-11-24 7:42 ` Oleksandr Andrushchenko
2021-11-05 6:33 ` [PATCH v6 5/7] xen/arm: do not map IRQs and memory for disabled devices Oleksandr Andrushchenko
2021-11-16 19:22 ` Julien Grall
2021-11-18 6:59 ` Oleksandr Andrushchenko
2021-11-22 19:31 ` Julien Grall
2021-11-23 7:23 ` Oleksandr Andrushchenko
2021-11-05 6:33 ` [PATCH v6 6/7] xen/arm: process pending vPCI map/unmap operations Oleksandr Andrushchenko
2021-11-05 7:40 ` Jan Beulich
2021-11-17 21:26 ` Julien Grall
2021-11-05 6:33 ` [PATCH v6 7/7] xen/arm: do not use void pointer in pci_host_common_probe Oleksandr Andrushchenko
2021-11-17 11:12 ` Rahul Singh
2021-11-17 21:45 ` Julien Grall
2021-11-18 7:34 ` Oleksandr Andrushchenko
2021-11-22 17:48 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a8febab-1bd7-7896-e1da-b021513293ac@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=Artem_Mygaiev@epam.com \
--cc=Oleksandr_Tyshchenko@epam.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=paul@xen.org \
--cc=rahul.singh@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).