From: Doug Goldstein <cardoe@cardoe.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [RFC PATCH 1/7] build: add debug menu to Kconfig
Date: Mon, 2 May 2016 09:35:55 -0500 [thread overview]
Message-ID: <6f8cde38-17fa-73c5-3fca-da79ff0a54f7@cardoe.com> (raw)
In-Reply-To: <965e7326-25d1-2c1a-af2d-a85b3af9b1c3@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 2460 bytes --]
On 5/2/16 6:02 AM, Andrew Cooper wrote:
> On 02/05/2016 11:42, Wei Liu wrote:
>> On Sun, May 01, 2016 at 11:10:40PM -0500, Doug Goldstein wrote:
>>> There are a number of debugging options for Xen so the idea is to have a
>>> menu to group them all together. Enabling this menu item will also
>>> disable NDEBUG which will result in more debug prints. This was
>>> previously wired into the 'debug=y' command line option.
>>>
>>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>>> ---
>>> CC: Andrew Cooper <andrew.cooper3@citrix.com>
>>> CC: George Dunlap <George.Dunlap@eu.citrix.com>
>>> CC: Ian Jackson <ian.jackson@eu.citrix.com>
>>> CC: Jan Beulich <jbeulich@suse.com>
>>> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>>> CC: Stefano Stabellini <sstabellini@kernel.org>
>>> CC: Tim Deegan <tim@xen.org>
>>> CC: Wei Liu <wei.liu2@citrix.com>
>>> ---
>>> xen/Kconfig | 2 ++
>>> xen/Kconfig.debug | 7 +++++++
>>> xen/include/xen/config.h | 4 ++++
>>> 3 files changed, 13 insertions(+)
>>> create mode 100644 xen/Kconfig.debug
>>>
>>> diff --git a/xen/Kconfig b/xen/Kconfig
>>> index fa8b27c..0fe7a1a 100644
>>> --- a/xen/Kconfig
>>> +++ b/xen/Kconfig
>>> @@ -26,3 +26,5 @@ config DEFCONFIG_LIST
>>> config EXPERT
>>> string
>>> option env="XEN_CONFIG_EXPERT"
>>> +
>>> +source "Kconfig.debug"
>>> diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
>>> new file mode 100644
>>> index 0000000..d14d758
>>> --- /dev/null
>>> +++ b/xen/Kconfig.debug
>>> @@ -0,0 +1,7 @@
>>> +
>>> +menuconfig DEBUG
>>> + bool "Debugging Options"
>>> + ---help---
>>> + If you want to debug Xen say Y and select any additional debugging
>>> + support options. This enables additional debugging through Xen
>>> + and as a result enabling this option results in no security guarantees.
>> Maybe that's because I'm not a native speaker, this doesn't sound right
>> to me -- it implies debugging option makes xen insecure.
>>
>> I think you mean "results in no security support"?
>
> Instead of mentioning security, I would simply say "Enabling this option
> is intended for development purposes only, and not for production use".
>
> There is already a statement saying that issues which only affect a
> debug hypervisor are not considered security relevant.
>
> ~Andrew
>
Yeah that's better wording than what I've got. I'll update it. Thanks!
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-02 14:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 4:10 [RFC PATCH 0/7] Kconfig debug options Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 1/7] build: add debug menu to Kconfig Doug Goldstein
2016-05-02 10:42 ` Wei Liu
2016-05-02 11:02 ` Andrew Cooper
2016-05-02 14:35 ` Doug Goldstein [this message]
2016-05-02 4:10 ` [RFC PATCH 2/7] build: convert crash_debug " Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 3/7] build: convert verbose " Doug Goldstein
2016-05-02 15:18 ` Konrad Rzeszutek Wilk
2016-05-03 13:47 ` Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 4/7] build: convert frame_pointer " Doug Goldstein
2016-05-02 15:25 ` Konrad Rzeszutek Wilk
2016-05-02 15:56 ` Jan Beulich
2016-05-02 4:10 ` [RFC PATCH 5/7] build: wire up pre-existing debug build flag Doug Goldstein
2016-05-02 16:04 ` Konrad Rzeszutek Wilk
2016-05-02 4:10 ` [RFC PATCH 6/7] build: convert perfc{, _arrays} to Kconfig Doug Goldstein
2016-05-02 4:10 ` [RFC PATCH 7/7] build: convert lock_profile " Doug Goldstein
2016-05-02 16:08 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8cde38-17fa-73c5-3fca-da79ff0a54f7@cardoe.com \
--to=cardoe@cardoe.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).