From: Jan Beulich <JBeulich@suse.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>,
Igor Druzhinin <igor.druzhinin@citrix.com>
Subject: Re: [Xen-devel] [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices
Date: Mon, 5 Aug 2019 15:51:55 +0000 [thread overview]
Message-ID: <70a89b64-a3c1-1fe7-1b15-6f6fee98c92a@suse.com> (raw)
In-Reply-To: <23880.16947.795708.667141@mariner.uk.xensource.com>
On 05.08.2019 16:50, Ian Jackson wrote:
> Jan Beulich writes ("Re: [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices"):
>>>>> On 23.05.19 at 17:20, <wei.liu2@citrix.com> wrote:
>>> On Thu, May 23, 2019 at 02:57:49AM -0600, Jan Beulich wrote:
>>>>>>> On 22.05.19 at 20:10, <igor.druzhinin@citrix.com> wrote:
>>>>> DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method
>>>>> doesn't exist then the slot is assumed to be always present and active
>>>>> which in conjunction with _EJ0 method makes every device ejectable for
>>>>> an OS even if it's not the case.
>>>>>
>>>>> qemu-kvm is able to dynamically add _EJ0 method only to those slots
>>>>> that either have hotpluggable devices or free for PCI passthrough.
>>>>> As Xen lacks this capability we cannot use their way.
>>>>>
>>>>> qemu-xen-traditional DSDT has _STA method which only reports that
>>>>> the slot is present if there is a PCI devices hotplugged there.
>>>>> This is done through querying of its PCI hotplug controller.
>>>>> qemu-xen has similar capability that reports if device is "hotpluggable
>>>>> or absent" which we can use to achieve the same result.
>>>>>
>>>>> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
>>>>
>>>> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>>>>
>>>
>>> Jan, FAOD since you're the maintainer I'm expecting you to push this
>>> patch yourself.
>>
>> Sure, I have it on my list of things to push.
>
> Is this a backport candidate ? It sounds like it might be a bugfix
> but I don't understand the risks/implications.
I did already take the liberty of backporting this (back in June).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-08-05 15:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 18:10 [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices Igor Druzhinin
2019-05-22 18:10 ` [Xen-devel] " Igor Druzhinin
2019-05-23 8:57 ` Jan Beulich
2019-05-23 8:57 ` [Xen-devel] " Jan Beulich
2019-05-23 15:20 ` Wei Liu
2019-05-23 15:20 ` [Xen-devel] " Wei Liu
2019-05-23 15:30 ` Jan Beulich
2019-05-23 15:30 ` [Xen-devel] " Jan Beulich
2019-08-05 14:50 ` Ian Jackson
2019-08-05 15:51 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70a89b64-a3c1-1fe7-1b15-6f6fee98c92a@suse.com \
--to=jbeulich@suse.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=ian.jackson@citrix.com \
--cc=igor.druzhinin@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).