xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices
Date: Thu, 23 May 2019 02:57:49 -0600	[thread overview]
Message-ID: <5CE6608D02000078002319C3@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1558548634-25154-1-git-send-email-igor.druzhinin@citrix.com>

>>> On 22.05.19 at 20:10, <igor.druzhinin@citrix.com> wrote:
> DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method
> doesn't exist then the slot is assumed to be always present and active
> which in conjunction with _EJ0 method makes every device ejectable for
> an OS even if it's not the case.
> 
> qemu-kvm is able to dynamically add _EJ0 method only to those slots
> that either have hotpluggable devices or free for PCI passthrough.
> As Xen lacks this capability we cannot use their way.
> 
> qemu-xen-traditional DSDT has _STA method which only reports that
> the slot is present if there is a PCI devices hotplugged there.
> This is done through querying of its PCI hotplug controller.
> qemu-xen has similar capability that reports if device is "hotpluggable
> or absent" which we can use to achieve the same result.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Jan Beulich" <JBeulich@suse.com>
To: "Igor Druzhinin" <igor.druzhinin@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices
Date: Thu, 23 May 2019 02:57:49 -0600	[thread overview]
Message-ID: <5CE6608D02000078002319C3@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190523085749.1qJyT2sczZeOkYJL5_nGtWv92cwAFIUMZErdNsLXbPM@z> (raw)
In-Reply-To: <1558548634-25154-1-git-send-email-igor.druzhinin@citrix.com>

>>> On 22.05.19 at 20:10, <igor.druzhinin@citrix.com> wrote:
> DSDT for qemu-xen lacks _STA method of PCI slot object. If _STA method
> doesn't exist then the slot is assumed to be always present and active
> which in conjunction with _EJ0 method makes every device ejectable for
> an OS even if it's not the case.
> 
> qemu-kvm is able to dynamically add _EJ0 method only to those slots
> that either have hotpluggable devices or free for PCI passthrough.
> As Xen lacks this capability we cannot use their way.
> 
> qemu-xen-traditional DSDT has _STA method which only reports that
> the slot is present if there is a PCI devices hotplugged there.
> This is done through querying of its PCI hotplug controller.
> qemu-xen has similar capability that reports if device is "hotpluggable
> or absent" which we can use to achieve the same result.
> 
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-23  8:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-22 18:10 [PATCH] libacpi: report PCI slots as enabled only for hotpluggable devices Igor Druzhinin
2019-05-22 18:10 ` [Xen-devel] " Igor Druzhinin
2019-05-23  8:57 ` Jan Beulich [this message]
2019-05-23  8:57   ` Jan Beulich
2019-05-23 15:20   ` Wei Liu
2019-05-23 15:20     ` [Xen-devel] " Wei Liu
2019-05-23 15:30     ` Jan Beulich
2019-05-23 15:30       ` [Xen-devel] " Jan Beulich
2019-08-05 14:50       ` Ian Jackson
2019-08-05 15:51         ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5CE6608D02000078002319C3@prv1-mh.provo.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=igor.druzhinin@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).