From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Jan Beulich" <jbeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH 1/4] x86: replace __ASM_{CL,ST}AC
Date: Tue, 28 Jul 2020 14:59:08 +0100 [thread overview]
Message-ID: <868f864b-ae8e-0b01-8cf0-74a0fd3982ee@citrix.com> (raw)
In-Reply-To: <b29e4b17-8ec2-a0db-8426-94393e9eb2c0@suse.com>
On 27/07/2020 20:47, Jan Beulich wrote:
> On 27.07.2020 16:55, Roger Pau Monné wrote:
>> On Wed, Jul 15, 2020 at 12:48:14PM +0200, Jan Beulich wrote:
>>> --- /dev/null
>>> +++ b/xen/include/asm-x86/asm-defns.h
>>
>> Maybe this could be asm-insn.h or a different name? I find it
>> confusing to have asm-defns.h and an asm_defs.h.
>
> While indeed I anticipated a reply to this effect, I don't consider
> asm-insn.h or asm-macros.h suitable: We don't want to limit this
> header to a more narrow purpose than "all sorts of definition", I
> don't think. Hence I chose that name despite its similarity to the
> C header's one.
Roger is correct. Having asm-defns.h and asm_defs.h is too confusing,
and there is already too much behind the scenes magic here.
What is the anticipated end result, file wise, because that might
highlight a better way forward.
~Andrew
next prev parent reply other threads:[~2020-07-28 13:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 10:47 [PATCH 0/4] x86: some assembler macro rework Jan Beulich
2020-07-15 10:48 ` [PATCH 1/4] x86: replace __ASM_{CL,ST}AC Jan Beulich
2020-07-27 14:55 ` Roger Pau Monné
2020-07-27 19:47 ` Jan Beulich
2020-07-28 9:06 ` Roger Pau Monné
2020-07-31 8:05 ` Jan Beulich
2020-07-31 8:12 ` Roger Pau Monné
2020-07-28 13:59 ` Andrew Cooper [this message]
2020-07-28 19:24 ` Jan Beulich
2020-07-28 13:55 ` Andrew Cooper
2020-07-28 19:18 ` Jan Beulich
2020-07-31 8:00 ` Jan Beulich
2020-07-15 10:48 ` [PATCH 2/4] x86: reduce CET-SS related #ifdef-ary Jan Beulich
2020-07-27 15:00 ` Roger Pau Monné
2020-07-27 19:50 ` Jan Beulich
2020-07-28 8:36 ` Roger Pau Monné
2020-07-28 14:29 ` Andrew Cooper
2020-07-28 19:33 ` Jan Beulich
2020-07-15 10:49 ` [PATCH 3/4] x86: drop ASM_{CL,ST}AC Jan Beulich
2020-07-27 15:10 ` Roger Pau Monné
2020-07-28 14:51 ` Andrew Cooper
2020-07-28 19:41 ` Jan Beulich
2020-07-15 10:49 ` [PATCH 4/4] x86: fold indirect_thunk_asm.h into asm-defns.h Jan Beulich
2020-07-27 15:16 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868f864b-ae8e-0b01-8cf0-74a0fd3982ee@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).