xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dfaggioli@suse.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Doug Goldstein <cardoe@cardoe.com>,
	 Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] automation: fix dependencies on openSUSE Tumbleweed containers
Date: Tue, 18 May 2021 16:33:43 +0200	[thread overview]
Message-ID: <9160502180e3c36a52cb841520615bc7fe91b42b.camel@suse.com> (raw)
In-Reply-To: <YKO/BcUAtjSgc2pV@Air-de-Roger>

[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]

On Tue, 2021-05-18 at 15:20 +0200, Roger Pau Monné wrote:
> On Tue, May 18, 2021 at 02:04:13PM +0200, Dario Faggioli wrote:
> > From: Dario Faggioli <dario@Solace.fritz.box>
> > 
Mmm... this email address does not really exist, and it's a mistake
that it ended up here. :-/

> > Fix the build inside our openSUSE Tumbleweed container by using
> > the proper python development packages (and adding zstd headers).
> > 
> > Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> > ---
> > Cc: Doug Goldstein <cardoe@cardoe.com>
> > Cc: Roger Pau Monne <roger.pau@citrix.com>
> > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> >  .../build/suse/opensuse-tumbleweed.dockerfile      |    5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > index 8ff7b9b5ce..5b99cb8a53 100644
> > --- a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > 
> > @@ -56,10 +57,8 @@ RUN zypper install -y --no-recommends \
> >          pandoc \
> >          patch \
> >          pkg-config \
> > -        python \
> >          python-devel \
> > -        python3 \
> > -        python3-devel \
> > +        python38-devel \
> 
> When I tested python3-devel was translated into python38-devel, 
>
Oh, really? And when was it that you tested it, if I can ask?

> which
> I think is better as we don't need to modify the docker file for
> every
> new Python version?
> 
That would definitely be better. Right now, I don't see any
python3-devel package. If python3-devel can still be used (and it
somehow translates to the proper -devel package), then sure we should
use it. I'm not sure how that would happen, but maybe it's just me
being unaware of some packaging magic.

Let me put "python3-devel" there and test locally again, so we know if
it actually works.

Thanks and Regards
-- 
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-05-18 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 12:04 [PATCH 0/2] automation: fix building in the openSUSE Tumbleweed Dario Faggioli
2021-05-18 12:04 ` [PATCH 1/2] automation: use DOCKER_CMD for building containers too Dario Faggioli
2021-05-18 14:26   ` Roger Pau Monné
2021-05-18 14:35     ` Dario Faggioli
2021-05-18 12:04 ` [PATCH 2/2] automation: fix dependencies on openSUSE Tumbleweed containers Dario Faggioli
2021-05-18 13:20   ` Roger Pau Monné
2021-05-18 14:33     ` Dario Faggioli [this message]
2021-05-18 15:09       ` Roger Pau Monné
2021-05-18 15:30       ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9160502180e3c36a52cb841520615bc7fe91b42b.camel@suse.com \
    --to=dfaggioli@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).