xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Dario Faggioli <dfaggioli@suse.com>
Cc: <xen-devel@lists.xenproject.org>,
	Doug Goldstein <cardoe@cardoe.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/2] automation: fix dependencies on openSUSE Tumbleweed containers
Date: Tue, 18 May 2021 17:09:22 +0200	[thread overview]
Message-ID: <YKPYoq2p6a0avevB@Air-de-Roger> (raw)
In-Reply-To: <9160502180e3c36a52cb841520615bc7fe91b42b.camel@suse.com>

On Tue, May 18, 2021 at 04:33:43PM +0200, Dario Faggioli wrote:
> On Tue, 2021-05-18 at 15:20 +0200, Roger Pau Monné wrote:
> > On Tue, May 18, 2021 at 02:04:13PM +0200, Dario Faggioli wrote:
> > > From: Dario Faggioli <dario@Solace.fritz.box>
> > > 
> Mmm... this email address does not really exist, and it's a mistake
> that it ended up here. :-/
> 
> > > Fix the build inside our openSUSE Tumbleweed container by using
> > > the proper python development packages (and adding zstd headers).
> > > 
> > > Signed-off-by: Dario Faggioli <dfaggioli@suse.com>
> > > ---
> > > Cc: Doug Goldstein <cardoe@cardoe.com>
> > > Cc: Roger Pau Monne <roger.pau@citrix.com>
> > > Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> > > ---
> > >  .../build/suse/opensuse-tumbleweed.dockerfile      |    5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > index 8ff7b9b5ce..5b99cb8a53 100644
> > > --- a/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile
> > > 
> > > @@ -56,10 +57,8 @@ RUN zypper install -y --no-recommends \
> > >          pandoc \
> > >          patch \
> > >          pkg-config \
> > > -        python \
> > >          python-devel \
> > > -        python3 \
> > > -        python3-devel \
> > > +        python38-devel \
> > 
> > When I tested python3-devel was translated into python38-devel, 
> >
> Oh, really? And when was it that you tested it, if I can ask?

I've tried just now with the current docker file, and this is the
(trimmed) output:

Step 7/7 : RUN zypper install -y --no-recommends         acpica         bc         bin86         bison         bzip2         checkpolicy         clang         cmake         dev86         discount         flex         gcc         gcc-c++         gettext-tools         git         glib2-devel         glibc-devel         glibc-devel-32bit         gzip         hostname         libSDL2-devel         libaio-devel         libbz2-devel         libext2fs-devel         libgnutls-devel         libjpeg62-devel         libnl3-devel         libnuma-devel         libpixman-1-0-devel         libpng16-devel         libssh2-devel         libtasn1-devel         libuuid-devel         libyajl-devel         lzo-devel         make         nasm         ncurses-devel         ocaml         ocaml-findlib-devel         ocaml-ocamlbuild         ocaml-ocamldoc         pandoc         patch         pkg-config         python         python-devel         python3         python3-devel         systemd-devel         tar         transfig         valgrind-devel         wget         which         xz-devel         zlib-devel         &&         zypper clean -a
 ---> Running in af6a184e482b
Retrieving repository 'openSUSE-Tumbleweed-Non-Oss' metadata [..done]
Building repository 'openSUSE-Tumbleweed-Non-Oss' cache [....done]
Retrieving repository 'openSUSE-Tumbleweed-Oss' metadata [.......done]
Building repository 'openSUSE-Tumbleweed-Oss' cache [....done]
Retrieving repository 'openSUSE-Tumbleweed-Update' metadata [.done]
Building repository 'openSUSE-Tumbleweed-Update' cache [....done]
Loading repository data...
Reading installed packages...
'python3' not found in package names. Trying capabilities.
'python3-devel' not found in package names. Trying capabilities.

There's this message here ...

'pkg-config' not found in package names. Trying capabilities.
Resolving package dependencies...

The following 509 NEW packages are going to be installed:
[...] python38 python38-base python38-devel [...]

... but it seems python3-devel gets translated into python38-devel, or
maybe something else selects python38-devel?

Not familiar with the system, so maybe it's indeed a dependency of
some other package.

> > which
> > I think is better as we don't need to modify the docker file for
> > every
> > new Python version?
> > 
> That would definitely be better. Right now, I don't see any
> python3-devel package. If python3-devel can still be used (and it
> somehow translates to the proper -devel package), then sure we should
> use it. I'm not sure how that would happen, but maybe it's just me
> being unaware of some packaging magic.
> 
> Let me put "python3-devel" there and test locally again, so we know if
> it actually works.

It does seem to be picked up, whether that's because python3-devel
gets translated into python38-devel, or something else pulls it in
I don't certainly know.

Thanks, Roger.


  reply	other threads:[~2021-05-18 15:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18 12:04 [PATCH 0/2] automation: fix building in the openSUSE Tumbleweed Dario Faggioli
2021-05-18 12:04 ` [PATCH 1/2] automation: use DOCKER_CMD for building containers too Dario Faggioli
2021-05-18 14:26   ` Roger Pau Monné
2021-05-18 14:35     ` Dario Faggioli
2021-05-18 12:04 ` [PATCH 2/2] automation: fix dependencies on openSUSE Tumbleweed containers Dario Faggioli
2021-05-18 13:20   ` Roger Pau Monné
2021-05-18 14:33     ` Dario Faggioli
2021-05-18 15:09       ` Roger Pau Monné [this message]
2021-05-18 15:30       ` Dario Faggioli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKPYoq2p6a0avevB@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=dfaggioli@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).