From: "Xu, Quan" <quan.xu@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v13 1/3] IOMMU/x86: use a struct pci_dev* instead of SBDF
Date: Mon, 4 Jul 2016 05:41:46 +0000 [thread overview]
Message-ID: <945CA011AD5F084CBEA3E851C0AB28894B8F9231@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D15F8E75B7@SHSMSX101.ccr.corp.intel.com>
On July 04, 2016 1:35 PM, Tian, Kevin <kevin.tian@intel.com> wrote:
> > From: Xu, Quan
> > Sent: Wednesday, June 29, 2016 2:00 PM
> >
> > From: Quan Xu <quan.xu@intel.com>
> >
> > A struct pci_dev* instead of SBDF is stored inside struct pci_ats_dev
> > and parameter to *_ats_device().
> >
> > Also use ats_dev for "struct pci_ats_dev" variable, while pdev (_pdev,
> > if there is already a pdev) for "struct pci_dev"
> > in the scope of IOMMU.
> >
> > Signed-off-by: Quan Xu <quan.xu@intel.com>
> >
> > CC: Jan Beulich <jbeulich@suse.com>
> > CC: Kevin Tian <kevin.tian@intel.com>
> > CC: Feng Wu <feng.wu@intel.com>
> > CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> >
>
> Acked-by: Kevin Tian <kevin.tian@intel.com>, with one minor comment:
>
> > diff --git a/xen/drivers/passthrough/amd/iommu_cmd.c
> > b/xen/drivers/passthrough/amd/iommu_cmd.c
> > index 7c9d9be..934977a 100644
> > --- a/xen/drivers/passthrough/amd/iommu_cmd.c
> > +++ b/xen/drivers/passthrough/amd/iommu_cmd.c
> > @@ -294,28 +294,27 @@ void amd_iommu_flush_iotlb(u8 devfn, const
> > struct pci_dev *pdev,
> > if ( !ats_enabled )
> > return;
> >
> > - ats_pdev = get_ats_device(pdev->seg, pdev->bus, pdev->devfn);
> > + ats_pdev = get_ats_device(pdev);
> > if ( ats_pdev == NULL )
> > return;
> >
>
> To align with other places, better to change ats_pdev to ats_dev too.
Indeed, thanks very much!!
I will update it soon.
- Quan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-04 5:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 5:59 [PATCH v13 0/3] VT-d Device-TLB flush issue Xu, Quan
2016-06-29 5:59 ` [PATCH v13 1/3] IOMMU/x86: use a struct pci_dev* instead of SBDF Xu, Quan
2016-07-04 5:35 ` Tian, Kevin
2016-07-04 5:41 ` Xu, Quan [this message]
2016-06-29 5:59 ` [PATCH v13 2/3] IOMMU: add domain crash logic Xu, Quan
2016-07-04 5:36 ` Tian, Kevin
2016-06-29 5:59 ` [PATCH v13 3/3] IOMMU: fix vt-d Device-TLB flush timeout issue Xu, Quan
2016-07-04 6:16 ` Tian, Kevin
2016-07-04 6:45 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=945CA011AD5F084CBEA3E851C0AB28894B8F9231@SHSMSX101.ccr.corp.intel.com \
--to=quan.xu@intel.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).