From: "Tian, Kevin" <kevin.tian@intel.com>
To: "Xu, Quan" <quan.xu@intel.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: "dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"Wu, Feng" <feng.wu@intel.com>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v13 3/3] IOMMU: fix vt-d Device-TLB flush timeout issue
Date: Mon, 4 Jul 2016 06:16:16 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F8E766F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1467179974-57317-4-git-send-email-quan.xu@intel.com>
> From: Xu, Quan
> Sent: Wednesday, June 29, 2016 2:00 PM
>
> From: Quan Xu <quan.xu@intel.com>
>
> If Device-TLB flush timed out, we hide the target ATS device
> immediately. By hiding the device, we make sure it can't be
> assigned to any domain any longer (see device_assigned).
>
> Signed-off-by: Quan Xu <quan.xu@intel.com>
>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> CC: Feng Wu <feng.wu@intel.com>
>
> ---
> v13:
> 1. drop domain crash logic, which is added to the vendor
> independent layer in patch #2.
> 2. rename dev_invalidate_iotlb_timeout() to iommu_dev_iotlb_flush_timeout()
> and move it to the vendor independent layer.
> ---
> xen/drivers/passthrough/iommu.c | 21 +++++++++++++
> xen/drivers/passthrough/pci.c | 6 ++--
> xen/drivers/passthrough/vtd/extern.h | 5 ++--
> xen/drivers/passthrough/vtd/qinval.c | 56
> +++++++++++++++++++++++++++--------
> xen/drivers/passthrough/vtd/x86/ats.c | 11 ++-----
> xen/include/xen/iommu.h | 3 ++
> xen/include/xen/pci.h | 1 +
> 7 files changed, 76 insertions(+), 27 deletions(-)
>
> diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> index d793f5d..5db8ae6 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -361,6 +361,27 @@ int iommu_iotlb_flush_all(struct domain *d)
> return rc;
> }
>
> +void iommu_dev_iotlb_flush_timeout(struct domain *d,
> + struct pci_dev *pdev)
> +{
> + pcidevs_lock();
> +
> + ASSERT(pdev->domain);
> + if ( d != pdev->domain )
> + return;
return w/o releasing the lock!
and is above scenario actually possible (a flush timeout is captured when
the device doesn't belong to previous domain)? If not, better to move
the condition into ASSERT.
> +
> + list_del(&pdev->domain_list);
> + pdev->domain = NULL;
> + pci_hide_existing_device(pdev);
> + if ( !d->is_shutting_down && printk_ratelimit() )
> + printk(XENLOG_ERR
> + "dom%d: ATS device %04x:%02x:%02x.%u flush failed\n",
> + d->domain_id, pdev->seg, pdev->bus, PCI_SLOT(pdev->devfn),
> + PCI_FUNC(pdev->devfn));
> +
> + pcidevs_unlock();
please move above warning out of the lock.
Thanks
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-04 6:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 5:59 [PATCH v13 0/3] VT-d Device-TLB flush issue Xu, Quan
2016-06-29 5:59 ` [PATCH v13 1/3] IOMMU/x86: use a struct pci_dev* instead of SBDF Xu, Quan
2016-07-04 5:35 ` Tian, Kevin
2016-07-04 5:41 ` Xu, Quan
2016-06-29 5:59 ` [PATCH v13 2/3] IOMMU: add domain crash logic Xu, Quan
2016-07-04 5:36 ` Tian, Kevin
2016-06-29 5:59 ` [PATCH v13 3/3] IOMMU: fix vt-d Device-TLB flush timeout issue Xu, Quan
2016-07-04 6:16 ` Tian, Kevin [this message]
2016-07-04 6:45 ` Xu, Quan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D15F8E766F@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=dario.faggioli@citrix.com \
--cc=feng.wu@intel.com \
--cc=jbeulich@suse.com \
--cc=quan.xu@intel.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).