* [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks
@ 2019-09-27 15:49 Ross Lagerwall
2019-09-30 6:47 ` Jürgen Groß
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ross Lagerwall @ 2019-09-27 15:49 UTC (permalink / raw)
To: xen-devel
Cc: Juergen Gross, Stefano Stabellini, Russell King, Ross Lagerwall,
Ingo Molnar, Borislav Petkov, H. Peter Anvin, Boris Ostrovsky,
Thomas Gleixner
Other parts of the kernel expect these nonblocking EFI callbacks to
exist and crash when running under Xen. Since the implementations of
xen_efi_set_variable() and xen_efi_query_variable_info() do not take any
locks, use them for the nonblocking callbacks too.
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
---
arch/arm/xen/efi.c | 2 ++
arch/x86/xen/efi.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/arm/xen/efi.c b/arch/arm/xen/efi.c
index d687a73044bf..cb2aaf98e243 100644
--- a/arch/arm/xen/efi.c
+++ b/arch/arm/xen/efi.c
@@ -19,7 +19,9 @@ void __init xen_efi_runtime_setup(void)
efi.get_variable = xen_efi_get_variable;
efi.get_next_variable = xen_efi_get_next_variable;
efi.set_variable = xen_efi_set_variable;
+ efi.set_variable_nonblocking = xen_efi_set_variable;
efi.query_variable_info = xen_efi_query_variable_info;
+ efi.query_variable_info_nonblocking = xen_efi_query_variable_info;
efi.update_capsule = xen_efi_update_capsule;
efi.query_capsule_caps = xen_efi_query_capsule_caps;
efi.get_next_high_mono_count = xen_efi_get_next_high_mono_count;
diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c
index 0d3365cb64de..7e3eb70f411a 100644
--- a/arch/x86/xen/efi.c
+++ b/arch/x86/xen/efi.c
@@ -65,7 +65,9 @@ static efi_system_table_t __init *xen_efi_probe(void)
efi.get_variable = xen_efi_get_variable;
efi.get_next_variable = xen_efi_get_next_variable;
efi.set_variable = xen_efi_set_variable;
+ efi.set_variable_nonblocking = xen_efi_set_variable;
efi.query_variable_info = xen_efi_query_variable_info;
+ efi.query_variable_info_nonblocking = xen_efi_query_variable_info;
efi.update_capsule = xen_efi_update_capsule;
efi.query_capsule_caps = xen_efi_query_capsule_caps;
efi.get_next_high_mono_count = xen_efi_get_next_high_mono_count;
--
2.21.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks
2019-09-27 15:49 [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks Ross Lagerwall
@ 2019-09-30 6:47 ` Jürgen Groß
2019-10-01 7:38 ` Jürgen Groß
2019-10-01 17:57 ` Stefano Stabellini
2 siblings, 0 replies; 4+ messages in thread
From: Jürgen Groß @ 2019-09-30 6:47 UTC (permalink / raw)
To: Ross Lagerwall, xen-devel
Cc: Stefano Stabellini, Russell King, IngoMolnar, Borislav Petkov,
H. Peter Anvin, Boris Ostrovsky, Thomas Gleixner
On 27.09.19 17:49, Ross Lagerwall wrote:
> Other parts of the kernel expect these nonblocking EFI callbacks to
> exist and crash when running under Xen. Since the implementations of
> xen_efi_set_variable() and xen_efi_query_variable_info() do not take any
> locks, use them for the nonblocking callbacks too.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks
2019-09-27 15:49 [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks Ross Lagerwall
2019-09-30 6:47 ` Jürgen Groß
@ 2019-10-01 7:38 ` Jürgen Groß
2019-10-01 17:57 ` Stefano Stabellini
2 siblings, 0 replies; 4+ messages in thread
From: Jürgen Groß @ 2019-10-01 7:38 UTC (permalink / raw)
To: Ross Lagerwall, xen-devel
Cc: Stefano Stabellini, Russell King, IngoMolnar, Borislav Petkov,
H. Peter Anvin, Boris Ostrovsky, Thomas Gleixner
On 27.09.19 17:49, Ross Lagerwall wrote:
> Other parts of the kernel expect these nonblocking EFI callbacks to
> exist and crash when running under Xen. Since the implementations of
> xen_efi_set_variable() and xen_efi_query_variable_info() do not take any
> locks, use them for the nonblocking callbacks too.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Pushed to xen/tip.git for-linus-5.4
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks
2019-09-27 15:49 [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks Ross Lagerwall
2019-09-30 6:47 ` Jürgen Groß
2019-10-01 7:38 ` Jürgen Groß
@ 2019-10-01 17:57 ` Stefano Stabellini
2 siblings, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2019-10-01 17:57 UTC (permalink / raw)
To: Ross Lagerwall
Cc: Juergen Gross, Stefano Stabellini, Russell King, Ingo Molnar,
Borislav Petkov, H. Peter Anvin, xen-devel, Boris Ostrovsky,
Thomas Gleixner
On Fri, 27 Sep 2019, Ross Lagerwall wrote:
> Other parts of the kernel expect these nonblocking EFI callbacks to
> exist and crash when running under Xen. Since the implementations of
> xen_efi_set_variable() and xen_efi_query_variable_info() do not take any
> locks, use them for the nonblocking callbacks too.
>
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> arch/arm/xen/efi.c | 2 ++
> arch/x86/xen/efi.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/arm/xen/efi.c b/arch/arm/xen/efi.c
> index d687a73044bf..cb2aaf98e243 100644
> --- a/arch/arm/xen/efi.c
> +++ b/arch/arm/xen/efi.c
> @@ -19,7 +19,9 @@ void __init xen_efi_runtime_setup(void)
> efi.get_variable = xen_efi_get_variable;
> efi.get_next_variable = xen_efi_get_next_variable;
> efi.set_variable = xen_efi_set_variable;
> + efi.set_variable_nonblocking = xen_efi_set_variable;
> efi.query_variable_info = xen_efi_query_variable_info;
> + efi.query_variable_info_nonblocking = xen_efi_query_variable_info;
> efi.update_capsule = xen_efi_update_capsule;
> efi.query_capsule_caps = xen_efi_query_capsule_caps;
> efi.get_next_high_mono_count = xen_efi_get_next_high_mono_count;
> diff --git a/arch/x86/xen/efi.c b/arch/x86/xen/efi.c
> index 0d3365cb64de..7e3eb70f411a 100644
> --- a/arch/x86/xen/efi.c
> +++ b/arch/x86/xen/efi.c
> @@ -65,7 +65,9 @@ static efi_system_table_t __init *xen_efi_probe(void)
> efi.get_variable = xen_efi_get_variable;
> efi.get_next_variable = xen_efi_get_next_variable;
> efi.set_variable = xen_efi_set_variable;
> + efi.set_variable_nonblocking = xen_efi_set_variable;
> efi.query_variable_info = xen_efi_query_variable_info;
> + efi.query_variable_info_nonblocking = xen_efi_query_variable_info;
> efi.update_capsule = xen_efi_update_capsule;
> efi.query_capsule_caps = xen_efi_query_capsule_caps;
> efi.get_next_high_mono_count = xen_efi_get_next_high_mono_count;
> --
> 2.21.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-01 17:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-27 15:49 [Xen-devel] [PATCH] xen/efi: Set nonblocking callbacks Ross Lagerwall
2019-09-30 6:47 ` Jürgen Groß
2019-10-01 7:38 ` Jürgen Groß
2019-10-01 17:57 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).