From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, xen-devel@lists.xen.org
Cc: Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 02/16] x86: fix: make atomic_read() param const
Date: Tue, 12 Jul 2016 08:11:53 +0300 [thread overview]
Message-ID: <9671c840-5fc8-b5c6-378b-e941fc443585@bitdefender.com> (raw)
In-Reply-To: <63ee2a47-77aa-3de6-3955-688cbefea3eb@citrix.com>
Hi Andrew,
On 7/11/2016 6:18 PM, Andrew Cooper wrote:
> On 09/07/16 05:12, Corneliu ZUZU wrote:
>> This wouldn't let me make a param of a function that used atomic_read() const.
>>
>> Signed-off-by: Corneliu ZUZU <czuzu@bitdefender.com>
> This is a good improvement, but you must make an identical adjustment to
> the arm code, otherwise you will end up with subtle build failures.
Right, didn't even realize it was X86-specific.
>
> If you are really feeling up to it, having a common xen/atomic.h with
>
> typedef struct { int counter; } atomic_t;
> #define ATOMIC_INIT(i) { (i) }
>
> and some prototypes such as:
>
> static inline int atomic_read(const atomic_t *v);
>
> would be great, but this looks like it has the possibility to turn into
> a rats nest. If it does, then just doubling up this code for arm is ok.
>
> ~Andrew
Yes, that might be more complicated than we expect and I don't know if
making code such as this common would be a good idea, usually these
functions are always architecture-specific. It might be better to keep
them separate - they don't add much anyway since their implementation is
short - than risk unexpected different behavior on a future arch. But
then again I don't know much details of their implementation, so anyway,
I'd surely prefer to do this kind of change in a separate patch.
>
>> ---
>> xen/include/asm-x86/atomic.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/include/asm-x86/atomic.h b/xen/include/asm-x86/atomic.h
>> index d246b70..0b250c8 100644
>> --- a/xen/include/asm-x86/atomic.h
>> +++ b/xen/include/asm-x86/atomic.h
>> @@ -94,7 +94,7 @@ typedef struct { int counter; } atomic_t;
>> *
>> * Atomically reads the value of @v.
>> */
>> -static inline int atomic_read(atomic_t *v)
>> +static inline int atomic_read(const atomic_t *v)
>> {
>> return read_atomic(&v->counter);
>> }
>> @@ -105,7 +105,7 @@ static inline int atomic_read(atomic_t *v)
>> *
>> * Non-atomically reads the value of @v
>> */
>> -static inline int _atomic_read(atomic_t v)
>> +static inline int _atomic_read(const atomic_t v)
>> {
>> return v.counter;
>> }
>
Thanks,
Zuzu C.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-12 5:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 4:11 [PATCH 00/16] x86/vm-event: numerous adjustments & fixes Corneliu ZUZU
2016-07-09 4:12 ` [PATCH 01/16] x86/vmx_update_guest_cr: minor optimization Corneliu ZUZU
2016-07-11 6:24 ` Corneliu ZUZU
2016-07-09 4:12 ` [PATCH 02/16] x86: fix: make atomic_read() param const Corneliu ZUZU
2016-07-11 15:18 ` Andrew Cooper
2016-07-12 5:11 ` Corneliu ZUZU [this message]
2016-07-12 9:42 ` Andrew Cooper
2016-07-12 10:11 ` Corneliu ZUZU
2016-07-12 10:22 ` Andrew Cooper
2016-07-12 10:35 ` Corneliu ZUZU
2016-07-12 10:38 ` Corneliu ZUZU
2016-07-12 12:49 ` Andrew Cooper
2016-07-12 13:45 ` Corneliu ZUZU
2016-07-09 4:13 ` [PATCH 03/16] x86/monitor: mechanical renames Corneliu ZUZU
2016-07-09 18:10 ` Tamas K Lengyel
2016-07-09 18:46 ` Corneliu ZUZU
2016-07-11 16:43 ` Tamas K Lengyel
2016-07-12 6:10 ` Corneliu ZUZU
2016-07-15 7:18 ` Corneliu ZUZU
2016-07-18 18:07 ` Andrew Cooper
2016-07-19 9:36 ` Corneliu ZUZU
2016-07-09 4:14 ` [PATCH 04/16] x86/monitor: relocate vm_event_register_write_resume() function to monitor code Corneliu ZUZU
2016-07-09 18:14 ` Tamas K Lengyel
2016-07-09 18:47 ` Corneliu ZUZU
2016-07-09 4:15 ` [PATCH 05/16] x86/monitor: relocate code more appropriately Corneliu ZUZU
2016-07-11 6:19 ` Corneliu ZUZU
2016-07-12 7:45 ` Tian, Kevin
2016-07-12 8:07 ` Corneliu ZUZU
2016-07-15 11:41 ` Corneliu ZUZU
2016-07-09 4:15 ` [PATCH 06/16] x86/monitor: fix: set msr_bitmap to NULL after xfree Corneliu ZUZU
2016-07-09 4:16 ` [PATCH 07/16] x86/vm-event: fix: call cleanup when init fails, to free partial allocs Corneliu ZUZU
2016-07-09 4:17 ` [PATCH 08/16] x86/vm-event: call monitor init & cleanup funcs from respective vm_event funcs Corneliu ZUZU
2016-07-09 4:18 ` [PATCH 09/16] arm/monitor: move d->monitor cleanup to monitor_cleanup_domain() Corneliu ZUZU
2016-07-09 4:19 ` [PATCH 10/16] x86/vm-event: centralize vcpu-destroy cleanup in vm-events code Corneliu ZUZU
2016-07-09 4:20 ` [PATCH 11/16] x86/monitor: fix: treat -monitor- properly, as a subsys of the vm-event subsys Corneliu ZUZU
2016-07-09 17:34 ` Tamas K Lengyel
2016-07-09 17:46 ` Corneliu ZUZU
2016-07-11 16:38 ` Tamas K Lengyel
2016-07-11 20:20 ` Corneliu ZUZU
2016-07-11 21:27 ` Tamas K Lengyel
2016-07-11 21:47 ` Corneliu ZUZU
2016-07-09 4:20 ` [PATCH 12/16] x86/vm-event: fix: move cleanup of mem_access_emulate_each_rep to monitor stub Corneliu ZUZU
2016-07-09 4:21 ` [PATCH 13/16] x86/monitor: introduce writes_pending field in monitor_write_data Corneliu ZUZU
2016-07-09 4:22 ` [PATCH 14/16] x86/monitor: clarify separation between monitor subsys and vm-event as a whole Corneliu ZUZU
2016-07-09 18:26 ` Tamas K Lengyel
2016-07-09 18:57 ` Corneliu ZUZU
2016-07-13 4:26 ` Corneliu ZUZU
2016-07-13 18:56 ` Tamas K Lengyel
2016-07-09 4:23 ` [PATCH 15/16] x86/monitor: fix: don't compromise a monitor_write_data with pending CR writes Corneliu ZUZU
2016-07-09 4:23 ` [PATCH 16/16] x86/monitor: fix: xc_monitor _write_ctrlreg w/o previous _enable must fail Corneliu ZUZU
2016-07-09 4:34 ` Corneliu ZUZU
2016-07-11 2:54 ` [PATCH 00/16] x86/vm-event: numerous adjustments & fixes Tian, Kevin
2016-07-11 5:32 ` Corneliu ZUZU
2016-07-12 7:42 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9671c840-5fc8-b5c6-378b-e941fc443585@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).