* [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options
@ 2016-07-20 14:49 Ross Lagerwall
2016-07-20 14:49 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Ross Lagerwall
2016-07-21 14:33 ` [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Konrad Rzeszutek Wilk
0 siblings, 2 replies; 6+ messages in thread
From: Ross Lagerwall @ 2016-07-20 14:49 UTC (permalink / raw)
To: xen-devel; +Cc: Ross Lagerwall
---
livepatch-build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/livepatch-build b/livepatch-build
index 7395b49..d9d9da3 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -185,7 +185,7 @@ usage() {
find_tools || die "can't find supporting tools"
-options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:patch:config:output:cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
+options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
eval set -- "$options"
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding
2016-07-20 14:49 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Ross Lagerwall
@ 2016-07-20 14:49 ` Ross Lagerwall
2016-07-21 14:33 ` Konrad Rzeszutek Wilk
2016-07-21 14:33 ` [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Konrad Rzeszutek Wilk
1 sibling, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2016-07-20 14:49 UTC (permalink / raw)
To: xen-devel; +Cc: Ross Lagerwall
Don't change the timestamp of arch/x86/Makefile when editing it since it
forces much of the Xen tree to be rebuilt and then requires many
invocations of create-diff-tool.
This is safe since the Makefile change only changes the final link rule,
and xen will be relinked anyway.
---
livepatch-build | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/livepatch-build b/livepatch-build
index d9d9da3..c057fa1 100755
--- a/livepatch-build
+++ b/livepatch-build
@@ -98,10 +98,13 @@ function build_special()
# Build with special GCC flags
cd "${SRCDIR}/xen" || die
sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk
+ cp -p arch/x86/Makefile arch/x86/Makefile.bak
sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile
+ # Restore timestamps to prevent spurious rebuilding
+ touch --reference=arch/x86/Makefile.bak arch/x86/Makefile
make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die
sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk
- sed -i 's/--section-alignment=0x1000/--section-alignment=0x200000/' arch/x86/Makefile
+ mv -f arch/x86/Makefile.bak arch/x86/Makefile
unset LIVEPATCH_BUILD_DIR
unset LIVEPATCH_CAPTURE_DIR
--
2.7.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding
2016-07-20 14:49 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Ross Lagerwall
@ 2016-07-21 14:33 ` Konrad Rzeszutek Wilk
2016-07-21 14:48 ` Ross Lagerwall
0 siblings, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-21 14:33 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: xen-devel
On Wed, Jul 20, 2016 at 03:49:44PM +0100, Ross Lagerwall wrote:
> Don't change the timestamp of arch/x86/Makefile when editing it since it
> forces much of the Xen tree to be rebuilt and then requires many
> invocations of create-diff-tool.
>
> This is safe since the Makefile change only changes the final link rule,
> and xen will be relinked anyway.
That looks good, but the patch is missing your SoB.
> ---
> livepatch-build | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/livepatch-build b/livepatch-build
> index d9d9da3..c057fa1 100755
> --- a/livepatch-build
> +++ b/livepatch-build
> @@ -98,10 +98,13 @@ function build_special()
> # Build with special GCC flags
> cd "${SRCDIR}/xen" || die
> sed -i 's/CFLAGS += -nostdinc/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/' Rules.mk
> + cp -p arch/x86/Makefile arch/x86/Makefile.bak
> sed -i 's/--section-alignment=0x200000/--section-alignment=0x1000/' arch/x86/Makefile
> + # Restore timestamps to prevent spurious rebuilding
> + touch --reference=arch/x86/Makefile.bak arch/x86/Makefile
> make "-j$CPUS" $XEN_DEBUG &> "${OUTPUT}/build_${name}_compile.log" || die
> sed -i 's/CFLAGS += -nostdinc -ffunction-sections -fdata-sections/CFLAGS += -nostdinc/' Rules.mk
> - sed -i 's/--section-alignment=0x1000/--section-alignment=0x200000/' arch/x86/Makefile
> + mv -f arch/x86/Makefile.bak arch/x86/Makefile
>
> unset LIVEPATCH_BUILD_DIR
> unset LIVEPATCH_CAPTURE_DIR
> --
> 2.7.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding
2016-07-21 14:33 ` Konrad Rzeszutek Wilk
@ 2016-07-21 14:48 ` Ross Lagerwall
2016-07-21 15:20 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 6+ messages in thread
From: Ross Lagerwall @ 2016-07-21 14:48 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel
On 07/21/2016 03:33 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Jul 20, 2016 at 03:49:44PM +0100, Ross Lagerwall wrote:
>> Don't change the timestamp of arch/x86/Makefile when editing it since it
>> forces much of the Xen tree to be rebuilt and then requires many
>> invocations of create-diff-tool.
>>
>> This is safe since the Makefile change only changes the final link rule,
>> and xen will be relinked anyway.
>
> That looks good, but the patch is missing your SoB.
>
Sorry about that.
I pushed both after adding my SoB.
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding
2016-07-21 14:48 ` Ross Lagerwall
@ 2016-07-21 15:20 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-21 15:20 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: xen-devel
On Thu, Jul 21, 2016 at 03:48:17PM +0100, Ross Lagerwall wrote:
> On 07/21/2016 03:33 PM, Konrad Rzeszutek Wilk wrote:
> >On Wed, Jul 20, 2016 at 03:49:44PM +0100, Ross Lagerwall wrote:
> >>Don't change the timestamp of arch/x86/Makefile when editing it since it
> >>forces much of the Xen tree to be rebuilt and then requires many
> >>invocations of create-diff-tool.
> >>
> >>This is safe since the Makefile change only changes the final link rule,
> >>and xen will be relinked anyway.
> >
> >That looks good, but the patch is missing your SoB.
> >
>
> Sorry about that.
>
> I pushed both after adding my SoB.
Thanks!
>
> --
> Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options
2016-07-20 14:49 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Ross Lagerwall
2016-07-20 14:49 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Ross Lagerwall
@ 2016-07-21 14:33 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-07-21 14:33 UTC (permalink / raw)
To: Ross Lagerwall; +Cc: xen-devel
On Wed, Jul 20, 2016 at 03:49:43PM +0100, Ross Lagerwall wrote:
What happend to your SoB?
The patch is fine otherwise.
> ---
> livepatch-build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/livepatch-build b/livepatch-build
> index 7395b49..d9d9da3 100755
> --- a/livepatch-build
> +++ b/livepatch-build
> @@ -185,7 +185,7 @@ usage() {
>
> find_tools || die "can't find supporting tools"
>
> -options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:patch:config:output:cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
> +options=$(getopt -o hs:p:c:o:j:k:d -l "help,srcdir:,patch:,config:,output:,cpus:,skip:,debug,xen-debug,xen-syms:,depends:,prelink" -- "$@") || die "getopt failed"
>
> eval set -- "$options"
>
> --
> 2.7.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-21 15:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-20 14:49 [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Ross Lagerwall
2016-07-20 14:49 ` [PATCH LIVEPATCH-BUILD-TOOLS 2/2] Prevent spurious rebuilding Ross Lagerwall
2016-07-21 14:33 ` Konrad Rzeszutek Wilk
2016-07-21 14:48 ` Ross Lagerwall
2016-07-21 15:20 ` Konrad Rzeszutek Wilk
2016-07-21 14:33 ` [PATCH LIVEPATCH-BUILD-TOOLS 1/2] Fix getopt parsing of long options Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).