xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
@ 2020-10-27 10:58 George Dunlap
  2020-10-27 11:00 ` Andrew Cooper
  2020-10-27 11:01 ` Julien Grall
  0 siblings, 2 replies; 6+ messages in thread
From: George Dunlap @ 2020-10-27 10:58 UTC (permalink / raw)
  To: xen-devel
  Cc: George Dunlap, Andrew Cooper, Jan Beulich, Roger Pau Monne,
	Stefano Stabellini, Julien Grall

It's only called from another __init function.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
---
 xen/arch/arm/mm.c | 2 +-
 xen/arch/x86/mm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 9c4b26bf07..dbd9f3fe4c 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1298,7 +1298,7 @@ int map_pages_to_xen(unsigned long virt,
     return xen_pt_update(virt, mfn, nr_mfns, flags);
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
 }
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index b2f35b3e7d..1f7ddf318b 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5529,7 +5529,7 @@ int map_pages_to_xen(
     return rc;
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return map_pages_to_xen(virt, INVALID_MFN, nr_mfns, MAP_SMALL_PAGES);
 }
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
  2020-10-27 10:58 [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init George Dunlap
@ 2020-10-27 11:00 ` Andrew Cooper
  2020-10-27 11:01 ` Julien Grall
  1 sibling, 0 replies; 6+ messages in thread
From: Andrew Cooper @ 2020-10-27 11:00 UTC (permalink / raw)
  To: George Dunlap, xen-devel
  Cc: Jan Beulich, Roger Pau Monne, Stefano Stabellini, Julien Grall

On 27/10/2020 10:58, George Dunlap wrote:
> It's only called from another __init function.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
  2020-10-27 10:58 [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init George Dunlap
  2020-10-27 11:00 ` Andrew Cooper
@ 2020-10-27 11:01 ` Julien Grall
  1 sibling, 0 replies; 6+ messages in thread
From: Julien Grall @ 2020-10-27 11:01 UTC (permalink / raw)
  To: George Dunlap, xen-devel
  Cc: Andrew Cooper, Jan Beulich, Roger Pau Monne, Stefano Stabellini

Hi George,

On 27/10/2020 10:58, George Dunlap wrote:
> It's only called from another __init function.
> 
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

> ---
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Roger Pau Monne <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien@xen.org>
> ---
>   xen/arch/arm/mm.c | 2 +-
>   xen/arch/x86/mm.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 9c4b26bf07..dbd9f3fe4c 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1298,7 +1298,7 @@ int map_pages_to_xen(unsigned long virt,
>       return xen_pt_update(virt, mfn, nr_mfns, flags);
>   }
>   
> -int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
> +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
>   {
>       return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
>   }
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index b2f35b3e7d..1f7ddf318b 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -5529,7 +5529,7 @@ int map_pages_to_xen(
>       return rc;
>   }
>   
> -int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
> +int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
>   {
>       return map_pages_to_xen(virt, INVALID_MFN, nr_mfns, MAP_SMALL_PAGES);
>   }
> 

-- 
Julien Grall


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
  2023-06-30 12:57 ` Andrew Cooper
@ 2023-06-30 13:05   ` Julien Grall
  0 siblings, 0 replies; 6+ messages in thread
From: Julien Grall @ 2023-06-30 13:05 UTC (permalink / raw)
  To: Andrew Cooper, George Dunlap, xen-devel
  Cc: George Dunlap, Jan Beulich, Roger Pau Monne, Stefano Stabellini

Hi,

On 30/06/2023 13:57, Andrew Cooper wrote:
> On 30/06/2023 1:45 pm, George Dunlap wrote:
>> From: George Dunlap <george.dunlap@citrix.com>
>>
>> It's only called from another __init function.
>>
>> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
>> ---
>> This is a random patch I found in a branch named "xsa345-post".
> 
> I have far too many branches like that...

Same here :).

> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,

-- 
Julien Grall


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
  2023-06-30 12:45 George Dunlap
@ 2023-06-30 12:57 ` Andrew Cooper
  2023-06-30 13:05   ` Julien Grall
  0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2023-06-30 12:57 UTC (permalink / raw)
  To: George Dunlap, xen-devel
  Cc: George Dunlap, Jan Beulich, Roger Pau Monne, Stefano Stabellini,
	Julien Grall

On 30/06/2023 1:45 pm, George Dunlap wrote:
> From: George Dunlap <george.dunlap@citrix.com>
>
> It's only called from another __init function.
>
> Signed-off-by: George Dunlap <george.dunlap@citrix.com>
> ---
> This is a random patch I found in a branch named "xsa345-post".

I have far too many branches like that...

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init
@ 2023-06-30 12:45 George Dunlap
  2023-06-30 12:57 ` Andrew Cooper
  0 siblings, 1 reply; 6+ messages in thread
From: George Dunlap @ 2023-06-30 12:45 UTC (permalink / raw)
  To: xen-devel
  Cc: George Dunlap, Andrew Cooper, Jan Beulich, Roger Pau Monne,
	Stefano Stabellini, Julien Grall

From: George Dunlap <george.dunlap@citrix.com>

It's only called from another __init function.

Signed-off-by: George Dunlap <george.dunlap@citrix.com>
---
This is a random patch I found in a branch named "xsa345-post".

CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien@xen.org>
---
 xen/arch/arm/mm.c | 2 +-
 xen/arch/x86/mm.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
index 0a3e1f3b64..9b14ae3a5d 100644
--- a/xen/arch/arm/mm.c
+++ b/xen/arch/arm/mm.c
@@ -1218,7 +1218,7 @@ int map_pages_to_xen(unsigned long virt,
     return xen_pt_update(virt, mfn, nr_mfns, flags);
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE);
 }
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
index 9741d28cbc..be2b10a391 100644
--- a/xen/arch/x86/mm.c
+++ b/xen/arch/x86/mm.c
@@ -5574,7 +5574,7 @@ int map_pages_to_xen(
     return rc;
 }
 
-int populate_pt_range(unsigned long virt, unsigned long nr_mfns)
+int __init populate_pt_range(unsigned long virt, unsigned long nr_mfns)
 {
     return map_pages_to_xen(virt, INVALID_MFN, nr_mfns, MAP_SMALL_PAGES);
 }
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-06-30 13:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 10:58 [PATCH] {x86,arm}/mm.c: Make populate_pt_range __init George Dunlap
2020-10-27 11:00 ` Andrew Cooper
2020-10-27 11:01 ` Julien Grall
2023-06-30 12:45 George Dunlap
2023-06-30 12:57 ` Andrew Cooper
2023-06-30 13:05   ` Julien Grall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).