From: "Tian, Kevin" <kevin.tian@intel.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Elena Ufimtseva <elena.ufimtseva@oracle.com>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH] dmar: Fix double free in error paths following c/s a8bc99b
Date: Mon, 20 Jul 2015 01:31:47 +0000 [thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D1262CC75A@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1437047823-24686-1-git-send-email-andrew.cooper3@citrix.com>
> From: Andrew Cooper [mailto:andrew.cooper3@citrix.com]
> Sent: Thursday, July 16, 2015 7:57 PM
>
> Several error paths would end up freeing scope->devices twice.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Elena Ufimtseva <elena.ufimtseva@oracle.com>
> CC: Yang Zhang <yang.z.zhang@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
> ---
> xen/drivers/passthrough/vtd/dmar.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c
> index 8ed1e24..2672688 100644
> --- a/xen/drivers/passthrough/vtd/dmar.c
> +++ b/xen/drivers/passthrough/vtd/dmar.c
> @@ -88,6 +88,7 @@ static void scope_devices_free(struct dmar_scope *scope)
>
> scope->devices_cnt = 0;
> xfree(scope->devices);
> + scope->devices = NULL;
> }
>
> static void __init disable_all_dmar_units(void)
> --
> 1.7.10.4
prev parent reply other threads:[~2015-07-20 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 11:57 [PATCH] dmar: Fix double free in error paths following c/s a8bc99b Andrew Cooper
2015-07-16 13:22 ` Jan Beulich
2015-07-20 1:31 ` Tian, Kevin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D1262CC75A@SHSMSX101.ccr.corp.intel.com \
--to=kevin.tian@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=elena.ufimtseva@oracle.com \
--cc=xen-devel@lists.xen.org \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).