xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Ross Lagerwall <ross.lagerwall@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH v2] vmx: Restore debug registers when injecting #DB traps
Date: Tue, 15 Mar 2016 04:37:08 +0000	[thread overview]
Message-ID: <AADFC41AFE54684AB9EE6CBC0274A5D15F7E81D0@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1457713413-2157-1-git-send-email-ross.lagerwall@citrix.com>

> From: Ross Lagerwall [mailto:ross.lagerwall@citrix.com]
> Sent: Saturday, March 12, 2016 12:24 AM
> Commit a929bee0e652 ("x86/vmx: Fix injection of #DB traps following
> XSA-156") prevents an infinite loop in certain #DB traps. However, it
> changed the behavior to not call hvm_hw_inject_trap() for #DB and #AC
> traps which which means that the debug registers are not restored
> correctly and nullified commit b56ae5b48c38 ("VMX: fix/adjust trap
> injection").
> To fix this, restore the original code path through hvm_inject_trap(),
> but ensure that the struct hvm_trap is populated with all the required
> data.
> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>

Acked-by: Kevin Tian <kevin.tian@intel.com>

Xen-devel mailing list

  parent reply	other threads:[~2016-03-15  4:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 16:23 [PATCH v2] vmx: Restore debug registers when injecting #DB traps Ross Lagerwall
2016-03-14  8:57 ` Jan Beulich
2016-03-15  4:37 ` Tian, Kevin [this message]
2016-03-16 14:07 ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AADFC41AFE54684AB9EE6CBC0274A5D15F7E81D0@SHSMSX101.ccr.corp.intel.com \
    --to=kevin.tian@intel.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xen.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).