From: George Dunlap <George.Dunlap@citrix.com>
To: Juergen Gross <JGross@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Ian Jackson <Ian.Jackson@citrix.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v7 03/12] docs: add feature document for Xen hypervisor sysfs-like support
Date: Mon, 27 Apr 2020 13:55:27 +0000 [thread overview]
Message-ID: <AB2368EA-FE62-4735-8064-98DE220B6F9E@citrix.com> (raw)
In-Reply-To: <20200402154616.16927-4-jgross@suse.com>
> On Apr 2, 2020, at 4:46 PM, Juergen Gross <JGross@suse.com> wrote:
[snip]
> +* {VALUE, VALUE, ... } -- a list of possible values separated by "," and
> + enclosed in "{" and "}".
[snip]
> +So an entry could look like this:
> +
> + /cpu-bugs/active-pv/xpti = ("No"|{"dom0", "domU", "PCID on"}) [w,X86,PV]
> +
> +Possible values would be "No" or a list of "dom0", "domU", and "PCID on".
One thing that wasn’t clear to me here: Does the “list” look like
“dom0", “domU", “PCID on”
or
{dom0, domU, PCID on}
or
{“dom0”, “domU”, “PCID on”}
?
Another question that occurs to me from asking this question: in a case like this, are we generally expecting to have options with spaces in them (like “PCID on”)? And/or, are we expecting the strings themselves to have quotes in them? If so, commands to manipulate these will start to look a little gnarly:
xenhypfs write <path> “{\”dom0\”, \”PCID on\”}”
It seems like it would be nicer to be able to write:
xenhypfs write <path> "{dom0, PCID-on}”
(Maybe this will be made more clear later in the series, just thought I’d share my thoughts / confusion here.)
-George
next prev parent reply other threads:[~2020-04-27 13:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 15:46 [PATCH v7 00/12] Add hypervisor sysfs-like support Juergen Gross
2020-04-02 15:46 ` [PATCH v7 01/12] xen/vmx: let opt_ept_ad always reflect the current setting Juergen Gross
2020-04-03 14:05 ` Jan Beulich
2020-04-03 14:56 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 02/12] xen: add a generic way to include binary files as variables Juergen Gross
2020-04-02 15:46 ` [PATCH v7 03/12] docs: add feature document for Xen hypervisor sysfs-like support Juergen Gross
2020-04-27 13:55 ` George Dunlap [this message]
2020-05-07 11:17 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 04/12] xen: add basic hypervisor filesystem support Juergen Gross
2020-04-03 14:23 ` Jan Beulich
2020-04-03 15:05 ` Jürgen Groß
2020-04-03 15:31 ` Jan Beulich
2020-04-03 15:33 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 05/12] libs: add libxenhypfs Juergen Gross
2020-04-27 14:53 ` George Dunlap
2020-05-07 11:35 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 06/12] tools: add xenfs tool Juergen Gross
2020-04-02 15:46 ` [PATCH v7 07/12] xen: provide version information in hypfs Juergen Gross
2020-04-02 15:46 ` [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem Juergen Gross
2020-04-03 14:31 ` Jan Beulich
2020-04-03 15:12 ` Jürgen Groß
2020-04-03 15:33 ` Jan Beulich
2020-04-03 15:45 ` Jürgen Groß
2020-04-06 12:29 ` Jan Beulich
2020-04-27 15:40 ` Jürgen Groß
2020-04-27 16:25 ` George Dunlap
2020-04-28 7:20 ` Jan Beulich
2020-04-28 8:24 ` George Dunlap
2020-04-28 8:39 ` Jan Beulich
2020-04-28 9:43 ` Julien Grall
2020-04-28 9:59 ` Jan Beulich
2020-04-28 10:06 ` Julien Grall
2020-04-28 11:23 ` George Dunlap
2020-04-28 11:30 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 09/12] xen: add runtime parameter access support to hypfs Juergen Gross
2020-04-03 14:51 ` Jan Beulich
2020-04-03 15:31 ` Jürgen Groß
2020-04-14 9:29 ` Julien Grall
2020-04-14 9:31 ` Jan Beulich
2020-04-14 9:45 ` Julien Grall
2020-04-14 9:50 ` Jan Beulich
2020-04-14 10:38 ` Julien Grall
2020-04-02 15:46 ` [PATCH v7 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters Juergen Gross
2020-04-02 15:46 ` [PATCH v7 11/12] tools/libxc: remove xc_set_parameters() Juergen Gross
2020-04-02 15:46 ` [PATCH v7 12/12] xen: remove XEN_SYSCTL_set_parameter support Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AB2368EA-FE62-4735-8064-98DE220B6F9E@citrix.com \
--to=george.dunlap@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=JGross@suse.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).