From: Julien Grall <julien@xen.org>
To: "Jürgen Groß" <jgross@suse.com>, "Jan Beulich" <jbeulich@suse.com>
Cc: "Kevin Tian" <kevin.tian@intel.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Ian Jackson" <ian.jackson@eu.citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Jun Nakajima" <jun.nakajima@intel.com>,
xen-devel@lists.xenproject.org,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v7 09/12] xen: add runtime parameter access support to hypfs
Date: Tue, 14 Apr 2020 10:29:05 +0100 [thread overview]
Message-ID: <bdd65308-e549-c2b2-0de9-fb220d03f087@xen.org> (raw)
In-Reply-To: <1a68e135-2761-0ccd-11fc-45344a84757d@suse.com>
On 03/04/2020 16:31, Jürgen Groß wrote:
> On 03.04.20 16:51, Jan Beulich wrote:
>> On 02.04.2020 17:46, Juergen Gross wrote:
>>> V7:
>>> - fine tune some parameter initializations (Jan Beulich)
>>> - call custom_runtime_set_var() after updating the value
>>> - modify alignment in Arm linker script to 4 (Jan Beulich)
>>
>> I didn't ask for this to be unilaterally 4 - I don't think this
>> would work on Arm64, seeing that there are pointers inside the
>> struct. This wants to be pointer size, i.e. 4 for Arm32 but 8
>> for Arm64.
We don't allow unaligned access on Arm32, so if your structure happen to
have a 64-bit value in it then you will get a crash at runtime.
For safety, it should neither be POINTER_ALIGN or 4, but 8. This is
going to make your linker more robust.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2020-04-14 9:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 15:46 [PATCH v7 00/12] Add hypervisor sysfs-like support Juergen Gross
2020-04-02 15:46 ` [PATCH v7 01/12] xen/vmx: let opt_ept_ad always reflect the current setting Juergen Gross
2020-04-03 14:05 ` Jan Beulich
2020-04-03 14:56 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 02/12] xen: add a generic way to include binary files as variables Juergen Gross
2020-04-02 15:46 ` [PATCH v7 03/12] docs: add feature document for Xen hypervisor sysfs-like support Juergen Gross
2020-04-27 13:55 ` George Dunlap
2020-05-07 11:17 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 04/12] xen: add basic hypervisor filesystem support Juergen Gross
2020-04-03 14:23 ` Jan Beulich
2020-04-03 15:05 ` Jürgen Groß
2020-04-03 15:31 ` Jan Beulich
2020-04-03 15:33 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 05/12] libs: add libxenhypfs Juergen Gross
2020-04-27 14:53 ` George Dunlap
2020-05-07 11:35 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 06/12] tools: add xenfs tool Juergen Gross
2020-04-02 15:46 ` [PATCH v7 07/12] xen: provide version information in hypfs Juergen Gross
2020-04-02 15:46 ` [PATCH v7 08/12] xen: add /buildinfo/config entry to hypervisor filesystem Juergen Gross
2020-04-03 14:31 ` Jan Beulich
2020-04-03 15:12 ` Jürgen Groß
2020-04-03 15:33 ` Jan Beulich
2020-04-03 15:45 ` Jürgen Groß
2020-04-06 12:29 ` Jan Beulich
2020-04-27 15:40 ` Jürgen Groß
2020-04-27 16:25 ` George Dunlap
2020-04-28 7:20 ` Jan Beulich
2020-04-28 8:24 ` George Dunlap
2020-04-28 8:39 ` Jan Beulich
2020-04-28 9:43 ` Julien Grall
2020-04-28 9:59 ` Jan Beulich
2020-04-28 10:06 ` Julien Grall
2020-04-28 11:23 ` George Dunlap
2020-04-28 11:30 ` Jürgen Groß
2020-04-02 15:46 ` [PATCH v7 09/12] xen: add runtime parameter access support to hypfs Juergen Gross
2020-04-03 14:51 ` Jan Beulich
2020-04-03 15:31 ` Jürgen Groß
2020-04-14 9:29 ` Julien Grall [this message]
2020-04-14 9:31 ` Jan Beulich
2020-04-14 9:45 ` Julien Grall
2020-04-14 9:50 ` Jan Beulich
2020-04-14 10:38 ` Julien Grall
2020-04-02 15:46 ` [PATCH v7 10/12] tools/libxl: use libxenhypfs for setting xen runtime parameters Juergen Gross
2020-04-02 15:46 ` [PATCH v7 11/12] tools/libxc: remove xc_set_parameters() Juergen Gross
2020-04-02 15:46 ` [PATCH v7 12/12] xen: remove XEN_SYSCTL_set_parameter support Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdd65308-e549-c2b2-0de9-fb220d03f087@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).