Xen-Devel Archive on lore.kernel.org
 help / color / Atom feed
From: Artem Mygaiev <Artem_Mygaiev@epam.com>
To: Julien Grall <julien@xen.org>,
	Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>,
	"jbeulich@suse.com" <jbeulich@suse.com>,
	"George.Dunlap@citrix.com" <George.Dunlap@citrix.com>
Cc: "vicooodin@gmail.com" <vicooodin@gmail.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"committers@xenproject.org" <committers@xenproject.org>,
	"viktor.mitin.19@gmail.com" <viktor.mitin.19@gmail.com>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: RE: Xen Coding style and clang-format
Date: Fri, 16 Oct 2020 11:37:20 +0000
Message-ID: <AM6PR03MB3687A99424FA9FD062F5FE4BF4030@AM6PR03MB3687.eurprd03.prod.outlook.com> (raw)
In-Reply-To: <5bd7cc00-c4c9-0737-897d-e76f22e2fd5b@xen.org>


-----Original Message-----
From: Julien Grall <julien@xen.org> 
Sent: пятница, 16 октября 2020 г. 13:24
To: Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>; jbeulich@suse.com; George.Dunlap@citrix.com
Cc: Artem Mygaiev <Artem_Mygaiev@epam.com>; vicooodin@gmail.com; xen-devel@lists.xenproject.org; committers@xenproject.org; viktor.mitin.19@gmail.com; Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: Xen Coding style and clang-format

> Hi,
> On 16/10/2020 10:42, Anastasiia Lukianenko wrote:
> > Thanks for your advices, which helped me improve the checker. I
> > understand that there are still some disagreements about the
> > formatting, but as I said before, the checker cannot be very flexible
> > and take into account all the author's ideas.
> I am not sure what you refer by "author's ideas" here. The checker 
> should follow a coding style (Xen or a modified version):
>     - Anything not following the coding style should be considered as 
> invalid.
>     - Anything not written in the coding style should be left 
> untouched/uncommented by the checker.


> > I suggest using the
> > checker not as a mandatory check, but as an indication to the author of
> > possible formatting errors that he can correct or ignore.
> I can understand that short term we would want to make it optional so 
> either the coding style or the checker can be tuned. But I don't think 
> this is an ideal situation to be in long term.
> The goal of the checker is to automatically verify the coding style and 
> get it consistent across Xen. If we make it optional or it is 
> "unreliable", then we lose the two benefits and possibly increase the 
> contributor frustration as the checker would say A but we need B.
> Therefore, we need to make sure the checker and the coding style match. 
> I don't have any opinions on the approach to achieve that.

Of the list of remaining issues from Anastasiia, looks like only items 5
and 6 are conform to official Xen coding style. As for remainning ones,
I would like to suggest disabling those that are controversial (items 1,
2, 4, 8, 9, 10). Maybe we want to have further discussion on refining 
coding style, we can use these as starting point. If we are open to
extending style now, I would suggest to add rules that seem to be
meaningful (items 3, 7) and keep them in checker.

-- Artem

  reply index

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30  9:18 Anastasiia Lukianenko
2020-09-30  9:57 ` Jan Beulich
2020-09-30 10:24   ` George Dunlap
2020-10-01  9:06     ` Anastasiia Lukianenko
2020-10-01 10:06       ` George Dunlap
2020-10-07 10:19         ` Anastasiia Lukianenko
2020-10-08  1:07           ` Stefano Stabellini
2020-10-12 14:37             ` Anastasiia Lukianenko
2020-10-12 18:09           ` George Dunlap
2020-10-13 12:30             ` Jan Beulich
2020-10-16  9:42               ` Anastasiia Lukianenko
2020-10-16 10:23                 ` Julien Grall
2020-10-16 11:37                   ` Artem Mygaiev [this message]
2020-10-19 18:07                     ` Stefano Stabellini
2020-10-20 17:13                       ` Julien Grall
2020-10-23  9:39                         ` Anastasiia Lukianenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR03MB3687A99424FA9FD062F5FE4BF4030@AM6PR03MB3687.eurprd03.prod.outlook.com \
    --to=artem_mygaiev@epam.com \
    --cc=Anastasiia_Lukianenko@epam.com \
    --cc=George.Dunlap@citrix.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=committers@xenproject.org \
    --cc=jbeulich@suse.com \
    --cc=julien@xen.org \
    --cc=vicooodin@gmail.com \
    --cc=viktor.mitin.19@gmail.com \
    --cc=xen-devel@lists.xenproject.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Xen-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/xen-devel/0 xen-devel/git/0.git
	git clone --mirror https://lore.kernel.org/xen-devel/1 xen-devel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 xen-devel xen-devel/ https://lore.kernel.org/xen-devel \
		xen-devel@lists.xenproject.org xen-devel@lists.xen.org
	public-inbox-index xen-devel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git