From: Anastasiia Lukianenko <Anastasiia_Lukianenko@epam.com>
To: "jbeulich@suse.com" <jbeulich@suse.com>,
"George.Dunlap@citrix.com" <George.Dunlap@citrix.com>
Cc: Artem Mygaiev <Artem_Mygaiev@epam.com>,
"committers@xenproject.org" <committers@xenproject.org>,
"julien@xen.org" <julien@xen.org>,
"vicooodin@gmail.com" <vicooodin@gmail.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"viktor.mitin.19@gmail.com" <viktor.mitin.19@gmail.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: Xen Coding style and clang-format
Date: Thu, 1 Oct 2020 09:06:02 +0000 [thread overview]
Message-ID: <b16dfb26e0916166180d5cbbe95278dc99277330.camel@epam.com> (raw)
In-Reply-To: <E068C671-8009-4976-87B8-0709F6A5C3BF@citrix.com>
Hi,
On Wed, 2020-09-30 at 10:24 +0000, George Dunlap wrote:
> > On Sep 30, 2020, at 10:57 AM, Jan Beulich <jbeulich@suse.com>
> > wrote:
> >
> > On 30.09.2020 11:18, Anastasiia Lukianenko wrote:
> > > I would like to know your opinion on the following coding style
> > > cases.
> > > Which option do you think is correct?
> > > 1) Function prototype when the string length is longer than the
> > > allowed
> > > one
> > > -static int __init
> > > -acpi_parse_gic_cpu_interface(struct acpi_subtable_header
> > > *header,
> > > - const unsigned long end)
> > > +static int __init acpi_parse_gic_cpu_interface(
> > > + struct acpi_subtable_header *header, const unsigned long
> > > end)
> >
> > Both variants are deemed valid style, I think (same also goes for
> > function calls with this same problem). In fact you mix two
> > different style aspects together (placement of parameter
> > declarations and placement of return type etc) - for each
> > individually both forms are deemed acceptable, I think.
>
> If we’re going to have a tool go through and report (correct?) all
> these coding style things, it’s an opportunity to think if we want to
> add new coding style requirements (or change existing requirements).
>
I am ready to discuss new requirements and implement them in rules of
the Xen Coding style checker.
> -George
Regards,
Anastasiia
next prev parent reply other threads:[~2020-10-01 9:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 9:18 Xen Coding style and clang-format Anastasiia Lukianenko
2020-09-30 9:57 ` Jan Beulich
2020-09-30 10:24 ` George Dunlap
2020-10-01 9:06 ` Anastasiia Lukianenko [this message]
2020-10-01 10:06 ` George Dunlap
2020-10-07 10:19 ` Anastasiia Lukianenko
2020-10-08 1:07 ` Stefano Stabellini
2020-10-12 14:37 ` Anastasiia Lukianenko
2020-10-12 18:09 ` George Dunlap
2020-10-13 12:30 ` Jan Beulich
2020-10-16 9:42 ` Anastasiia Lukianenko
2020-10-16 10:23 ` Julien Grall
2020-10-16 11:37 ` Artem Mygaiev
2020-10-19 18:07 ` Stefano Stabellini
2020-10-20 17:13 ` Julien Grall
2020-10-23 9:39 ` Anastasiia Lukianenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b16dfb26e0916166180d5cbbe95278dc99277330.camel@epam.com \
--to=anastasiia_lukianenko@epam.com \
--cc=Artem_Mygaiev@epam.com \
--cc=George.Dunlap@citrix.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=committers@xenproject.org \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=vicooodin@gmail.com \
--cc=viktor.mitin.19@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).