* [PATCH] svm: Fix MISRA 8.2 violation
@ 2024-04-25 9:12 George Dunlap
2024-04-25 9:55 ` Jan Beulich
2024-04-25 16:00 ` Andrew Cooper
0 siblings, 2 replies; 4+ messages in thread
From: George Dunlap @ 2024-04-25 9:12 UTC (permalink / raw)
To: xen-devel
Cc: George Dunlap, Andrew Cooper, Jan Beulich, Roger Pau Monne,
Nicola Vetrini
Misra 8.2 requires named parameters in prototypes. Use the name from
the implementaiton.
Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit").
Signed-off-by: George Dunlap <george.dunlap@cloud.com>
---
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Roger Pau Monne <roger.pau@cloud.com>
CC: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
xen/arch/x86/include/asm/hvm/nestedhvm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/x86/include/asm/hvm/nestedhvm.h b/xen/arch/x86/include/asm/hvm/nestedhvm.h
index 0568acb25f..ea2c1bc328 100644
--- a/xen/arch/x86/include/asm/hvm/nestedhvm.h
+++ b/xen/arch/x86/include/asm/hvm/nestedhvm.h
@@ -83,7 +83,7 @@ static inline bool vvmcx_valid(const struct vcpu *v)
}
-void start_nested_svm(struct hvm_function_table *);
-void start_nested_vmx(struct hvm_function_table *);
+void start_nested_svm(struct hvm_function_table *hvm_function_table);
+void start_nested_vmx(struct hvm_function_table *hvm_function_table);
#endif /* _HVM_NESTEDHVM_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] svm: Fix MISRA 8.2 violation
2024-04-25 9:12 [PATCH] svm: Fix MISRA 8.2 violation George Dunlap
@ 2024-04-25 9:55 ` Jan Beulich
2024-04-25 16:00 ` Andrew Cooper
1 sibling, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2024-04-25 9:55 UTC (permalink / raw)
To: George Dunlap; +Cc: Andrew Cooper, Roger Pau Monne, Nicola Vetrini, xen-devel
On 25.04.2024 11:12, George Dunlap wrote:
> Misra 8.2 requires named parameters in prototypes. Use the name from
> the implementaiton.
>
> Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit").
>
> Signed-off-by: George Dunlap <george.dunlap@cloud.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] svm: Fix MISRA 8.2 violation
2024-04-25 9:12 [PATCH] svm: Fix MISRA 8.2 violation George Dunlap
2024-04-25 9:55 ` Jan Beulich
@ 2024-04-25 16:00 ` Andrew Cooper
2024-04-26 8:30 ` George Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Cooper @ 2024-04-25 16:00 UTC (permalink / raw)
To: George Dunlap, xen-devel; +Cc: Jan Beulich, Roger Pau Monne, Nicola Vetrini
On 25/04/2024 10:12 am, George Dunlap wrote:
> Misra 8.2 requires named parameters in prototypes. Use the name from
> the implementaiton.
>
> Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit").
Nit. We treat Fixes: as a tag.
Also you might want to include the Reported-by's.
Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> although
I have a strong wish to shorten the parameter name. That can be done at
a later point.
~Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] svm: Fix MISRA 8.2 violation
2024-04-25 16:00 ` Andrew Cooper
@ 2024-04-26 8:30 ` George Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: George Dunlap @ 2024-04-26 8:30 UTC (permalink / raw)
To: Andrew Cooper; +Cc: xen-devel, Jan Beulich, Roger Pau Monne, Nicola Vetrini
On Thu, Apr 25, 2024 at 5:00 PM Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>
> On 25/04/2024 10:12 am, George Dunlap wrote:
> > Misra 8.2 requires named parameters in prototypes. Use the name from
> > the implementaiton.
> >
> > Fixes 0d19d3aab0 ("svm/nestedsvm: Introduce nested capabilities bit").
>
> Nit. We treat Fixes: as a tag.
Oops -- I'll fix that on check-in. Gmail is also underlining my
misspelling of "implementation" in red, so I'll fix that as well.
> Also you might want to include the Reported-by's.
I thought about adding a Reported-by; but this was reported by Eclair,
which is run automatically, right? We typically don't give a
"Reported-by" to the person who flagged up the osstest or gitlab
failure, so I figured this would be similar.
I'm happy to give credit where it's due, however. You were the first
one who reported it to me, but Nicola also raised it; and I guess it's
someone else who's paying for the Eclair runs. So what "Reported-by"
did you have in mind?
> Otherwise, Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> although
> I have a strong wish to shorten the parameter name. That can be done at
> a later point.
Thanks,
-George
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-04-26 8:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-25 9:12 [PATCH] svm: Fix MISRA 8.2 violation George Dunlap
2024-04-25 9:55 ` Jan Beulich
2024-04-25 16:00 ` Andrew Cooper
2024-04-26 8:30 ` George Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).