From: Tamas K Lengyel <tamas@tklengyel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
"wei.liu2@citrix.com" <wei.liu2@citrix.com>,
Razvan Cojocaru <rcojocaru@bitdefender.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Jun Nakajima <jun.nakajima@intel.com>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH V2] vm_event: Allow subscribing to write events for specific MSR-s
Date: Thu, 14 Apr 2016 09:33:09 -0600 [thread overview]
Message-ID: <CABfawhnRm8Q7c9LkL=FFsLXy2ybQ2e0HaHQfug__nYw-2B3BWw@mail.gmail.com> (raw)
In-Reply-To: <570FC34F02000078000E678A@prv-mh.provo.novell.com>
[-- Attachment #1.1: Type: text/plain, Size: 1202 bytes --]
On Thu, Apr 14, 2016 at 9:20 AM, Jan Beulich <jbeulich@suse.com> wrote:
> >>> Razvan Cojocaru <rcojocaru@bitdefender.com> 04/14/16 11:37 AM >>>
> >On 04/13/2016 06:05 PM, Tamas K Lengyel wrote:
> >>
> >> Yea, well then we need to introduce a new struct with a new subop to
> >> pass the bitmask. I guess its a lesson in ABI design to leave some
> >> wiggle room for future-proofing it (my bad). So I guess we can introduce
> >> XEN_DOMCTL_MONITOR_OP_ENABLE_V2 and struct xen_domctl_monitor_op_v2
> >> where say expand the union to uint64_t just in case?
> >
> >I can do that, but it would seem that this is somewhat at odds with
> >Andrew Cooper's perspective - he has stated that it's within the rules
> >and the domctl can be changed without there being the need for
> >XEN_DOMCTL_MONITOR_OP_ENABLE_V2. So this should be clarified, please,
> >otherwise I'm incurring the risk of changing the code only to have to
> >revert it later.
>
> You basically have two options - the new sub-op or changing the existing
> one while (if not already done so in a dev cycle) bumping the domctl
> interface version.
If bumping the domctl version is not too much hassle I think that would be
the easiest.
Tamas
[-- Attachment #1.2: Type: text/html, Size: 1791 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-14 15:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 5:11 [PATCH V2] vm_event: Allow subscribing to write events for specific MSR-s Razvan Cojocaru
2016-04-13 9:47 ` Konrad Rzeszutek Wilk
2016-04-13 10:07 ` Andrew Cooper
2016-04-13 11:57 ` Razvan Cojocaru
2016-04-13 14:52 ` Tamas K Lengyel
2016-04-13 14:56 ` Razvan Cojocaru
2016-04-13 15:01 ` Andrew Cooper
2016-04-13 15:05 ` Tamas K Lengyel
2016-04-14 9:37 ` Razvan Cojocaru
2016-04-14 15:20 ` Jan Beulich
2016-04-14 15:33 ` Tamas K Lengyel [this message]
2016-04-14 15:37 ` Razvan Cojocaru
2016-04-13 14:50 ` Tamas K Lengyel
2016-04-13 14:52 ` Razvan Cojocaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABfawhnRm8Q7c9LkL=FFsLXy2ybQ2e0HaHQfug__nYw-2B3BWw@mail.gmail.com' \
--to=tamas@tklengyel.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=keir@xen.org \
--cc=kevin.tian@intel.com \
--cc=rcojocaru@bitdefender.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).