From: George Dunlap <dunlapg@umich.edu>
To: M A Young <m.a.young@durham.ac.uk>
Cc: Marcos Matsunaga <marcos.matsunaga@oracle.com>,
Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: Build problems with xen 4.7
Date: Tue, 7 Jun 2016 11:50:53 +0100 [thread overview]
Message-ID: <CAFLBxZaOPWYijpA-pBVC5kzjMo38T=44s+a+v1w9V4vPyePM-g@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1606071138570.31493@algedi.dur.ac.uk>
On Tue, Jun 7, 2016 at 11:42 AM, M A Young <m.a.young@durham.ac.uk> wrote:
> On Tue, 7 Jun 2016, George Dunlap wrote:
>
>> On Fri, May 13, 2016 at 4:23 PM, Konrad Rzeszutek Wilk
>> <konrad.wilk@oracle.com> wrote:
>> > --- xen-4.7.0/config/StdGNU.mk.orig 2016-04-15 22:56:52.191227591 +0100
>> > +++ xen-4.7.0/config/StdGNU.mk 2016-04-15 23:01:40.978829756 +0100
>> > @@ -37,6 +37,12 @@
>> >
>> > ifneq ($(debug),y)
>> > CFLAGS += -O2 -fomit-frame-pointer -fno-tree-coalesce-vars
>> > +ifeq ($(XEN_TARGET_ARCH),x86_64)
>> > +#might be cross-compiling so strip out possible x86_32 options
>> > +CFLAGS += $(shell echo $(CFLAGS_EXTRA) | sed -e 's/-m32//g' -e 's/-march=i686//g' -e 's/-mtune=atom//g')
>> > +else
>> > +CFLAGS += $(CFLAGS_EXTRA)
>> > +endif
>>
>> Why the if? Under what circumstances is it actually appropriate to
>> pass in those kinds of flags to the Xen build system?
>
> That may not be needed in general. It is something I added for Fedora as I
> am cross-compiling the hypervisor as x86_64 to put in the i686 package
> because ix86 hypervisors are no longer supported.
It could be argued that the person setting CFLAGS_EXTRA should remove
those before calling 'make xen' when cross-compiling. Setting
CFLAGS_EXTRA=-m32 make XEN_TARGET_ARCH=x86_64 doesn't really make much
sense. :-)
At the moment, for example, I've got to unset all additional CFLAGS
before calling "make stubdom" or the resulting pvgrub images crash on
boot. To be consistent we should try to either 1) Make it the
caller's job to make sure not to pass in inappropriate arguments, or
2) make it Xen's job to filter out all inappropriate options.
I'm inclined to go with #1, at least to begin with, for simplicity.
What do you think?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-07 10:50 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 23:37 Build problems with xen 4.7 M A Young
2015-12-01 13:19 ` Jan Beulich
2015-12-01 14:36 ` Konrad Rzeszutek Wilk
2015-12-01 14:50 ` Marcos E. Matsunaga
2015-12-01 15:56 ` Jan Beulich
2015-12-01 15:59 ` Konrad Rzeszutek Wilk
2015-12-01 16:09 ` Jan Beulich
2015-12-01 18:47 ` M A Young
2015-12-01 19:40 ` Olaf Hering
2015-12-01 19:53 ` Andrew Cooper
2015-12-02 10:05 ` Jan Beulich
2016-05-13 13:49 ` Konrad Rzeszutek Wilk
2016-05-13 14:01 ` Jan Beulich
2016-05-13 14:25 ` M A Young
2016-05-13 15:23 ` Konrad Rzeszutek Wilk
2016-05-31 18:27 ` George Dunlap
2016-05-31 20:57 ` Konrad Rzeszutek Wilk
2016-06-03 11:20 ` George Dunlap
2016-06-03 17:03 ` Konrad Rzeszutek Wilk
2016-06-07 10:35 ` George Dunlap
2016-06-07 10:42 ` M A Young
2016-06-07 10:50 ` George Dunlap [this message]
2016-06-07 11:33 ` Doug Goldstein
2016-06-07 13:48 ` George Dunlap
2016-06-07 14:00 ` Olaf Hering
2016-06-07 14:04 ` George Dunlap
2016-06-07 14:10 ` Olaf Hering
2016-06-08 10:20 ` George Dunlap
2016-06-07 10:43 ` Jan Beulich
2016-06-07 10:52 ` M A Young
2016-08-08 14:37 ` Peng Fan
2016-08-08 19:22 ` M A Young
2015-12-01 14:49 ` M A Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZaOPWYijpA-pBVC5kzjMo38T=44s+a+v1w9V4vPyePM-g@mail.gmail.com' \
--to=dunlapg@umich.edu \
--cc=JBeulich@suse.com \
--cc=m.a.young@durham.ac.uk \
--cc=marcos.matsunaga@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).