From: Oleksandr Tyshchenko <oleksandr.tyshchenko@globallogic.com>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Iurii Konovalenko <iurii.konovalenko@globallogic.com>,
Dirk Behme <dirk.behme@de.bosch.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 1/3] xen/arm: drivers: scif: Remove dead code
Date: Tue, 21 Jun 2016 16:11:52 +0300 [thread overview]
Message-ID: <CAJEb2DFSw=+FB2z_QE0oa6XqLWMa0Zhq8DvjcEVtXHQ=dZ5UJg@mail.gmail.com> (raw)
In-Reply-To: <57693C14.9060004@arm.com>
On Tue, Jun 21, 2016 at 4:07 PM, Julien Grall <julien.grall@arm.com> wrote:
>
>
> On 21/06/16 13:54, Oleksandr Tyshchenko wrote:
>>
>> On Tue, Jun 21, 2016 at 3:15 PM, Julien Grall <julien.grall@arm.com>
>> wrote:
>>>>
>>>> On Tue, Jun 21, 2016 at 12:15 PM, Dirk Behme <dirk.behme@de.bosch.com>
>>>> wrote:
>>>
>>> I have some doubt that the current code is valid. The clock frequency is
>>> hardcoded (see SCIF_CLK_FREQ), so are you saying that the frequency is
>>> always the same across all the platforms?
>>
>>
>> No.
>>
>> This driver has been initially written for Renesas Lager board based
>> on R-Car H2 SoC which
>> has SCIF compatible UART. And the current code is valid for it. I have
>> tested both auto and
>> variable (38400, 115200) baudrates.
>> But, I am afraid that current code won't be suitable for
>> all of the boards which have the same UART IP. It depends at least
>> from clock source
>> (external/internal) and clock frequency.
>
>
> In this case, the code should either be fixed by reading the clock frequency
> from the firmware tables or be dropped.
>
> I would lean towards the later because the user cannot specify the baud rate
> to Xen.
Agree.
>
> Regards,
>
> --
> Julien Grall
--
Oleksandr Tyshchenko | Embedded Dev
GlobalLogic
www.globallogic.com
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-06-21 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 9:15 [PATCH 1/3] xen/arm: drivers: scif: Remove dead code Dirk Behme
2016-06-21 9:15 ` [PATCH 2/3] xen/arm: drivers: scif: Remove unused variables Dirk Behme
2016-06-21 12:17 ` Julien Grall
2016-06-21 9:15 ` [PATCH 3/3] xen/arm: drivers: scif: Add clock auto detection Dirk Behme
2016-06-21 12:20 ` Julien Grall
2016-06-21 12:30 ` Dirk Behme
2016-06-21 12:33 ` Julien Grall
2016-06-21 10:16 ` [PATCH 1/3] xen/arm: drivers: scif: Remove dead code Oleksandr Tyshchenko
2016-06-21 12:15 ` Julien Grall
2016-06-21 12:54 ` Oleksandr Tyshchenko
2016-06-21 13:01 ` Dirk Behme
2016-06-21 13:22 ` Oleksandr Tyshchenko
2016-06-21 13:07 ` Julien Grall
2016-06-21 13:11 ` Oleksandr Tyshchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJEb2DFSw=+FB2z_QE0oa6XqLWMa0Zhq8DvjcEVtXHQ=dZ5UJg@mail.gmail.com' \
--to=oleksandr.tyshchenko@globallogic.com \
--cc=dirk.behme@de.bosch.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).