From: "Sahita, Ravi" <ravi.sahita@intel.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"tim@xen.org" <tim@xen.org>,
"White, Edmund H" <edmund.h.white@intel.com>,
Jan Beulich <JBeulich@suse.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: Regression in guest destruction caused by altp2m
Date: Wed, 29 Jul 2015 16:41:29 +0000 [thread overview]
Message-ID: <DBC12B0F5509554280826E40BCDEE8BE54FECE56@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <20150729100330.GV5111@zion.uk.xensource.com>
>From: Wei Liu [mailto:wei.liu2@citrix.com]
>Sent: Wednesday, July 29, 2015 3:04 AM
>
>On Mon, Jul 27, 2015 at 11:26:36PM +0000, Sahita, Ravi wrote:
>[...]
>> >> This makes me think it doesn't matter if I do "xl destroy" or just
>> >> normal shutdown. And another test to normally shutdown guest
>> >> confirmed that.
>> >>
>> >> The machine I have is quite old and doesn't support EPT. The real
>> >> issues seems to be that you failed to properly disable that feature
>> >> for old machines.
>> >
>> >The altp2m feature is designed (and implemented) to be emulated on
>> >systems lacking hardware capabilities.
>> >
>> >As such, teardown is necessary even on older systems, but I would
>> >agree that there appears to be a bug.
>>
>> Yes -
>> the check for hvm_altp2m_supported() before altp2m_vcpu_destroy() was
>missing - will send a patch tonight.
>>
>
>Hi Ravi
>
>Any update on this? This is a blocker for the release. Please fix it as
>soon as possible.
>
Just posted it - Ravi
>Wei.
>
>> Ravi
>>
>>
>> >
>> >~Andrew
prev parent reply other threads:[~2015-07-29 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 15:18 Regression in guest destruction caused by altp2m Wei Liu
2015-07-27 18:09 ` Wei Liu
2015-07-27 23:21 ` Andrew Cooper
2015-07-27 23:26 ` Sahita, Ravi
2015-07-29 10:03 ` Wei Liu
2015-07-29 16:41 ` Sahita, Ravi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBC12B0F5509554280826E40BCDEE8BE54FECE56@ORSMSX104.amr.corp.intel.com \
--to=ravi.sahita@intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=edmund.h.white@intel.com \
--cc=george.dunlap@eu.citrix.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).