xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* drivers/net/xen-netfront.c bug report
@ 2016-04-30  9:18 David Binderman
  0 siblings, 0 replies; only message in thread
From: David Binderman @ 2016-04-30  9:18 UTC (permalink / raw)
  To: boris.ostrovsky, david.vrabel, jgross, xen-devel

Hello there,

drivers/net/xen-netfront.c:1567]: (style) Redundant condition: feature_split_evtchn. '!feature_split_evtchn || (feature_split_evtchn && err)' is equivalent to '!feature_split_evtchn || err'

Source code is

   if (!feature_split_evtchn || (feature_split_evtchn && err))

Suggest new code

   if (!feature_split_evtchn || err)

Also:

drivers/net/xen-netfront.c:2116]: (style) Variable 'target' is assigned a value that is never used.


Regards

David Binderman
 		 	   		  
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-30  9:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-30  9:18 drivers/net/xen-netfront.c bug report David Binderman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).