xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: osstest service owner <osstest-admin@xenproject.org>
To: xen-devel@lists.xenproject.org, osstest-admin@xenproject.org
Subject: [xen-unstable-smoke bisection] complete build-amd64
Date: Mon, 16 Aug 2021 23:23:11 +0000	[thread overview]
Message-ID: <E1mFlwl-0006Js-JN@osstest.test-lab.xenproject.org> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 9333 bytes --]

branch xen-unstable-smoke
xenbranch xen-unstable-smoke
job build-amd64
testid xen-build

Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  35727551c0703493a2240e967cffc3063b13d49c
  Bug not present: bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164220/


  commit 35727551c0703493a2240e967cffc3063b13d49c
  Author: Andrew Cooper <andrew.cooper3@citrix.com>
  Date:   Thu Aug 12 17:39:16 2021 +0100
  
      x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}
      
      This was a clear oversight in the original CET work.  The BUGFRAME_run_fn and
      BUGFRAME_warn paths update regs->rip without an equivalent adjustment to the
      shadow stack, causing IRET to suffer #CP because of the mismatch.
      
      One subtle, and therefore fragile, aspect of extable_shstk_fixup() was that it
      required regs->rip to have its old value as a cross-check that the right word
      in the shadow stack was being edited.
      
      Rework extable_shstk_fixup() into fixup_exception_return() which takes
      ownership of the update to both the regular and shadow stacks, ensuring that
      the regs->rip update is ordered correctly.
      
      Use the new fixup_exception_return() for BUGFRAME_run_fn and BUGFRAME_warn to
      ensure that the shadow stack is updated too.
      
      Fixes: 209fb9919b50 ("x86/extable: Adjust extable handling to be shadow stack compatible")
      Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
      Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
      Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>


For bisection revision-tuple graph see:
   http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-amd64.xen-build.html
Revision IDs in each graph node refer, respectively, to the Trees above.

----------------------------------------
Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-amd64.xen-build --summary-out=tmp/164220.bisection-summary --basis-template=164206 --blessings=real,real-bisect,real-retry xen-unstable-smoke build-amd64 xen-build
Searching for failure / basis pass:
 164207 fail [host=himrod1] / 164206 ok.
Failure / basis pass flights: 164207 / 164206
(tree with no url: minios)
(tree with no url: ovmf)
(tree with no url: seabios)
Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
Tree: qemuu git://xenbits.xen.org/qemu-xen.git
Tree: xen git://xenbits.xen.org/xen.git
Latest 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
Basis pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 274c5e79c792ce0331d0d8cd9a01545dea5a48fd
Generating revisions with ./adhoc-revtuple-generator  git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823-136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 git://xenbits.xen.org/xen.git#274c5e79c792ce0331d0d8cd9a01545dea5a48fd-35727551c0703493a2240e967cffc3063b13d49c
Loaded 5001 nodes in revision graph
Searching for test results:
 164206 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 274c5e79c792ce0331d0d8cd9a01545dea5a48fd
 164207 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
 164209 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 274c5e79c792ce0331d0d8cd9a01545dea5a48fd
 164210 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
 164212 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 6928bc511399fd8f593fe49a3241212860a6a1b5
 164213 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
 164215 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
 164216 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
 164217 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
 164218 pass 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
 164220 fail 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 35727551c0703493a2240e967cffc3063b13d49c
Searching for interesting versions
 Result found: flight 164206 (pass), for basis pass
 For basis failure, parent search stopping at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b, results HASH(0x5562743e7900) HASH(0x5562743ea830) HASH(0x556273169110) For basis failure, parent search stopping at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 6928bc511399fd8f593fe49a3241212860a6a1b5, results HASH(0x5562743e58f8) For basis failure, parent search stopping at 3d273dd05e51e5a1\
 ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 274c5e79c792ce0331d0d8cd9a01545dea5a48fd, results HASH(0x5562743dcb08) HASH(0x5562743d37d0) Result found: flight 164207 (fail), for basis failure (at ancestor ~673)
 Repro found: flight 164209 (pass), for basis pass
 Repro found: flight 164210 (fail), for basis failure
 0 revisions at 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 136c34c9bc4179dc64b15b2bb5f0c54ca4ddf823 bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
No revisions left to test, checking graph state.
 Result found: flight 164213 (pass), for last pass
 Result found: flight 164215 (fail), for first failure
 Repro found: flight 164216 (pass), for last pass
 Repro found: flight 164217 (fail), for first failure
 Repro found: flight 164218 (pass), for last pass
 Repro found: flight 164220 (fail), for first failure

*** Found and reproduced problem changeset ***

  Bug is in tree:  xen git://xenbits.xen.org/xen.git
  Bug introduced:  35727551c0703493a2240e967cffc3063b13d49c
  Bug not present: bc141e8ca56200bdd0a12e04a6ebff3c19d6c27b
  Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/164220/


  commit 35727551c0703493a2240e967cffc3063b13d49c
  Author: Andrew Cooper <andrew.cooper3@citrix.com>
  Date:   Thu Aug 12 17:39:16 2021 +0100
  
      x86/cet: Fix shskt manipulation error with BUGFRAME_{warn,run_fn}
      
      This was a clear oversight in the original CET work.  The BUGFRAME_run_fn and
      BUGFRAME_warn paths update regs->rip without an equivalent adjustment to the
      shadow stack, causing IRET to suffer #CP because of the mismatch.
      
      One subtle, and therefore fragile, aspect of extable_shstk_fixup() was that it
      required regs->rip to have its old value as a cross-check that the right word
      in the shadow stack was being edited.
      
      Rework extable_shstk_fixup() into fixup_exception_return() which takes
      ownership of the update to both the regular and shadow stacks, ensuring that
      the regs->rip update is ordered correctly.
      
      Use the new fixup_exception_return() for BUGFRAME_run_fn and BUGFRAME_warn to
      ensure that the shadow stack is updated too.
      
      Fixes: 209fb9919b50 ("x86/extable: Adjust extable handling to be shadow stack compatible")
      Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
      Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
      Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
      Reviewed-by: Jan Beulich <jbeulich@suse.com>

Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-amd64.xen-build.{dot,ps,png,html,svg}.
----------------------------------------
164220: tolerable ALL FAIL

flight 164220 xen-unstable-smoke real-bisect [real]
http://logs.test-lab.xenproject.org/osstest/logs/164220/

Failures :-/ but no regressions.

Tests which did not succeed,
including tests which could not be run:
 build-amd64                   6 xen-build               fail baseline untested


jobs:
 build-amd64                                                  fail    


------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/logs/logs
images: /home/logs/images

Logs, config files, etc. are available at
    http://logs.test-lab.xenproject.org/osstest/logs

Explanation of these reports, and of osstest in general, is at
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
    http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master

Test harness code can be found at
    http://xenbits.xen.org/gitweb?p=osstest.git;a=summary



             reply	other threads:[~2021-08-16 23:23 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-16 23:23 osstest service owner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-11-28 17:02 [xen-unstable-smoke bisection] complete build-amd64 osstest service owner
2023-09-06 16:46 osstest service owner
2023-06-07 16:24 osstest service owner
2023-03-24 22:28 osstest service owner
2022-10-16  8:24 osstest service owner
2022-03-15  2:25 osstest service owner
2022-01-21  3:38 osstest service owner
2022-01-21  7:54 ` Jan Beulich
2021-07-10  0:19 osstest service owner
2021-07-06 17:29 osstest service owner
2021-02-24 16:57 osstest service owner
2021-02-10 19:10 osstest service owner
2021-01-28 18:38 osstest service owner
2020-12-21 20:07 osstest service owner
2020-11-10 23:25 osstest service owner
2020-10-23 23:30 osstest service owner
2020-10-07 18:40 osstest service owner
2020-04-25  8:57 osstest service owner
2019-05-15  8:13 osstest service owner
2019-04-13  5:09 osstest service owner
2019-04-13 15:51 ` Julien Grall
2019-04-13 15:53   ` Andrew Cooper
2019-01-02 21:14 osstest service owner
2018-11-12 23:38 osstest service owner
2018-09-25 21:39 osstest service owner
2018-04-07  6:19 osstest service owner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1mFlwl-0006Js-JN@osstest.test-lab.xenproject.org \
    --to=osstest-admin@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).