xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: osstest service owner <osstest-admin@xenproject.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [xen-unstable-smoke bisection] complete build-amd64
Date: Fri, 21 Jan 2022 08:54:20 +0100	[thread overview]
Message-ID: <b6804ecd-84d2-6c2b-3172-af3a4a3b5c2a@suse.com> (raw)
In-Reply-To: <E1nAklO-0000wM-3M@osstest.test-lab.xenproject.org>

On 21.01.2022 04:38, osstest service owner wrote:
> branch xen-unstable-smoke
> xenbranch xen-unstable-smoke
> job build-amd64
> testid xen-build
> 
> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git
> Tree: qemuu git://xenbits.xen.org/qemu-xen.git
> Tree: xen git://xenbits.xen.org/xen.git
> 
> *** Found and reproduced problem changeset ***
> 
>   Bug is in tree:  xen git://xenbits.xen.org/xen.git
>   Bug introduced:  6536688439dbca1d08fd6db5be29c39e3917fb2f
>   Bug not present: 88d3ff7ab15da277a85b39735797293fb541c718
>   Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/167778/
> 
> 
>   commit 6536688439dbca1d08fd6db5be29c39e3917fb2f
>   Author: Andrew Cooper <andrew.cooper3@citrix.com>
>   Date:   Wed Jan 12 13:52:47 2022 +0000
>   
>       x86/msr: Split MSR_SPEC_CTRL handling
>       
>       In order to fix a VT-x bug, and support MSR_SPEC_CTRL on AMD, move
>       MSR_SPEC_CTRL handling into the new {pv,hvm}_{get,set}_reg() infrastructure.
>       
>       Duplicate the msrs->spec_ctrl.raw accesses in the PV and VT-x paths for now.
>       The SVM path is currently unreachable because of the CPUID policy.
>       
>       No functional change.
>       
>       Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>       Reviewed-by: Jan Beulich <jbeulich@suse.com>

Hmm, looks like you decided to drop the inline stubs, yet now in the
shim build we get

msr.c: In function 'guest_rdmsr':
msr.c:431:16: error: implicit declaration of function 'hvm_get_reg'; did you mean 'pv_get_reg'? [-Werror=implicit-function-declaration]
         *val = hvm_get_reg(v, msr);
                ^~~~~~~~~~~
                pv_get_reg
msr.c:431:16: error: nested extern declaration of 'hvm_get_reg' [-Werror=nested-externs]
msr.c: In function 'guest_wrmsr':
msr.c:675:9: error: implicit declaration of function 'hvm_set_reg'; did you mean 'pv_set_reg'? [-Werror=implicit-function-declaration]
         hvm_set_reg(v, msr, val);
         ^~~~~~~~~~~
         pv_set_reg
msr.c:675:9: error: nested extern declaration of 'hvm_set_reg' [-Werror=nested-externs]
cc1: all warnings being treated as errors

Jan



  reply	other threads:[~2022-01-21  7:54 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-21  3:38 [xen-unstable-smoke bisection] complete build-amd64 osstest service owner
2022-01-21  7:54 ` Jan Beulich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-11-28 17:02 osstest service owner
2023-09-06 16:46 osstest service owner
2023-06-07 16:24 osstest service owner
2023-03-24 22:28 osstest service owner
2022-10-16  8:24 osstest service owner
2022-03-15  2:25 osstest service owner
2021-08-16 23:23 osstest service owner
2021-07-10  0:19 osstest service owner
2021-07-06 17:29 osstest service owner
2021-02-24 16:57 osstest service owner
2021-02-10 19:10 osstest service owner
2021-01-28 18:38 osstest service owner
2020-12-21 20:07 osstest service owner
2020-11-10 23:25 osstest service owner
2020-10-23 23:30 osstest service owner
2020-10-07 18:40 osstest service owner
2020-04-25  8:57 osstest service owner
2019-05-15  8:13 osstest service owner
2019-04-13  5:09 osstest service owner
2019-04-13 15:51 ` Julien Grall
2019-04-13 15:53   ` Andrew Cooper
2019-01-02 21:14 osstest service owner
2018-11-12 23:38 osstest service owner
2018-09-25 21:39 osstest service owner
2018-04-07  6:19 osstest service owner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6804ecd-84d2-6c2b-3172-af3a4a3b5c2a@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=osstest-admin@xenproject.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).