From: Penny Zheng <Penny.Zheng@arm.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
Wei Chen <Wei.Chen@arm.com>, nd <nd@arm.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"julien@xen.org" <julien@xen.org>
Subject: RE: [PATCH 08/10] xen/arm: introduce reserved_page_list
Date: Tue, 18 May 2021 08:38:32 +0000 [thread overview]
Message-ID: <VE1PR08MB521538CF7B0BFED3007E5D8DF72C9@VE1PR08MB5215.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <97bc6ca6-206b-197f-de08-20691578b9db@suse.com>
Hi Jan
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Tuesday, May 18, 2021 3:39 PM
> To: Penny Zheng <Penny.Zheng@arm.com>
> Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>; Wei Chen
> <Wei.Chen@arm.com>; nd <nd@arm.com>; xen-devel@lists.xenproject.org;
> sstabellini@kernel.org; julien@xen.org
> Subject: Re: [PATCH 08/10] xen/arm: introduce reserved_page_list
>
> On 18.05.2021 07:21, Penny Zheng wrote:
> > Since page_list under struct domain refers to linked pages as gueast
> > RAM allocated from heap, it should not include reserved pages of static
> memory.
> >
> > The number of PGC_reserved pages assigned to a domain is tracked in a
> > new 'reserved_pages' counter. Also introduce a new reserved_page_list
> > to link pages of static memory. Let page_to_list return
> > reserved_page_list, when flag is PGC_reserved.
> >
> > Later, when domain get destroyed or restarted, those new values will
> > help relinquish memory to proper place, not been given back to heap.
> >
> > Signed-off-by: Penny Zheng <penny.zheng@arm.com>
> > ---
> > xen/common/domain.c | 1 +
> > xen/common/page_alloc.c | 7 +++++--
> > xen/include/xen/sched.h | 5 +++++
> > 3 files changed, 11 insertions(+), 2 deletions(-)
>
> This contradicts the title's prefix: There's no Arm-specific change here at all.
> But imo the title is correct, and the changes should be Arm-specific. There's
> no point having struct domain fields on e.g. x86 which aren't used there at all.
>
Yep, you're right.
I'll add ifdefs in the following changes.
> > --- a/xen/common/page_alloc.c
> > +++ b/xen/common/page_alloc.c
> > @@ -2410,7 +2410,7 @@ int assign_pages(
> >
> > for ( i = 0; i < nr_pfns; i++ )
> > {
> > - ASSERT(!(pg[i].count_info & ~PGC_extra));
> > + ASSERT(!(pg[i].count_info & ~(PGC_extra |
> > + PGC_reserved)));
> > if ( pg[i].count_info & PGC_extra )
> > extra_pages++;
> > }
> > @@ -2439,6 +2439,9 @@ int assign_pages(
> > }
> > }
> >
> > + if ( pg[0].count_info & PGC_reserved )
> > + d->reserved_pages += nr_pfns;
>
> I guess this again will fail to build on x86.
>
> > @@ -588,6 +590,9 @@ static inline struct page_list_head *page_to_list(
> > if ( pg->count_info & PGC_extra )
> > return &d->extra_page_list;
> >
> > + if ( pg->count_info & PGC_reserved )
> > + return &d->reserved_page_list;
>
> Same here.
>
> Jan
Thanks
Penny
next prev parent reply other threads:[~2021-05-18 8:39 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 5:21 [PATCH 00/10] Domain on Static Allocation Penny Zheng
2021-05-18 5:21 ` [PATCH 01/10] xen/arm: introduce domain " Penny Zheng
2021-05-18 8:58 ` Julien Grall
2021-05-19 2:22 ` Penny Zheng
2021-05-19 18:27 ` Julien Grall
2021-05-20 6:07 ` Penny Zheng
2021-05-20 8:50 ` Julien Grall
2021-06-02 10:09 ` Penny Zheng
2021-06-03 9:09 ` Julien Grall
2021-06-03 21:32 ` Stefano Stabellini
2021-06-03 22:07 ` Julien Grall
2021-06-03 23:55 ` Stefano Stabellini
2021-06-04 4:00 ` Penny Zheng
2021-06-05 2:00 ` Stefano Stabellini
2021-06-07 18:09 ` Julien Grall
2021-06-09 9:56 ` Bertrand Marquis
2021-06-09 10:47 ` Julien Grall
2021-06-15 6:08 ` Penny Zheng
2021-06-17 11:22 ` Julien Grall
2021-05-18 5:21 ` [PATCH 02/10] xen/arm: handle static memory in dt_unreserved_regions Penny Zheng
2021-05-18 9:04 ` Julien Grall
2021-05-18 5:21 ` [PATCH 03/10] xen/arm: introduce PGC_reserved Penny Zheng
2021-05-18 9:45 ` Julien Grall
2021-05-19 3:16 ` Penny Zheng
2021-05-19 9:49 ` Jan Beulich
2021-05-19 19:49 ` Julien Grall
2021-05-20 7:05 ` Jan Beulich
2021-05-19 19:46 ` Julien Grall
2021-05-20 6:19 ` Penny Zheng
2021-05-20 8:40 ` Penny Zheng
2021-05-20 8:59 ` Julien Grall
2021-05-20 9:27 ` Jan Beulich
2021-05-20 9:45 ` Julien Grall
2021-05-18 5:21 ` [PATCH 04/10] xen/arm: static memory initialization Penny Zheng
2021-05-18 7:15 ` Jan Beulich
2021-05-18 9:51 ` Penny Zheng
2021-05-18 10:43 ` Jan Beulich
2021-05-20 9:04 ` Penny Zheng
2021-05-20 9:32 ` Jan Beulich
2021-05-18 10:00 ` Julien Grall
2021-05-18 10:01 ` Julien Grall
2021-05-19 5:02 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 05/10] xen/arm: introduce alloc_staticmem_pages Penny Zheng
2021-05-18 7:24 ` Jan Beulich
2021-05-18 9:30 ` Penny Zheng
2021-05-18 10:09 ` Julien Grall
2021-05-18 10:15 ` Julien Grall
2021-05-19 5:23 ` Penny Zheng
2021-05-24 10:10 ` Penny Zheng
2021-05-24 10:24 ` Julien Grall
2021-05-18 5:21 ` [PATCH 06/10] xen: replace order with nr_pfns in assign_pages for better compatibility Penny Zheng
2021-05-18 7:27 ` Jan Beulich
2021-05-18 9:11 ` Penny Zheng
2021-05-18 10:20 ` Julien Grall
2021-05-19 5:35 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 07/10] xen/arm: intruduce alloc_domstatic_pages Penny Zheng
2021-05-18 7:34 ` Jan Beulich
2021-05-18 8:57 ` Penny Zheng
2021-05-18 11:23 ` Jan Beulich
2021-05-21 6:41 ` Penny Zheng
2021-05-21 7:09 ` Jan Beulich
2021-06-03 2:44 ` Penny Zheng
2021-05-18 12:13 ` Julien Grall
2021-05-19 7:52 ` Penny Zheng
2021-05-19 20:01 ` Julien Grall
2021-05-18 10:30 ` Julien Grall
2021-05-19 6:03 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 08/10] xen/arm: introduce reserved_page_list Penny Zheng
2021-05-18 7:39 ` Jan Beulich
2021-05-18 8:38 ` Penny Zheng [this message]
2021-05-18 11:24 ` Jan Beulich
2021-05-19 6:46 ` Penny Zheng
2021-05-18 11:02 ` Julien Grall
2021-05-19 6:43 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 09/10] xen/arm: parse `xen,static-mem` info during domain construction Penny Zheng
2021-05-18 12:09 ` Julien Grall
2021-05-19 7:58 ` Penny Zheng
2021-05-18 5:21 ` [PATCH 10/10] xen/arm: introduce allocate_static_memory Penny Zheng
2021-05-18 12:05 ` Julien Grall
2021-05-19 7:27 ` Penny Zheng
2021-05-19 20:10 ` Julien Grall
2021-05-20 6:29 ` Penny Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR08MB521538CF7B0BFED3007E5D8DF72C9@VE1PR08MB5215.eurprd08.prod.outlook.com \
--to=penny.zheng@arm.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Wei.Chen@arm.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=nd@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).