From: Jan Beulich <jbeulich@suse.com>
To: Jason Andryuk <jandryuk@gmail.com>
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 05/13] xenpm: Change get-cpufreq-para output for internal
Date: Wed, 26 May 2021 17:21:17 +0200 [thread overview]
Message-ID: <a8180fa6-9b7d-52cd-c055-71ca28b08325@suse.com> (raw)
In-Reply-To: <20210503192810.36084-6-jandryuk@gmail.com>
On 03.05.2021 21:28, Jason Andryuk wrote:
> --- a/tools/misc/xenpm.c
> +++ b/tools/misc/xenpm.c
> @@ -711,6 +711,7 @@ void start_gather_func(int argc, char *argv[])
> /* print out parameters about cpu frequency */
> static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq)
> {
> + bool internal = strstr(p_cpufreq->scaling_governor, "internal");
Like suggested for the hypervisor, perhaps better check for names
ending in "-internal"?
> @@ -720,10 +721,19 @@ static void print_cpufreq_para(int cpuid, struct xc_get_cpufreq_para *p_cpufreq)
> printf(" %d", p_cpufreq->affected_cpus[i]);
> printf("\n");
>
> - printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> - p_cpufreq->cpuinfo_max_freq,
> - p_cpufreq->cpuinfo_min_freq,
> - p_cpufreq->cpuinfo_cur_freq);
> + if ( internal )
> + {
> + printf("cpuinfo frequency : base [%u] turbo [%u]\n",
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_max_freq);
> + }
> + else
> + {
> + printf("cpuinfo frequency : max [%u] min [%u] cur [%u]\n",
> + p_cpufreq->cpuinfo_max_freq,
> + p_cpufreq->cpuinfo_min_freq,
> + p_cpufreq->cpuinfo_cur_freq);
> + }
Since the file adopts hypervisor coding style, the unnecessary
braces would again better be omitted.
Jan
next prev parent reply other threads:[~2021-05-26 15:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 19:27 [PATCH 00/13] Intel Hardware P-States (HWP) support Jason Andryuk
2021-05-03 19:27 ` [PATCH 01/13] cpufreq: Allow restricting to internal governors only Jason Andryuk
2021-05-26 13:18 ` Jan Beulich
2021-05-26 14:12 ` Jason Andryuk
2021-05-26 15:09 ` Jan Beulich
2021-05-26 16:44 ` Jason Andryuk
2021-05-03 19:27 ` [PATCH 02/13] cpufreq: Add perf_freq to cpuinfo Jason Andryuk
2021-05-26 13:24 ` Jan Beulich
2021-05-26 14:19 ` Jason Andryuk
2021-05-03 19:28 ` [PATCH 03/13] cpufreq: Export intel_feature_detect Jason Andryuk
2021-05-26 13:27 ` Jan Beulich
2021-05-26 14:44 ` Jason Andryuk
2021-05-26 15:11 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 04/13] cpufreq: Add Hardware P-State (HWP) driver Jason Andryuk
2021-05-26 14:59 ` Jan Beulich
2021-05-27 7:23 ` Jan Beulich
2021-05-27 18:50 ` Jason Andryuk
2021-05-28 6:35 ` Jan Beulich
2021-06-03 11:55 ` Jason Andryuk
2021-06-04 6:39 ` Jan Beulich
2021-05-27 7:45 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 05/13] xenpm: Change get-cpufreq-para output for internal Jason Andryuk
2021-05-26 15:21 ` Jan Beulich [this message]
2021-05-27 5:54 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 06/13] cpufreq: Export HWP parameters to userspace Jason Andryuk
2021-05-27 7:55 ` Jan Beulich
2021-05-28 13:19 ` Jason Andryuk
2021-05-28 13:39 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 07/13] libxc: Include hwp_para in definitions Jason Andryuk
2021-05-03 19:28 ` [PATCH 08/13] xenpm: Print HWP parameters Jason Andryuk
2021-05-27 8:02 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 09/13] xen: Add SET_CPUFREQ_HWP xen_sysctl_pm_op Jason Andryuk
2021-05-27 8:33 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 10/13] libxc: Add xc_set_cpufreq_hwp Jason Andryuk
2021-05-04 8:03 ` Jan Beulich
2021-05-04 11:31 ` Jason Andryuk
2021-05-27 9:45 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 11/13] xenpm: Factor out a non-fatal cpuid_parse variant Jason Andryuk
2021-05-27 8:41 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 12/13] xenpm: Add set-cpufreq-hwp subcommand Jason Andryuk
2021-05-27 9:46 ` Jan Beulich
2021-05-03 19:28 ` [PATCH 13/13] CHANGELOG: Add Intel HWP entry Jason Andryuk
2021-05-27 9:48 ` Jan Beulich
2021-05-20 14:57 ` [PATCH 00/13] Intel Hardware P-States (HWP) support Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8180fa6-9b7d-52cd-c055-71ca28b08325@suse.com \
--to=jbeulich@suse.com \
--cc=iwj@xenproject.org \
--cc=jandryuk@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).