xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
	ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com,
	jbeulich@suse.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs;
Date: Fri, 12 Feb 2016 11:37:37 +0000	[thread overview]
Message-ID: <alpine.DEB.2.02.1602121133560.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <1455246507-5589-2-git-send-email-konrad.wilk@oracle.com>

On Thu, 11 Feb 2016, Konrad Rzeszutek Wilk wrote:
> in the keyhandler.h file. Otherwise on ARM builds if we
> just use the keyhandler file - the compile will fail.
> 
> CC: ian.campbell@citrix.com
> CC: wei.liu2@citrix.com
> CC: stefano.stabellini@citrix.com
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
>  xen/include/xen/keyhandler.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/include/xen/keyhandler.h b/xen/include/xen/keyhandler.h
> index 06c05c8..e361558 100644
> --- a/xen/include/xen/keyhandler.h
> +++ b/xen/include/xen/keyhandler.h
> @@ -19,6 +19,7 @@
>   */
>  typedef void (keyhandler_fn_t)(unsigned char key);
>  
> +struct cpu_user_regs;
>  /*
>   * Callback type for irq_keyhandler.
>   *

I think that the right fix would be to #include <asm/processor.h>.

  parent reply	other threads:[~2016-02-12 11:38 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-12  3:08 [PATCH v3] Requisite paches for xSplice v3 (not yet posted) Konrad Rzeszutek Wilk
2016-02-12  3:08 ` [PATCH v3 1/5] hypervisor/arm/keyhandler: Declare struct cpu_user_regs; Konrad Rzeszutek Wilk
2016-02-12  8:51   ` Jan Beulich
2016-02-12 14:06     ` Konrad Rzeszutek Wilk
2016-02-12 14:54       ` Jan Beulich
2016-02-12 11:37   ` Stefano Stabellini [this message]
2016-02-12 12:20     ` Jan Beulich
2016-02-12 12:46       ` Stefano Stabellini
2016-02-12 14:53         ` Jan Beulich
2016-02-12  3:08 ` [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively Konrad Rzeszutek Wilk
2016-02-12 11:26   ` Stefano Stabellini
2016-02-12 14:17     ` Konrad Rzeszutek Wilk
2016-02-12 15:04       ` Jan Beulich
2016-02-12 15:26         ` Stefano Stabellini
2016-02-12 15:56           ` Konrad Rzeszutek Wilk
2016-02-12 15:57             ` Stefano Stabellini
2016-02-12 17:50               ` Konrad Rzeszutek Wilk
2016-03-16 17:32             ` Julien Grall
2016-03-16 17:52               ` Konrad Rzeszutek Wilk
2016-03-16 18:08                 ` Julien Grall
2016-03-16 19:21                   ` Konrad Rzeszutek Wilk
2016-03-17  1:16                     ` Konrad Rzeszutek Wilk
2016-03-17 11:04                       ` Julien Grall
2016-03-17 18:52                         ` Konrad Rzeszutek Wilk
2016-02-12  3:08 ` [PATCH v3 3/5] build: remove .config from /boot when uninstalling Konrad Rzeszutek Wilk
2016-02-12 14:11   ` Doug Goldstein
2016-02-12  3:08 ` [PATCH v3 4/5] mkelf32: Remove the 32-bit hypervisor support Konrad Rzeszutek Wilk
2016-02-12  3:08 ` [PATCH v3 5/5] mkelf32: Close those file descriptors in the error paths Konrad Rzeszutek Wilk
2016-02-18 16:29   ` Jan Beulich
2016-02-18 16:39     ` Ian Jackson
2016-02-18 16:45       ` Jan Beulich
2016-02-18 21:12         ` Konrad Rzeszutek Wilk
2016-02-19 11:39           ` Jan Beulich
2016-02-19 11:42           ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1602121133560.27008@kaball.uk.xensource.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).