* [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok
@ 2017-05-23 17:03 Julien Grall
2017-05-23 18:26 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-05-23 17:03 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, sstabellini
Both helpers access_ok and array_access_ok are not used on ARM. Remove
them.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
xen/include/asm-arm/guest_access.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h
index 421bca5f36..251e935597 100644
--- a/xen/include/asm-arm/guest_access.h
+++ b/xen/include/asm-arm/guest_access.h
@@ -4,13 +4,6 @@
#include <xen/guest_access.h>
#include <xen/errno.h>
-/* Guests have their own comlete address space */
-#define access_ok(addr,size) (1)
-
-#define array_access_ok(addr,count,size) \
- (likely((count) < (~0UL / (size))) && \
- access_ok(addr, 0 + (count) * (size)))
-
unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len);
unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from,
unsigned len);
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok
2017-05-23 17:03 [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok Julien Grall
@ 2017-05-23 18:26 ` Stefano Stabellini
2017-06-06 16:20 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2017-05-23 18:26 UTC (permalink / raw)
To: Julien Grall; +Cc: sstabellini, xen-devel
On Tue, 23 May 2017, Julien Grall wrote:
> Both helpers access_ok and array_access_ok are not used on ARM. Remove
> them.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/include/asm-arm/guest_access.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h
> index 421bca5f36..251e935597 100644
> --- a/xen/include/asm-arm/guest_access.h
> +++ b/xen/include/asm-arm/guest_access.h
> @@ -4,13 +4,6 @@
> #include <xen/guest_access.h>
> #include <xen/errno.h>
>
> -/* Guests have their own comlete address space */
> -#define access_ok(addr,size) (1)
> -
> -#define array_access_ok(addr,count,size) \
> - (likely((count) < (~0UL / (size))) && \
> - access_ok(addr, 0 + (count) * (size)))
> -
> unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len);
> unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from,
> unsigned len);
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok
2017-05-23 18:26 ` Stefano Stabellini
@ 2017-06-06 16:20 ` Julien Grall
2017-06-06 18:53 ` Stefano Stabellini
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-06-06 16:20 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: xen-devel
Hi Stefano,
On 23/05/17 19:26, Stefano Stabellini wrote:
> On Tue, 23 May 2017, Julien Grall wrote:
>> Both helpers access_ok and array_access_ok are not used on ARM. Remove
>> them.
>>
>> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
I don't see this patch in staging. Can you please apply it?
Cheers,
>
>> ---
>> xen/include/asm-arm/guest_access.h | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/xen/include/asm-arm/guest_access.h b/xen/include/asm-arm/guest_access.h
>> index 421bca5f36..251e935597 100644
>> --- a/xen/include/asm-arm/guest_access.h
>> +++ b/xen/include/asm-arm/guest_access.h
>> @@ -4,13 +4,6 @@
>> #include <xen/guest_access.h>
>> #include <xen/errno.h>
>>
>> -/* Guests have their own comlete address space */
>> -#define access_ok(addr,size) (1)
>> -
>> -#define array_access_ok(addr,count,size) \
>> - (likely((count) < (~0UL / (size))) && \
>> - access_ok(addr, 0 + (count) * (size)))
>> -
>> unsigned long raw_copy_to_guest(void *to, const void *from, unsigned len);
>> unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from,
>> unsigned len);
>> --
>> 2.11.0
>>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok
2017-06-06 16:20 ` Julien Grall
@ 2017-06-06 18:53 ` Stefano Stabellini
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Stabellini @ 2017-06-06 18:53 UTC (permalink / raw)
To: Julien Grall; +Cc: Stefano Stabellini, xen-devel
On Tue, 6 Jun 2017, Julien Grall wrote:
> Hi Stefano,
>
> On 23/05/17 19:26, Stefano Stabellini wrote:
> > On Tue, 23 May 2017, Julien Grall wrote:
> > > Both helpers access_ok and array_access_ok are not used on ARM. Remove
> > > them.
> > >
> > > Signed-off-by: Julien Grall <julien.grall@arm.com>
> >
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
> I don't see this patch in staging. Can you please apply it?
Same here. It is committed now.
> >
> > > ---
> > > xen/include/asm-arm/guest_access.h | 7 -------
> > > 1 file changed, 7 deletions(-)
> > >
> > > diff --git a/xen/include/asm-arm/guest_access.h
> > > b/xen/include/asm-arm/guest_access.h
> > > index 421bca5f36..251e935597 100644
> > > --- a/xen/include/asm-arm/guest_access.h
> > > +++ b/xen/include/asm-arm/guest_access.h
> > > @@ -4,13 +4,6 @@
> > > #include <xen/guest_access.h>
> > > #include <xen/errno.h>
> > >
> > > -/* Guests have their own comlete address space */
> > > -#define access_ok(addr,size) (1)
> > > -
> > > -#define array_access_ok(addr,count,size) \
> > > - (likely((count) < (~0UL / (size))) && \
> > > - access_ok(addr, 0 + (count) * (size)))
> > > -
> > > unsigned long raw_copy_to_guest(void *to, const void *from, unsigned
> > > len);
> > > unsigned long raw_copy_to_guest_flush_dcache(void *to, const void *from,
> > > unsigned len);
> > > --
> > > 2.11.0
> > >
>
> --
> Julien Grall
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-06 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-23 17:03 [PATCH for-next] xen/arm: Remove unused helpers access_ok and array_access_ok Julien Grall
2017-05-23 18:26 ` Stefano Stabellini
2017-06-06 16:20 ` Julien Grall
2017-06-06 18:53 ` Stefano Stabellini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).