Re: [PATCH 05/14 v4] xen/arm: vpl011: Allocate a new GFN in the toolstack for vuart

[Stefano Stabellini <sstabellini@kernel.org>]

On Tue, 6 Jun 2017, Bhupinder Thakur wrote:
> Allocate a new gfn to be used as a ring buffer between xenconsole
> and Xen for sending/receiving pl011 console data.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
> ---
> CC: ij
> CC: wl
> CC: ss
> CC: jg
> 
> Changes since v3:
> - Added a new helper function xc_get_vuart_gfn() to return the GFN allocated for
>   vpl011.
> - Since a new function has been added in this patch, I have not included Stefano's
>   reviewed-by and Wei's acked-by tags.
> 
> Changes since v2:
> - Removed the DOMCTL call to set the GFN as now this information is passed
>   in the DOMCTL call to initialize vpl011 emulation.
> 
>  tools/libxc/include/xc_dom.h |  3 +++
>  tools/libxc/xc_dom_arm.c     | 12 +++++++++++-
>  tools/libxc/xc_dom_boot.c    |  2 ++
>  3 files changed, 16 insertions(+), 1 deletion(-)

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> diff --git a/tools/libxc/include/xc_dom.h b/tools/libxc/include/xc_dom.h
> index ce47058..1cde2b7 100644
> --- a/tools/libxc/include/xc_dom.h
> +++ b/tools/libxc/include/xc_dom.h
> @@ -216,6 +216,8 @@ struct xc_dom_image {
>  
>      /* Extra SMBIOS structures passed to HVMLOADER */
>      struct xc_hvm_firmware_module smbios_module;
> +
> +    xen_pfn_t vuart_gfn;
>  };
>  
>  /* --- pluggable kernel loader ------------------------------------- */
> @@ -334,6 +336,7 @@ int xc_dom_gnttab_seed(xc_interface *xch, domid_t domid,
>                         domid_t console_domid,
>                         domid_t xenstore_domid);
>  bool xc_dom_translated(const struct xc_dom_image *dom);
> +xen_pfn_t xc_get_vuart_gfn(void);
>  
>  /* --- debugging bits ---------------------------------------------- */
>  
> diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
> index e7d4bd0..89d0d37 100644
> --- a/tools/libxc/xc_dom_arm.c
> +++ b/tools/libxc/xc_dom_arm.c
> @@ -26,10 +26,11 @@
>  #include "xg_private.h"
>  #include "xc_dom.h"
>  
> -#define NR_MAGIC_PAGES 3
> +#define NR_MAGIC_PAGES 4
>  #define CONSOLE_PFN_OFFSET 0
>  #define XENSTORE_PFN_OFFSET 1
>  #define MEMACCESS_PFN_OFFSET 2
> +#define VUART_PFN_OFFSET 3
>  
>  #define LPAE_SHIFT 9
>  
> @@ -64,6 +65,13 @@ static int setup_pgtables_arm(struct xc_dom_image *dom)
>  
>  /* ------------------------------------------------------------------------ */
>  
> +xen_pfn_t xc_get_vuart_gfn()
> +{
> +    const xen_pfn_t base = GUEST_MAGIC_BASE >> XC_PAGE_SHIFT;
> +
> +    return base + VUART_PFN_OFFSET;
> +}
> +
>  static int alloc_magic_pages(struct xc_dom_image *dom)
>  {
>      int rc, i;
> @@ -85,10 +93,12 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
>  
>      dom->console_pfn = base + CONSOLE_PFN_OFFSET;
>      dom->xenstore_pfn = base + XENSTORE_PFN_OFFSET;
> +    dom->vuart_gfn = base + VUART_PFN_OFFSET;
>  
>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
>      xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
>      xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET);
> +    xc_clear_domain_page(dom->xch, dom->guest_domid, base + VUART_PFN_OFFSET);
>      xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
>              dom->console_pfn);
>      xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_STORE_PFN,
> diff --git a/tools/libxc/xc_dom_boot.c b/tools/libxc/xc_dom_boot.c
> index c3b44dd..8a376d0 100644
> --- a/tools/libxc/xc_dom_boot.c
> +++ b/tools/libxc/xc_dom_boot.c
> @@ -226,6 +226,8 @@ int xc_dom_boot_image(struct xc_dom_image *dom)
>          return rc;
>      if ( (rc = clear_page(dom, dom->xenstore_pfn)) != 0 )
>          return rc;
> +    if ( (rc = clear_page(dom, dom->vuart_gfn)) != 0 )
> +        return rc;
>  
>      /* start info page */
>      if ( dom->arch_hooks->start_info )
> -- 
> 2.7.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel