From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Andrii Anisov <andrii_anisov@epam.com>,
Oleksandr_Tyshchenko@epam.com
Subject: Re: [Xen-devel] [PATCH MM-PART3 v2 01/12] xen/arm: lpae: Add a macro to generate offsets from an address
Date: Tue, 11 Jun 2019 11:21:02 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1906111120290.13737@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20190514123125.29086-2-julien.grall@arm.com>
On Tue, 14 May 2019, Julien Grall wrote:
> There are few places requiring to generate offsets from an address.
> Rather than open-coding everywhere, we can introduce a macro to do the
> job for us.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
> Reviewed-by: Andrii Anisov <andrii_anisov@epam.com>
>
> ---
> Changes in v2:
> - Add Andrii's reviewed-by
> ---
> xen/arch/arm/p2m.c | 23 +++--------------------
> xen/include/asm-arm/lpae.h | 9 +++++++++
> 2 files changed, 12 insertions(+), 20 deletions(-)
>
> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> index 92c2413f20..06fa342a8f 100644
> --- a/xen/arch/arm/p2m.c
> +++ b/xen/arch/arm/p2m.c
> @@ -368,12 +368,7 @@ mfn_t p2m_get_entry(struct p2m_domain *p2m, gfn_t gfn,
> p2m_type_t _t;
>
> /* Convenience aliases */
I don't know if you want to keep this comment, we could get rid of it.
Either way:
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> - const unsigned int offsets[4] = {
> - zeroeth_table_offset(addr),
> - first_table_offset(addr),
> - second_table_offset(addr),
> - third_table_offset(addr)
> - };
> + DECLARE_OFFSETS(offsets, addr);
>
> ASSERT(p2m_is_locked(p2m));
> BUILD_BUG_ON(THIRD_MASK != PAGE_MASK);
> @@ -888,7 +883,6 @@ static int __p2m_set_entry(struct p2m_domain *p2m,
> p2m_type_t t,
> p2m_access_t a)
> {
> - paddr_t addr = gfn_to_gaddr(sgfn);
> unsigned int level = 0;
> unsigned int target = 3 - (page_order / LPAE_SHIFT);
> lpae_t *entry, *table, orig_pte;
> @@ -897,12 +891,7 @@ static int __p2m_set_entry(struct p2m_domain *p2m,
> bool removing_mapping = mfn_eq(smfn, INVALID_MFN);
>
> /* Convenience aliases */
> - const unsigned int offsets[4] = {
> - zeroeth_table_offset(addr),
> - first_table_offset(addr),
> - second_table_offset(addr),
> - third_table_offset(addr)
> - };
> + DECLARE_OFFSETS(offsets, gfn_to_gaddr(sgfn));
>
> ASSERT(p2m_is_write_locked(p2m));
>
> @@ -1199,15 +1188,9 @@ bool p2m_resolve_translation_fault(struct domain *d, gfn_t gfn)
> unsigned int level = 0;
> bool resolved = false;
> lpae_t entry, *table;
> - paddr_t addr = gfn_to_gaddr(gfn);
>
> /* Convenience aliases */
> - const unsigned int offsets[4] = {
> - zeroeth_table_offset(addr),
> - first_table_offset(addr),
> - second_table_offset(addr),
> - third_table_offset(addr)
> - };
> + DECLARE_OFFSETS(offsets, gfn_to_gaddr(gfn));
>
> p2m_write_lock(p2m);
>
> diff --git a/xen/include/asm-arm/lpae.h b/xen/include/asm-arm/lpae.h
> index 545b0c8f24..c22780f8f3 100644
> --- a/xen/include/asm-arm/lpae.h
> +++ b/xen/include/asm-arm/lpae.h
> @@ -218,6 +218,15 @@ TABLE_OFFSET_HELPERS(64);
> #undef TABLE_OFFSET
> #undef TABLE_OFFSET_HELPERS
>
> +/* Generate an array @var containing the offset for each level from @addr */
> +#define DECLARE_OFFSETS(var, addr) \
> + const unsigned int var[4] = { \
> + zeroeth_table_offset(addr), \
> + first_table_offset(addr), \
> + second_table_offset(addr), \
> + third_table_offset(addr) \
> + }
> +
> #endif /* __ASSEMBLY__ */
>
> /*
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-11 18:21 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 12:31 [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 01/12] xen/arm: lpae: Add a macro to generate offsets from an address Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:21 ` Stefano Stabellini [this message]
2019-06-11 18:27 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 02/12] xen/arm: mm: Rename create_xen_entries() to xen_pt_update() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:23 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 03/12] xen/arm: mm: Move out of xen_pt_update() the logic to update an entry Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:29 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 18:37 ` Stefano Stabellini
2019-06-11 19:56 ` [Xen-devel] Checking INVALID_MFN in mfn_add (WAS: Re: [PATCH MM-PART3 v2 04/12] xen/arm: mm: Only increment mfn when valid in xen_pt_update) Julien Grall
2019-06-11 20:24 ` Andrew Cooper
2019-06-12 12:47 ` Julien Grall
2019-06-12 15:57 ` Stefano Stabellini
2019-06-12 7:53 ` Jan Beulich
2019-05-14 12:31 ` [PATCH MM-PART3 v2 05/12] xen/arm: mm: Introduce _PAGE_PRESENT and _PAGE_POPULATE Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 22:35 ` Stefano Stabellini
2019-06-12 13:00 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 06/12] xen/arm: mm: Sanity check any update of Xen page tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 0:10 ` Stefano Stabellini
2019-06-12 14:48 ` Julien Grall
2019-06-12 15:54 ` Stefano Stabellini
2019-06-12 15:58 ` Julien Grall
2019-05-14 12:31 ` [PATCH MM-PART3 v2 07/12] xen/arm: mm: Rework xen_pt_update_entry to avoid use xenmap_operation Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:22 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 08/12] xen/arm: mm: Remove enum xenmap_operation Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-11 22:38 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 09/12] xen/arm: mm: Use {, un}map_domain_page() to map/unmap Xen page-tables Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:25 ` Stefano Stabellini
2019-06-13 8:07 ` Julien Grall
2019-06-13 17:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 10/12] xen/arm: mm: Rework Xen page-tables walk during update Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:52 ` Stefano Stabellini
2019-06-13 8:20 ` Julien Grall
2019-06-13 17:59 ` Stefano Stabellini
2019-06-13 21:32 ` Julien Grall
2019-06-13 22:57 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 11/12] xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:33 ` Stefano Stabellini
2019-06-13 8:31 ` Julien Grall
2019-06-13 18:51 ` Stefano Stabellini
2019-06-13 21:21 ` Julien Grall
2019-06-13 22:55 ` Stefano Stabellini
2019-05-14 12:31 ` [PATCH MM-PART3 v2 12/12] xen/arm: mm: Remove set_pte_flags_on_range() Julien Grall
2019-05-14 12:31 ` [Xen-devel] " Julien Grall
2019-06-12 22:41 ` Stefano Stabellini
2019-06-13 8:51 ` Julien Grall
2019-06-13 18:04 ` Stefano Stabellini
2019-06-13 21:22 ` Julien Grall
2019-05-29 17:23 ` [PATCH MM-PART3 v2 00/12] xen/arm: Provide a generic function to update Xen PT Julien Grall
2019-05-29 17:23 ` [Xen-devel] " Julien Grall
2019-06-10 10:08 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1906111120290.13737@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Oleksandr_Tyshchenko@epam.com \
--cc=andrii_anisov@epam.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).